diff mbox series

[1/3] ASoC: dt-bindings: rockchip,rk3308-codec: add port property

Message ID 20241028213314.476776-2-dmt.yashin@gmail.com (mailing list archive)
State Accepted
Commit cc8475a07cf34891bf11a63025659d3537b638ef
Headers show
Series arm64: dts: rockchip: add Banana Pi BPI-P2 Pro board | expand

Commit Message

Dmitry Yashin Oct. 28, 2024, 9:33 p.m. UTC
Fix DTB warnings when rk3308-codec used with audio-graph-card by
documenting port property:

codec@ff560000: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Dmitry Yashin <dmt.yashin@gmail.com>
---
 .../devicetree/bindings/sound/rockchip,rk3308-codec.yaml      | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Luca Ceresoli Oct. 29, 2024, 10:25 a.m. UTC | #1
Hello Dmitry,

On Tue, 29 Oct 2024 02:33:12 +0500
Dmitry Yashin <dmt.yashin@gmail.com> wrote:

> Fix DTB warnings when rk3308-codec used with audio-graph-card by
> documenting port property:
> 
> codec@ff560000: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Dmitry Yashin <dmt.yashin@gmail.com>
> ---
>  .../devicetree/bindings/sound/rockchip,rk3308-codec.yaml      | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> index ecf3d7d968c8..2cf229a076f0 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
> @@ -48,6 +48,10 @@ properties:
>        - const: mclk_rx
>        - const: hclk
>  
> +  port:
> +    $ref: audio-graph-port.yaml#
> +    unevaluatedProperties: false

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

Also, why not adding a 'port' node to the example below? Can be done in
v2 in case you send one.

Luca
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml b/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
index ecf3d7d968c8..2cf229a076f0 100644
--- a/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
+++ b/Documentation/devicetree/bindings/sound/rockchip,rk3308-codec.yaml
@@ -48,6 +48,10 @@  properties:
       - const: mclk_rx
       - const: hclk
 
+  port:
+    $ref: audio-graph-port.yaml#
+    unevaluatedProperties: false
+
   resets:
     maxItems: 1