[v7,0/5] MCE wrapper and support for new SMCA syndrome MSRs

Message

Avadhut Naik Oct. 22, 2024, 7:36 p.m. UTC

This patchset adds a new wrapper for struct mce to prevent its bloating
and export vendor specific error information. Additionally, support is
also introduced for two new "syndrome" MSRs used in newer AMD Scalable
MCA (SMCA) systems. Also, a new "FRU Text in MCA" feature that uses these
new "syndrome" MSRs has been addded.

Patch 1 adds the new wrapper structure mce_hw_err for the struct mce
while also modifying the mce_record tracepoint to use the new wrapper.
 
Patch 2 introduces a new helper function, __print_dynamic_array(), for
logging dynamic arrays through tracepoints.
 
Patch 3 adds support for the new "syndrome" registers. They are read/printed
wherever the existing MCA_SYND register is used.
 
Patch 4 updates the function that pulls MCA information from UEFI x86
Common Platform Error Records (CPERs) to handle systems that support the
new registers.
 
Patch 5 adds support to the AMD MCE decoder module to detect and use the
"FRU Text in MCA" feature which leverages the new registers.
 
NOTE:

This set was initially submitted as part of the larger MCA Updates set.

v1: https://lore.kernel.org/linux-edac/[e-mail]/
v2: https://lore.kernel.org/linux-edac/[e-mail]/
However, since the MCA Updates set has been split up into smaller sets,
this set, going forward, will be submitted independently.

Having said that, this set set depends on and applies cleanly on top ofthe below two sets.

[1] https://lore.kernel.org/linux-edac/[e-mail]/
[2] https://lore.kernel.org/linux-edac/[e-mail]/

Changes in v2: 
 - Drop dependencies on sets [1] and [2] above and rebase on top of
   tip/master.
  
Changes in v3:
 - Move wrapper changes required in mce_read_aux() and mce_no_way_out()
   from second patch to the first patch.
 - Modify commit messages for second and fourth patch per feedback
   received.
 - Add comments to explain purpose of the new wrapper structure.
 - Incorporate suggested touchup in the third patch.
 - Remove call to memset() for the frutext string in the fourth patch.
   Instead, just ensure that the string is NULL terminated.
 - Fix SoB chains on all patches to properly reflect the patch path.

Changes in v4:
 - Resolve kernel test robot's warning on the use of memset() in
   do_machine_check().
 - Rebase on top of tip/master to avoid merge conflicts.

Changes in v5:
 - Introduce a new helper function __print_dynamic_array() for logging
   dynamic arrays through tracepoints.
 - Remove "len" field from the modified mce_record tracepoint since the
   length of a dynamic array can be fetched from its metadata.
 - Substitute __print_array() with __print_dynamic_array().

Changes in v6:
 - Introduce to_mce_hw_err macro to eliminate changes required in notifier
   chain callback functions.
 - Use the above macro in amd_decode_mce() notifier chain callback.
 - Change third parameter of __mc_scan_banks() to a pointer to the new
   wrapper, struct mce_hw_err.
 - Rebase on top of tip/master.

Changes in v7:
 - Fix initialization of struct mce_hw_err *final in do_machine_check().
 - Add parenthesis around el_size parameter in __print_dynamic_array
   macro.
 - Add Reviewed-by: Qiuxu Zhuo <[e-mail]> tag.
 - Change second parameter of __print_dynamic_array from 8 to sizeof(u8)
   to ensure that the dynamic array is parsed using a u8 pointer instead
   of u64 pointer.
 - Rebase on top of tip/master.

Links:
v1: https://lore.kernel.org/linux-edac/[e-mail]/
v2: https://lore.kernel.org/linux-edac/[e-mail]/
v3: https://lore.kernel.org/linux-edac/[e-mail]/T/#t
v4: https://lore.kernel.org/linux-edac/[e-mail]/
v5: https://lore.kernel.org/linux-edac/[e-mail]/
v6: https://lore.kernel.org/linux-edac/[e-mail]/

Avadhut Naik (2):
  x86/mce: Add wrapper for struct mce to export vendor specific info
  x86/mce, EDAC/mce_amd: Add support for new MCA_SYND{1,2} registers

Steven Rostedt (1):
  tracing: Add __print_dynamic_array() helper

Yazen Ghannam (2):
  x86/mce/apei: Handle variable register array size
  EDAC/mce_amd: Add support for FRU Text in MCA

 arch/x86/include/asm/mce.h                 |  38 +++-
 arch/x86/include/uapi/asm/mce.h            |   3 +-
 arch/x86/kernel/cpu/mce/amd.c              |  31 +--
 arch/x86/kernel/cpu/mce/apei.c             | 109 ++++++++---
 arch/x86/kernel/cpu/mce/core.c             | 217 ++++++++++++---------
 arch/x86/kernel/cpu/mce/genpool.c          |  18 +-
 arch/x86/kernel/cpu/mce/inject.c           |   4 +-
 arch/x86/kernel/cpu/mce/internal.h         |   4 +-
 drivers/edac/mce_amd.c                     |  25 ++-
 include/trace/events/mce.h                 |  49 ++---
 include/trace/stages/stage3_trace_output.h |   8 +
 include/trace/stages/stage7_class_define.h |   1 +
 samples/trace_events/trace-events-sample.h |   7 +-
 13 files changed, 334 insertions(+), 180 deletions(-)


base-commit: d7ec15ce8bdc955ce383123c4f01ad0a8155fb90

Comments

Naik, Avadhut Oct. 29, 2024, 6:14 p.m. UTC | #1

Hi,

Any further feedback on this set?
If not, can this please be considered for merging in?

On 10/22/2024 14:36, Avadhut Naik wrote:
> This patchset adds a new wrapper for struct mce to prevent its bloating
> and export vendor specific error information. Additionally, support is
> also introduced for two new "syndrome" MSRs used in newer AMD Scalable
> MCA (SMCA) systems. Also, a new "FRU Text in MCA" feature that uses these
> new "syndrome" MSRs has been addded.
[...]
> base-commit: d7ec15ce8bdc955ce383123c4f01ad0a8155fb90

Borislav Petkov Oct. 29, 2024, 6:27 p.m. UTC | #2

On Tue, Oct 29, 2024 at 01:14:16PM -0500, Naik, Avadhut wrote:
> Any further feedback on this set?
> If not, can this please be considered for merging in?

You're on the to-review list which is ever-growing. :-(

While waiting, how about you review some other people's code? Whatever you
find interesting on lkml or somewhere else...

Thx.