diff mbox series

iio: test : rescale: check null return of kunit_kmalloc

Message ID cceb503f429ae829069709ac476acef77a0e8612.1730191256.git.xiaopei01@kylinos.cn (mailing list archive)
State Changes Requested
Headers show
Series iio: test : rescale: check null return of kunit_kmalloc | expand

Commit Message

Pei Xiao Oct. 29, 2024, 8:44 a.m. UTC 
kunit_kmalloc may fail, return might be NULL and will cause
NULL pointer dereference later.

Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
---
 drivers/iio/test/iio-test-rescale.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Markus Elfring Oct. 29, 2024, 8:55 p.m. UTC | #1 
> kunit_kmalloc may fail, return might be NULL and will cause
> NULL pointer dereference later.

* Please choose an imperative wording for an improved change description.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n94

* How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n145


Regards,
Markus
Pei Xiao Oct. 30, 2024, 3:33 a.m. UTC | #2 
On 2024/10/30 04:55, Markus Elfring wrote:
>> kunit_kmalloc may fail, return might be NULL and will cause
>> NULL pointer dereference later.
> 
> * Please choose an imperative wording for an improved change description.
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n94
> 
> * How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
>    https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n145
> 
> 
> Regards,
> Markus

Hi Markus,
   Thanks for your help,I will modify the commit information and add Fixes.

Thanks!
Pei Xiao.
diff mbox series

Patch

diff --git a/drivers/iio/test/iio-test-rescale.c b/drivers/iio/test/iio-test-rescale.c
index 31ee55a6faed..11bfff6636a3 100644
--- a/drivers/iio/test/iio-test-rescale.c
+++ b/drivers/iio/test/iio-test-rescale.c
@@ -652,6 +652,8 @@  static void iio_rescale_test_scale(struct kunit *test)
 	int rel_ppm;
 	int ret;
 
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buff);
+
 	rescale.numerator = t->numerator;
 	rescale.denominator = t->denominator;
 	rescale.offset = t->offset;
@@ -681,6 +683,8 @@  static void iio_rescale_test_offset(struct kunit *test)
 	int values[2];
 	int ret;
 
+	KUNIT_ASSERT_NOT_ERR_OR_NULL(test, buff_off);
+
 	rescale.numerator = t->numerator;
 	rescale.denominator = t->denominator;
 	rescale.offset = t->offset;