| Message ID | 20241025131442.112862-4-peter.griffin@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5278917250a58792b30a9f9b6e9b28dca9d30965 |
| Headers | show |
| Series | UFS cleanups and enhancements to ufs-exynos for gs101 | expand |
On 10/25/24 2:14 PM, Peter Griffin wrote: > This flag is not required for gs101 SoC. > nitpick, use imperative Auto clk control works fine for gs101, remove EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL flag. (or something along these lines) Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org> > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > --- > drivers/ufs/host/ufs-exynos.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c > index 939d08bce545..d685d3e93ea1 100644 > --- a/drivers/ufs/host/ufs-exynos.c > +++ b/drivers/ufs/host/ufs-exynos.c > @@ -2142,8 +2142,7 @@ static const struct exynos_ufs_drv_data gs101_ufs_drvs = { > UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR | > UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL | > UFSHCD_QUIRK_SKIP_DEF_UNIPRO_TIMEOUT_SETTING, > - .opts = EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL | > - EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR | > + .opts = EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR | > EXYNOS_UFS_OPT_UFSPR_SECURE | > EXYNOS_UFS_OPT_TIMER_TICK_SELECT, > .drv_init = exynosauto_ufs_drv_init,
diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index 939d08bce545..d685d3e93ea1 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -2142,8 +2142,7 @@ static const struct exynos_ufs_drv_data gs101_ufs_drvs = { UFSHCD_QUIRK_BROKEN_OCS_FATAL_ERROR | UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL | UFSHCD_QUIRK_SKIP_DEF_UNIPRO_TIMEOUT_SETTING, - .opts = EXYNOS_UFS_OPT_BROKEN_AUTO_CLK_CTRL | - EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR | + .opts = EXYNOS_UFS_OPT_SKIP_CONFIG_PHY_ATTR | EXYNOS_UFS_OPT_UFSPR_SECURE | EXYNOS_UFS_OPT_TIMER_TICK_SELECT, .drv_init = exynosauto_ufs_drv_init,
This flag is not required for gs101 SoC. Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- drivers/ufs/host/ufs-exynos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)