| Message ID | 20241030094728.1714034-1-quic_chejiang@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] dt-bindings: bluetooth: Add qca6698 compatible string | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
On 30/10/2024 10:47, Cheng Jiang wrote: > Add QCA6698 qcom,qca6698-bt compatible strings. > > Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> > --- > Changes in v2: > - Add the compatibility for qcom,qca6698-bt > > --- > .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ > 1 file changed, 2 insertions(+) Please wait with v2, v3 and so on. Where is any user of this? Nothing in commit msg explains why this patch is needed without users. Best regards, Krzysztof
Hi Krzysztof, We have a new chip(qca6698) to attach on sa8775p-ride board. On 10/30/2024 6:00 PM, Krzysztof Kozlowski wrote: > On 30/10/2024 10:47, Cheng Jiang wrote: >> Add QCA6698 qcom,qca6698-bt compatible strings. >> >> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> >> --- >> Changes in v2: >> - Add the compatibility for qcom,qca6698-bt >> >> --- >> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ >> 1 file changed, 2 insertions(+) > > Please wait with v2, v3 and so on. > > Where is any user of this? Nothing in commit msg explains why this patch > is needed without users. > > Best regards, > Krzysztof >
On 30/10/2024 11:18, Cheng Jiang wrote: > Hi Krzysztof, > > We have a new chip(qca6698) to attach on sa8775p-ride board. > > > On 10/30/2024 6:00 PM, Krzysztof Kozlowski wrote: >> On 30/10/2024 10:47, Cheng Jiang wrote: >>> Add QCA6698 qcom,qca6698-bt compatible strings. >>> >>> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> >>> --- >>> Changes in v2: >>> - Add the compatibility for qcom,qca6698-bt >>> >>> --- >>> .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> Please wait with v2, v3 and so on. >> >> Where is any user of this? Nothing in commit msg explains why this patch >> is needed without users. >> Don't top-post. If you have new chip, where is this binding used? I said there are no users of it and you claim there is some, so where? Point me to the patch and explain why it is not in this set. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml index 7bb68311c609..f8eb5c09c1bf 100644 --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml @@ -18,6 +18,7 @@ properties: enum: - qcom,qca2066-bt - qcom,qca6174-bt + - qcom,qca6698-bt - qcom,qca9377-bt - qcom,wcn3988-bt - qcom,wcn3990-bt @@ -169,6 +170,7 @@ allOf: compatible: contains: enum: + - qcom,qca6698-bt - qcom,wcn6855-bt then: required:
Add QCA6698 qcom,qca6698-bt compatible strings. Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> --- Changes in v2: - Add the compatibility for qcom,qca6698-bt --- .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml | 2 ++ 1 file changed, 2 insertions(+)