| Message ID | 20241028133941.54264-1-lists@steffen.cc (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] drm: xlnx: zynqmp_disp: layer may be null while releasing | expand |
Hi, On 28/10/2024 15:39, Steffen Dirkwinkel wrote: > From: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com> > > layer->info can be null if we have an error on the first layer in > zynqmp_disp_create_layers > > Fixes: 1836fd5ed98d ("drm: xlnx: zynqmp_dpsub: Minimize usage of global flag") > Signed-off-by: Steffen Dirkwinkel <s.dirkwinkel@beckhoff.com> > --- > drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c > index 9368acf56eaf..e4e0e299e8a7 100644 > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c > @@ -1200,6 +1200,9 @@ static void zynqmp_disp_layer_release_dma(struct zynqmp_disp *disp, > { > unsigned int i; > > + if (!layer->info) > + return; > + > for (i = 0; i < layer->info->num_channels; i++) { > struct zynqmp_disp_layer_dma *dma = &layer->dmas[i]; > Thanks, will apply to drm-misc-next. Tomi
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c index 9368acf56eaf..e4e0e299e8a7 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c @@ -1200,6 +1200,9 @@ static void zynqmp_disp_layer_release_dma(struct zynqmp_disp *disp, { unsigned int i; + if (!layer->info) + return; + for (i = 0; i < layer->info->num_channels; i++) { struct zynqmp_disp_layer_dma *dma = &layer->dmas[i];