diff mbox series

[net-next] MAINTAINERS: Remove self from DSA entry

Message ID 20241029003659.3853796-1-f.fainelli@gmail.com (mailing list archive)
State Superseded
Delegated to: Netdev Maintainers
Headers show
Series [net-next] MAINTAINERS: Remove self from DSA entry | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 0 of 0 maintainers
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch warning WARNING: Missing commit description - Add an appropriate one
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-30--21-00 (tests: 776)

Commit Message

Florian Fainelli Oct. 29, 2024, 12:36 a.m. UTC
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 MAINTAINERS | 1 -
 1 file changed, 1 deletion(-)

Comments

Vladimir Oltean Oct. 29, 2024, 10:49 a.m. UTC | #1
On Mon, Oct 28, 2024 at 05:36:58PM -0700, Florian Fainelli wrote:
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  MAINTAINERS | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f39ab140710f..cde4a51fd3a1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16031,7 +16031,6 @@ F:	drivers/net/wireless/
>  
>  NETWORKING [DSA]
>  M:	Andrew Lunn <andrew@lunn.ch>
> -M:	Florian Fainelli <f.fainelli@gmail.com>
>  M:	Vladimir Oltean <olteanv@gmail.com>
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/net/dsa/
> -- 
> 2.43.0
> 

This is unexpected. What has happened?
Florian Fainelli Oct. 29, 2024, 4:05 p.m. UTC | #2
On 10/29/24 03:49, Vladimir Oltean wrote:
> On Mon, Oct 28, 2024 at 05:36:58PM -0700, Florian Fainelli wrote:
>> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>> ---
>>   MAINTAINERS | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index f39ab140710f..cde4a51fd3a1 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -16031,7 +16031,6 @@ F:	drivers/net/wireless/
>>   
>>   NETWORKING [DSA]
>>   M:	Andrew Lunn <andrew@lunn.ch>
>> -M:	Florian Fainelli <f.fainelli@gmail.com>
>>   M:	Vladimir Oltean <olteanv@gmail.com>
>>   S:	Maintained
>>   F:	Documentation/devicetree/bindings/net/dsa/
>> -- 
>> 2.43.0
>>
> 
> This is unexpected. What has happened?

Nothing, and that's the main motivation, most, if not all of my reviews 
of DSA patches have been extremely superficial and mostly an additional 
stamp on top of someone's else review. At this point I don't feel like I 
am contributing anything to the subsystem that warrants me being listed 
as a maintainer of that subsystem. There are other factors like having a 
somewhat different role from when I was working on DSA at the time.
Vladimir Oltean Oct. 30, 2024, 2:53 p.m. UTC | #3
On Tue, Oct 29, 2024 at 09:05:51AM -0700, Florian Fainelli wrote:
> On 10/29/24 03:49, Vladimir Oltean wrote:
> > This is unexpected. What has happened?
> 
> Nothing, and that's the main motivation, most, if not all of my reviews of
> DSA patches have been extremely superficial and mostly an additional stamp
> on top of someone's else review. At this point I don't feel like I am
> contributing anything to the subsystem that warrants me being listed as a
> maintainer of that subsystem. There are other factors like having a somewhat
> different role from when I was working on DSA at the time.
> -- 
> Florian

I see. There's nothing wrong that priorities change. Thank you for the
benefit you've brought to the DSA subsystem with your journey, starting with
transitioning non-Marvell switches to it from swconfig, to papers, presentations,
being nice and patient to newcomers (me at least).

I kinda wish there was a way for people to get recognition for their work
in CREDITS even if they don't disappear completely from the picture.
Hmm, looking at that file, I do recognize some familiar names who are still
active in other areas: Geert Uytterhoeven, Arnd Bergmann, Marc Zyngier...
Would you be interested in getting moved there? At least I believe that
your contribution is significant enough to deserve that.
Andrew Lunn Oct. 30, 2024, 3:51 p.m. UTC | #4
> I kinda wish there was a way for people to get recognition for their work
> in CREDITS even if they don't disappear completely from the picture.
> Hmm, looking at that file, I do recognize some familiar names who are still
> active in other areas: Geert Uytterhoeven, Arnd Bergmann, Marc Zyngier...
> Would you be interested in getting moved there? At least I believe that
> your contribution is significant enough to deserve that.

+1

	Andrew
Florian Fainelli Oct. 30, 2024, 4:37 p.m. UTC | #5
On 10/30/24 07:53, Vladimir Oltean wrote:
> On Tue, Oct 29, 2024 at 09:05:51AM -0700, Florian Fainelli wrote:
>> On 10/29/24 03:49, Vladimir Oltean wrote:
>>> This is unexpected. What has happened?
>>
>> Nothing, and that's the main motivation, most, if not all of my reviews of
>> DSA patches have been extremely superficial and mostly an additional stamp
>> on top of someone's else review. At this point I don't feel like I am
>> contributing anything to the subsystem that warrants me being listed as a
>> maintainer of that subsystem. There are other factors like having a somewhat
>> different role from when I was working on DSA at the time.
>> -- 
>> Florian
> 
> I see. There's nothing wrong that priorities change. Thank you for the
> benefit you've brought to the DSA subsystem with your journey, starting with
> transitioning non-Marvell switches to it from swconfig, to papers, presentations,
> being nice and patient to newcomers (me at least).

And thank you for having stepped as up as maintainer when being asked 
to. I am really happy to see what has happened since your tenure, and 
that the unstated world domination of DSA in the SoHo switches is 
actually working :D

> 
> I kinda wish there was a way for people to get recognition for their work
> in CREDITS even if they don't disappear completely from the picture.
> Hmm, looking at that file, I do recognize some familiar names who are still
> active in other areas: Geert Uytterhoeven, Arnd Bergmann, Marc Zyngier...
> Would you be interested in getting moved there? At least I believe that
> your contribution is significant enough to deserve that.

OK, if you feel this is deserved, sure why not, thanks!
Jakub Kicinski Oct. 30, 2024, 11:45 p.m. UTC | #6
On Wed, 30 Oct 2024 09:37:38 -0700 Florian Fainelli wrote:
> > I kinda wish there was a way for people to get recognition for their work
> > in CREDITS even if they don't disappear completely from the picture.
> > Hmm, looking at that file, I do recognize some familiar names who are still
> > active in other areas: Geert Uytterhoeven, Arnd Bergmann, Marc Zyngier...
> > Would you be interested in getting moved there? At least I believe that
> > your contribution is significant enough to deserve that.  
> 
> OK, if you feel this is deserved, sure why not, thanks!

Makes perfect sense to me FWIW, could you make it part of a v2 patch?
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index f39ab140710f..cde4a51fd3a1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16031,7 +16031,6 @@  F:	drivers/net/wireless/
 
 NETWORKING [DSA]
 M:	Andrew Lunn <andrew@lunn.ch>
-M:	Florian Fainelli <f.fainelli@gmail.com>
 M:	Vladimir Oltean <olteanv@gmail.com>
 S:	Maintained
 F:	Documentation/devicetree/bindings/net/dsa/