crypto: Remove unused asymmetric_keys functions

Commit Message

Dr. David Alan Gilbert Oct. 22, 2024, 12:24 a.m. UTC

From: "Dr. David Alan Gilbert" <[e-mail]>

encrypt_blob(), decrypt_blob() and create_signature() were some of the
functions added in 2018 by
commit 5a30771832aa ("KEYS: Provide missing asymmetric key subops for new
key type ops [ver #2]")
however, they've not been used.

Remove them.

Signed-off-by: Dr. David Alan Gilbert <[e-mail]>
---
 crypto/asymmetric_keys/signature.c | 63 ------------------------------
 include/crypto/public_key.h        |  3 --
 2 files changed, 66 deletions(-)

Comments

Jarkko Sakkinen Oct. 25, 2024, 2:38 p.m. UTC | #1

On Tue Oct 22, 2024 at 3:24 AM EEST, linux wrote:
> From: "Dr. David Alan Gilbert" <[e-mail]>
>
> encrypt_blob(), decrypt_blob() and create_signature() were some of the
> functions added in 2018 by
> commit 5a30771832aa ("KEYS: Provide missing asymmetric key subops for new
> key type ops [ver #2]")
> however, they've not been used.
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <[e-mail]>

LGTM, thanks.

Reviewed-by: Jarkko Sakkinen <[e-mail]>

BR, Jarkko

Jarkko Sakkinen Oct. 31, 2024, 12:03 a.m. UTC | #2

On Fri Oct 25, 2024 at 5:38 PM EEST, Jarkko Sakkinen wrote:
> On Tue Oct 22, 2024 at 3:24 AM EEST, linux wrote:
> > From: "Dr. David Alan Gilbert" <[e-mail]>
> >
> > encrypt_blob(), decrypt_blob() and create_signature() were some of the
> > functions added in 2018 by
> > commit 5a30771832aa ("KEYS: Provide missing asymmetric key subops for new
> > key type ops [ver #2]")
> > however, they've not been used.
> >
> > Remove them.
> >
> > Signed-off-by: Dr. David Alan Gilbert <[e-mail]>
>
> LGTM, thanks.
>
> Reviewed-by: Jarkko Sakkinen <[e-mail]>

Herbert, would you mind picking this up for you future crypto PR? I took
by "mistake/reflex" to my master unintentionally.

BR, Jarkko

Herbert Xu Nov. 2, 2024, 10:26 a.m. UTC | #3

On Tue, Oct 22, 2024 at 01:24:34AM +0100, [e-mail] wrote:
> From: "Dr. David Alan Gilbert" <[e-mail]>
> 
> encrypt_blob(), decrypt_blob() and create_signature() were some of the
> functions added in 2018 by
> commit 5a30771832aa ("KEYS: Provide missing asymmetric key subops for new
> key type ops [ver #2]")
> however, they've not been used.
> 
> Remove them.
> 
> Signed-off-by: Dr. David Alan Gilbert <[e-mail]>
> ---
>  crypto/asymmetric_keys/signature.c | 63 ------------------------------
>  include/crypto/public_key.h        |  3 --
>  2 files changed, 66 deletions(-)

Patch applied.  Thanks.

Patch

diff --git a/crypto/asymmetric_keys/signature.c b/crypto/asymmetric_keys/signature.c
index 2deff81f8af5..041d04b5c953 100644
--- a/crypto/asymmetric_keys/signature.c
+++ b/crypto/asymmetric_keys/signature.c
@@ -64,69 +64,6 @@  int query_asymmetric_key(const struct kernel_pkey_params *params,
 }
 EXPORT_SYMBOL_GPL(query_asymmetric_key);
 
-/**
- * encrypt_blob - Encrypt data using an asymmetric key
- * @params: Various parameters
- * @data: Data blob to be encrypted, length params->data_len
- * @enc: Encrypted data buffer, length params->enc_len
- *
- * Encrypt the specified data blob using the private key specified by
- * params->key.  The encrypted data is wrapped in an encoding if
- * params->encoding is specified (eg. "pkcs1").
- *
- * Returns the length of the data placed in the encrypted data buffer or an
- * error.
- */
-int encrypt_blob(struct kernel_pkey_params *params,
-		 const void *data, void *enc)
-{
-	params->op = kernel_pkey_encrypt;
-	return asymmetric_key_eds_op(params, data, enc);
-}
-EXPORT_SYMBOL_GPL(encrypt_blob);
-
-/**
- * decrypt_blob - Decrypt data using an asymmetric key
- * @params: Various parameters
- * @enc: Encrypted data to be decrypted, length params->enc_len
- * @data: Decrypted data buffer, length params->data_len
- *
- * Decrypt the specified data blob using the private key specified by
- * params->key.  The decrypted data is wrapped in an encoding if
- * params->encoding is specified (eg. "pkcs1").
- *
- * Returns the length of the data placed in the decrypted data buffer or an
- * error.
- */
-int decrypt_blob(struct kernel_pkey_params *params,
-		 const void *enc, void *data)
-{
-	params->op = kernel_pkey_decrypt;
-	return asymmetric_key_eds_op(params, enc, data);
-}
-EXPORT_SYMBOL_GPL(decrypt_blob);
-
-/**
- * create_signature - Sign some data using an asymmetric key
- * @params: Various parameters
- * @data: Data blob to be signed, length params->data_len
- * @enc: Signature buffer, length params->enc_len
- *
- * Sign the specified data blob using the private key specified by params->key.
- * The signature is wrapped in an encoding if params->encoding is specified
- * (eg. "pkcs1").  If the encoding needs to know the digest type, this can be
- * passed through params->hash_algo (eg. "sha1").
- *
- * Returns the length of the data placed in the signature buffer or an error.
- */
-int create_signature(struct kernel_pkey_params *params,
-		     const void *data, void *enc)
-{
-	params->op = kernel_pkey_sign;
-	return asymmetric_key_eds_op(params, data, enc);
-}
-EXPORT_SYMBOL_GPL(create_signature);
-
 /**
  * verify_signature - Initiate the use of an asymmetric key to verify a signature
  * @key: The asymmetric key to verify against
diff --git a/include/crypto/public_key.h b/include/crypto/public_key.h
index b7f308977c84..81098e00c08f 100644
--- a/include/crypto/public_key.h
+++ b/include/crypto/public_key.h
@@ -104,9 +104,6 @@  static inline int restrict_link_by_digsig(struct key *dest_keyring,
 extern int query_asymmetric_key(const struct kernel_pkey_params *,
 				struct kernel_pkey_query *);
 
-extern int encrypt_blob(struct kernel_pkey_params *, const void *, void *);
-extern int decrypt_blob(struct kernel_pkey_params *, const void *, void *);
-extern int create_signature(struct kernel_pkey_params *, const void *, void *);
 extern int verify_signature(const struct key *,
 			    const struct public_key_signature *);