| Message ID | 20241029020931.42311-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,-next] i2c: qcom-cci: Remove the unused variable cci_clk_rate | expand |
On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: > Variable ret is not effectively used, so delete it. > > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > --- > Changes in v2: > -Remove redundant code. > > drivers/i2c/busses/i2c-qcom-cci.c | 9 --------- > 1 file changed, 9 deletions(-) Fixes: 823dfb7bdb21 ("i2c: qcom-cci: Stop complaining about DT set clock rate") Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 10/29/24 04:09, Jiapeng Chong wrote: > Variable ret is not effectively used, so delete it. Variable ret is not deleted, the commit message is misleading. > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> With the needed change to the commit message: Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir
Hi Jiapeng, On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: > Variable ret is not effectively used, so delete it. > > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> thanks for your patch! Applied to i2c/i2c-host Thanks, Andi
Hi Andi, On 10/31/24 12:44, Andi Shyti wrote: > Hi Jiapeng, > > On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: >> Variable ret is not effectively used, so delete it. >> >> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. >> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 >> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > thanks for your patch! Applied to i2c/i2c-host > > Thanks, > Andi > FWIW I've noticed that my Reviewed-by tag was added to the accepted change, while it was the conditional one... Actually I don't know how to be aware of such nuances, if only b4 tool is used, likely there is no way for it. Hopefully I'm not too picky with it. -- Best wishes, Vladimir
On 10/31/24 13:13, Vladimir Zapolskiy wrote: > Hi Andi, > > On 10/31/24 12:44, Andi Shyti wrote: >> Hi Jiapeng, >> >> On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: >>> Variable ret is not effectively used, so delete it. >>> >>> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. >>> >>> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 >>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> >> >> thanks for your patch! Applied to i2c/i2c-host >> >> Thanks, >> Andi >> > > FWIW I've noticed that my Reviewed-by tag was added to the accepted change, > while it was the conditional one... Actually I don't know how to be aware > of such nuances, if only b4 tool is used, likely there is no way for it. > > Hopefully I'm not too picky with it. If it still matters, this one apparently unnoticed candidate would have been a better choice: https://lore.kernel.org/linux-i2c/20241031095339.76535-1-jiapeng.chong@linux.alibaba.com -- Best wishes, Vladimir
Hi Vladimir, On Thu, Oct 31, 2024 at 01:13:24PM +0200, Vladimir Zapolskiy wrote: > Hi Andi, > > On 10/31/24 12:44, Andi Shyti wrote: > > Hi Jiapeng, > > > > On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: > > > Variable ret is not effectively used, so delete it. > > > > > > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. > > > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > > > thanks for your patch! Applied to i2c/i2c-host > > > > Thanks, > > Andi > > > > FWIW I've noticed that my Reviewed-by tag was added to the accepted change, > while it was the conditional one... Actually I don't know how to be aware > of such nuances, if only b4 tool is used, likely there is no way for it. I thought the change that made your r-b conditional was the Fixes tag, right? That is added. Have I missed anything? (I noticed later the v3, but it's basically identical to the one I pushed). > Hopefully I'm not too picky with it. Absolutely not! Please, keep pinging me if you see anything I might have missed. Thanks, Andi
Hi Andi, On 10/31/24 13:41, Andi Shyti wrote: > Hi Vladimir, > > On Thu, Oct 31, 2024 at 01:13:24PM +0200, Vladimir Zapolskiy wrote: >> Hi Andi, >> >> On 10/31/24 12:44, Andi Shyti wrote: >>> Hi Jiapeng, >>> >>> On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: >>>> Variable ret is not effectively used, so delete it. >>>> >>>> drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. >>>> >>>> Reported-by: Abaci Robot <abaci@linux.alibaba.com> >>>> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 >>>> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> >>> >>> thanks for your patch! Applied to i2c/i2c-host >>> >>> Thanks, >>> Andi >>> >> >> FWIW I've noticed that my Reviewed-by tag was added to the accepted change, >> while it was the conditional one... Actually I don't know how to be aware >> of such nuances, if only b4 tool is used, likely there is no way for it. > > I thought the change that made your r-b conditional was the > Fixes tag, right? That is added. Have I missed anything? ah, no, it was about the copy-pasted commit message, which mentions a much more popular 'ret' local variable. > (I noticed later the v3, but it's basically identical to the one > I pushed). > Well, I believe my concern about a commit message has quite low significance, so let it be kept as is, the most essential code change part is untouched. >> Hopefully I'm not too picky with it. > > Absolutely not! Please, keep pinging me if you see anything I > might have missed. Thank you! -- Best wishes, Vladmir
Hi Vladimir, On Thu, Oct 31, 2024 at 01:59:45PM +0200, Vladimir Zapolskiy wrote: > On 10/31/24 13:41, Andi Shyti wrote: > > On Thu, Oct 31, 2024 at 01:13:24PM +0200, Vladimir Zapolskiy wrote: > > > On 10/31/24 12:44, Andi Shyti wrote: > > > > On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: > > > > > Variable ret is not effectively used, so delete it. > > > > > > > > > > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. > > > > > > > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > > > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 > > > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> > > > > > > > > thanks for your patch! Applied to i2c/i2c-host > > > > > > > > Thanks, > > > > Andi > > > > > > > > > > FWIW I've noticed that my Reviewed-by tag was added to the accepted change, > > > while it was the conditional one... Actually I don't know how to be aware > > > of such nuances, if only b4 tool is used, likely there is no way for it. > > > > I thought the change that made your r-b conditional was the > > Fixes tag, right? That is added. Have I missed anything? > > ah, no, it was about the copy-pasted commit message, which mentions a much > more popular 'ret' local variable. oh yes, the new commit message says: "Variable cci_clk_rate is not effectively used, so delete it." I'm sorry, I will fix it. Thanks, Andi
diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c index 5cc791b3b57d..a0ef43e99751 100644 --- a/drivers/i2c/busses/i2c-qcom-cci.c +++ b/drivers/i2c/busses/i2c-qcom-cci.c @@ -523,7 +523,6 @@ static const struct dev_pm_ops qcom_cci_pm = { static int cci_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - unsigned long cci_clk_rate = 0; struct device_node *child; struct resource *r; struct cci *cci; @@ -594,14 +593,6 @@ static int cci_probe(struct platform_device *pdev) return dev_err_probe(dev, -EINVAL, "not enough clocks in DT\n"); cci->nclocks = ret; - /* Retrieve CCI clock rate */ - for (i = 0; i < cci->nclocks; i++) { - if (!strcmp(cci->clocks[i].id, "cci")) { - cci_clk_rate = clk_get_rate(cci->clocks[i].clk); - break; - } - } - ret = cci_enable_clocks(cci); if (ret < 0) return ret;
Variable ret is not effectively used, so delete it. drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- Changes in v2: -Remove redundant code. drivers/i2c/busses/i2c-qcom-cci.c | 9 --------- 1 file changed, 9 deletions(-)