| Message ID | 20241104145051.3088231-1-lihuafei1@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] media: atomisp: Add check for rgby_data memory allocation failure | expand |
On Mon, Nov 04, 2024 at 10:50:51PM +0800, Li Huafei wrote: > In ia_css_3a_statistics_allocate(), there is no check on the allocation > result of the rgby_data memory. If rgby_data is not successfully > allocated, it may trigger the assert(host_stats->rgby_data) assertion in > ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue. ... > --- a/drivers/staging/media/atomisp/pci/sh_css_params.c > +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c > @@ -4181,6 +4181,8 @@ ia_css_3a_statistics_allocate(const struct ia_css_3a_grid_info *grid) > goto err; > /* No weighted histogram, no structure, treat the histogram data as a byte dump in a byte array */ > me->rgby_data = kvmalloc(sizeof_hmem(HMEM0_ID), GFP_KERNEL); > + if (!me->rgby_data) > + goto err; Which kernel version are you patching? The problem, you have reported here was fixed ~4.5 years ago.
On Mon, Nov 04, 2024 at 10:22:53AM +0200, Andy Shevchenko wrote: > On Mon, Nov 04, 2024 at 10:50:51PM +0800, Li Huafei wrote: > > In ia_css_3a_statistics_allocate(), there is no check on the allocation > > result of the rgby_data memory. If rgby_data is not successfully > > allocated, it may trigger the assert(host_stats->rgby_data) assertion in > > ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue. ... > > --- a/drivers/staging/media/atomisp/pci/sh_css_params.c > > +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c > > @@ -4181,6 +4181,8 @@ ia_css_3a_statistics_allocate(const struct ia_css_3a_grid_info *grid) > > goto err; > > /* No weighted histogram, no structure, treat the histogram data as a byte dump in a byte array */ > > me->rgby_data = kvmalloc(sizeof_hmem(HMEM0_ID), GFP_KERNEL); > > + if (!me->rgby_data) > > + goto err; > > Which kernel version are you patching? > > The problem, you have reported here was fixed ~4.5 years ago. Ah, sorry, I misread the line. Indeed, this one is still present in the current code base. Reviewed-by: Andy Shevchenko <andy@kernel.org>
…
> ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue.
Please choose an imperative wording for an improved change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n94
Regards,
Markus
On Mon, Nov 04, 2024 at 11:15:21AM +0100, Markus Elfring wrote: > … > > ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue. > > Please choose an imperative wording for an improved change description. > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n94 > > Regards, > Markus > Hi, This is the semi-friendly patch-bot of Greg Kroah-Hartman. Markus, you seem to have sent a nonsensical or otherwise pointless review comment to a patch submission on a Linux kernel developer mailing list. I strongly suggest that you not do this anymore. Please do not bother developers who are actively working to produce patches and features with comments that, in the end, are a waste of time. Patch submitter, please ignore Markus's suggestion; you do not need to follow it at all. The person/bot/AI that sent it is being ignored by almost all Linux kernel maintainers for having a persistent pattern of behavior of producing distracting and pointless commentary, and inability to adapt to feedback. Please feel free to also ignore emails from them. thanks, greg k-h's patch email bot
Hi, On 4-Nov-24 3:50 PM, Li Huafei wrote: > In ia_css_3a_statistics_allocate(), there is no check on the allocation > result of the rgby_data memory. If rgby_data is not successfully > allocated, it may trigger the assert(host_stats->rgby_data) assertion in > ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue. > > Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") > Signed-off-by: Li Huafei <lihuafei1@huawei.com> Thank you for your patch(es). I have merged this/these in my media-atomisp branch: https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp And this/these will be included in my next pull-request to Mauro (to media subsystem maintainer) Regards, Hans > --- > Changes in v2: > - Corrects the "Fixes" tag. > --- > drivers/staging/media/atomisp/pci/sh_css_params.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c > index 232744973ab8..b1feb6f6ebe8 100644 > --- a/drivers/staging/media/atomisp/pci/sh_css_params.c > +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c > @@ -4181,6 +4181,8 @@ ia_css_3a_statistics_allocate(const struct ia_css_3a_grid_info *grid) > goto err; > /* No weighted histogram, no structure, treat the histogram data as a byte dump in a byte array */ > me->rgby_data = kvmalloc(sizeof_hmem(HMEM0_ID), GFP_KERNEL); > + if (!me->rgby_data) > + goto err; > > IA_CSS_LEAVE("return=%p", me); > return me;
diff --git a/drivers/staging/media/atomisp/pci/sh_css_params.c b/drivers/staging/media/atomisp/pci/sh_css_params.c index 232744973ab8..b1feb6f6ebe8 100644 --- a/drivers/staging/media/atomisp/pci/sh_css_params.c +++ b/drivers/staging/media/atomisp/pci/sh_css_params.c @@ -4181,6 +4181,8 @@ ia_css_3a_statistics_allocate(const struct ia_css_3a_grid_info *grid) goto err; /* No weighted histogram, no structure, treat the histogram data as a byte dump in a byte array */ me->rgby_data = kvmalloc(sizeof_hmem(HMEM0_ID), GFP_KERNEL); + if (!me->rgby_data) + goto err; IA_CSS_LEAVE("return=%p", me); return me;
In ia_css_3a_statistics_allocate(), there is no check on the allocation result of the rgby_data memory. If rgby_data is not successfully allocated, it may trigger the assert(host_stats->rgby_data) assertion in ia_css_s3a_hmem_decode(). Adding a check to fix this potential issue. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Li Huafei <lihuafei1@huawei.com> --- Changes in v2: - Corrects the "Fixes" tag. --- drivers/staging/media/atomisp/pci/sh_css_params.c | 2 ++ 1 file changed, 2 insertions(+)