| Message ID | 20241104144204.114279-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sm8650: Fix CDSP context banks unit addresses | expand |
On 4.11.2024 3:42 PM, Krzysztof Kozlowski wrote: > There is a mismatch between 'reg' property and unit address for last > there CDSP compute context banks. Current values were taken as-is from > downstream source. Considering that 'reg' is used by Linux driver as > SID of context bank and that least significant bytes of IOMMU value > match the 'reg', assume the unit-address is wrong and needs fixing. > This also won't have any practical impact, except adhering to Devicetree > spec. > > Fixes: dae8cdb0a9e1 ("arm64: dts: qcom: sm8650: Add three missing fastrpc-compute-cb nodes") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
On 04/11/2024 15:42, Krzysztof Kozlowski wrote: > There is a mismatch between 'reg' property and unit address for last > there CDSP compute context banks. Current values were taken as-is from > downstream source. Considering that 'reg' is used by Linux driver as > SID of context bank and that least significant bytes of IOMMU value > match the 'reg', assume the unit-address is wrong and needs fixing. > This also won't have any practical impact, except adhering to Devicetree > spec. > > Fixes: dae8cdb0a9e1 ("arm64: dts: qcom: sm8650: Add three missing fastrpc-compute-cb nodes") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi > index 3d8a807a81c9..367fdd090768 100644 > --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi > @@ -5622,7 +5622,7 @@ compute-cb@8 { > > /* note: secure cb9 in downstream */ > > - compute-cb@10 { > + compute-cb@12 { > compatible = "qcom,fastrpc-compute-cb"; > reg = <12>; > > @@ -5632,7 +5632,7 @@ compute-cb@10 { > dma-coherent; > }; > > - compute-cb@11 { > + compute-cb@13 { > compatible = "qcom,fastrpc-compute-cb"; > reg = <13>; > > @@ -5642,7 +5642,7 @@ compute-cb@11 { > dma-coherent; > }; > > - compute-cb@12 { > + compute-cb@14 { > compatible = "qcom,fastrpc-compute-cb"; > reg = <14>; > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi index 3d8a807a81c9..367fdd090768 100644 --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi @@ -5622,7 +5622,7 @@ compute-cb@8 { /* note: secure cb9 in downstream */ - compute-cb@10 { + compute-cb@12 { compatible = "qcom,fastrpc-compute-cb"; reg = <12>; @@ -5632,7 +5632,7 @@ compute-cb@10 { dma-coherent; }; - compute-cb@11 { + compute-cb@13 { compatible = "qcom,fastrpc-compute-cb"; reg = <13>; @@ -5642,7 +5642,7 @@ compute-cb@11 { dma-coherent; }; - compute-cb@12 { + compute-cb@14 { compatible = "qcom,fastrpc-compute-cb"; reg = <14>;
There is a mismatch between 'reg' property and unit address for last there CDSP compute context banks. Current values were taken as-is from downstream source. Considering that 'reg' is used by Linux driver as SID of context bank and that least significant bytes of IOMMU value match the 'reg', assume the unit-address is wrong and needs fixing. This also won't have any practical impact, except adhering to Devicetree spec. Fixes: dae8cdb0a9e1 ("arm64: dts: qcom: sm8650: Add three missing fastrpc-compute-cb nodes") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8650.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)