[v6,00/11] Combine the two UFS driver scsi_add_host() calls

Message

Bart Van Assche Oct. 16, 2024, 8:11 p.m. UTC

Hi Martin,

In the UFS driver the legacy and MCQ scsi_add_host() calls occur in different
functions. This patch series reduces the number of scsi_add_host() calls from
two to one and hence makes the UFS driver easier to maintain.

Please consider this patch series for the next merge window.

Thanks,

Bart.

Changes compared to v5:
 - Rebased this patch series on top of the v6.12-rc kernel.
 - Removed the probe_start member variable again from struct ufs_hba.
 - Renamed ufshcd_process_device_init_result() into
   ufshcd_process_probe_result().
 - Converted a comment about UFSHCD_QUIRK_REINIT_AFTER_MAX_GEAR_SWITCH into an
   explicit test.

Changes compared to v4:
 - Left out the changes that remove the 'init_dev_params' argument.
 - Added a few new patches.

Changes compared to v3:
 - Split patch "Move the MCQ scsi_add_host() call" into two patches to make
   it easier for reviewers.

Changes compared to v2:
 - Improved several patch descriptions.
 - Moved one source code comment.

Changes compared to v1:
 - Fixed a compiler warning reported by the kernel build robot.
 - Improved patch descriptions.

Bart Van Assche (11):
  scsi: ufs: core: Introduce ufshcd_add_scsi_host()
  scsi: ufs: core: Introduce ufshcd_post_device_init()
  scsi: ufs: core: Call ufshcd_add_scsi_host() later
  scsi: ufs: core: Introduce ufshcd_process_probe_result()
  scsi: core: ufs: Convert a comment into an explicit check
  scsi: ufs: core: Move the ufshcd_device_init() calls
  scsi: ufs: core: Move the ufshcd_device_init(hba, true) call
  scsi: ufs: core: Expand the ufshcd_device_init(hba, true) call
  scsi: ufs: core: Remove code that is no longer needed
  scsi: ufs: core: Move the MCQ scsi_add_host() call
  scsi: ufs: core: Move code out of an if-statement

 drivers/ufs/core/ufshcd.c | 304 ++++++++++++++++++++++++--------------
 1 file changed, 189 insertions(+), 115 deletions(-)

Comments

Martin K. Petersen Oct. 25, 2024, 7:30 p.m. UTC | #1

Bart,

> In the UFS driver the legacy and MCQ scsi_add_host() calls occur in
> different functions. This patch series reduces the number of
> scsi_add_host() calls from two to one and hence makes the UFS driver
> easier to maintain.

Applied to 6.13/scsi-staging, thanks!

Martin K. Petersen Nov. 5, 2024, 2:32 a.m. UTC | #2

On Wed, 16 Oct 2024 13:11:56 -0700, Bart Van Assche wrote:

> In the UFS driver the legacy and MCQ scsi_add_host() calls occur in different
> functions. This patch series reduces the number of scsi_add_host() calls from
> two to one and hence makes the UFS driver easier to maintain.
> 
> Please consider this patch series for the next merge window.
> 
> Thanks,
> 
> [...]

Applied to 6.13/scsi-queue, thanks!

[01/11] scsi: ufs: core: Introduce ufshcd_add_scsi_host()
        https://git.kernel.org/mkp/scsi/c/17a973970397
[02/11] scsi: ufs: core: Introduce ufshcd_post_device_init()
        https://git.kernel.org/mkp/scsi/c/3192d28ec660
[03/11] scsi: ufs: core: Call ufshcd_add_scsi_host() later
        https://git.kernel.org/mkp/scsi/c/7702c7f64f2d
[04/11] scsi: ufs: core: Introduce ufshcd_process_probe_result()
        https://git.kernel.org/mkp/scsi/c/18ec23b60822
[05/11] scsi: ufs: core: Convert a comment into an explicit check
        https://git.kernel.org/mkp/scsi/c/093600132264
[06/11] scsi: ufs: core: Move the ufshcd_device_init() calls
        https://git.kernel.org/mkp/scsi/c/639e2043b589
[07/11] scsi: ufs: core: Move the ufshcd_device_init(hba, true) call
        https://git.kernel.org/mkp/scsi/c/69f5eb78d4b0
[08/11] scsi: ufs: core: Expand the ufshcd_device_init(hba, true) call
        https://git.kernel.org/mkp/scsi/c/a390e6677f41
[09/11] scsi: ufs: core: Remove code that is no longer needed
        https://git.kernel.org/mkp/scsi/c/b6195d02b914
[10/11] scsi: ufs: core: Move the MCQ scsi_add_host() call
        https://git.kernel.org/mkp/scsi/c/72e979225ed2
[11/11] scsi: ufs: core: Move code out of an if-statement
        https://git.kernel.org/mkp/scsi/c/b92e5937e352