| Message ID | 20241104190628.274717-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: Use of_property_present() for non-boolean properties | expand |
Hello Rob, On 2024-11-04 20:06, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Looking good to me, thanks for the patch! Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > drivers/gpio/gpio-rockchip.c | 2 +- > drivers/gpio/gpiolib-of.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-rockchip.c > b/drivers/gpio/gpio-rockchip.c > index 365ab947983c..64924bc01591 100644 > --- a/drivers/gpio/gpio-rockchip.c > +++ b/drivers/gpio/gpio-rockchip.c > @@ -602,7 +602,7 @@ static int rockchip_gpiolib_register(struct > rockchip_pin_bank *bank) > * files which don't set the "gpio-ranges" property or systems that > * utilize ACPI the driver has to call gpiochip_add_pin_range(). > */ > - if (!of_property_read_bool(bank->of_node, "gpio-ranges")) { > + if (!of_property_present(bank->of_node, "gpio-ranges")) { > struct device_node *pctlnp = of_get_parent(bank->of_node); > struct pinctrl_dev *pctldev = NULL; > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > index 880f1efcaca5..2e537ee979f3 100644 > --- a/drivers/gpio/gpiolib-of.c > +++ b/drivers/gpio/gpiolib-of.c > @@ -337,7 +337,7 @@ static void of_gpio_flags_quirks(const struct > device_node *np, > * to determine if the flags should have inverted semantics. > */ > if (IS_ENABLED(CONFIG_SPI_MASTER) && !strcmp(propname, "cs-gpios") && > - of_property_read_bool(np, "cs-gpios")) { > + of_property_present(np, "cs-gpios")) { > u32 cs; > int ret;
Am Montag, 4. November 2024, 20:06:27 CET schrieb Rob Herring (Arm): > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> With of_property_present essentially just mapping to of_property_read_bool, this change looks correct and should not introduce any functional differences Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/gpio/gpio-rockchip.c | 2 +- > drivers/gpio/gpiolib-of.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c > index 365ab947983c..64924bc01591 100644 > --- a/drivers/gpio/gpio-rockchip.c > +++ b/drivers/gpio/gpio-rockchip.c > @@ -602,7 +602,7 @@ static int rockchip_gpiolib_register(struct rockchip_pin_bank *bank) > * files which don't set the "gpio-ranges" property or systems that > * utilize ACPI the driver has to call gpiochip_add_pin_range(). > */ > - if (!of_property_read_bool(bank->of_node, "gpio-ranges")) { > + if (!of_property_present(bank->of_node, "gpio-ranges")) { > struct device_node *pctlnp = of_get_parent(bank->of_node); > struct pinctrl_dev *pctldev = NULL; > > diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c > index 880f1efcaca5..2e537ee979f3 100644 > --- a/drivers/gpio/gpiolib-of.c > +++ b/drivers/gpio/gpiolib-of.c > @@ -337,7 +337,7 @@ static void of_gpio_flags_quirks(const struct device_node *np, > * to determine if the flags should have inverted semantics. > */ > if (IS_ENABLED(CONFIG_SPI_MASTER) && !strcmp(propname, "cs-gpios") && > - of_property_read_bool(np, "cs-gpios")) { > + of_property_present(np, "cs-gpios")) { > u32 cs; > int ret; > >
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Mon, 04 Nov 2024 13:06:27 -0600, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Applied, thanks! [1/1] gpio: Use of_property_present() for non-boolean properties commit: c6789170ddef58d28cfbc3342933713ce1e2c860 Best regards,
diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 365ab947983c..64924bc01591 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -602,7 +602,7 @@ static int rockchip_gpiolib_register(struct rockchip_pin_bank *bank) * files which don't set the "gpio-ranges" property or systems that * utilize ACPI the driver has to call gpiochip_add_pin_range(). */ - if (!of_property_read_bool(bank->of_node, "gpio-ranges")) { + if (!of_property_present(bank->of_node, "gpio-ranges")) { struct device_node *pctlnp = of_get_parent(bank->of_node); struct pinctrl_dev *pctldev = NULL; diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index 880f1efcaca5..2e537ee979f3 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -337,7 +337,7 @@ static void of_gpio_flags_quirks(const struct device_node *np, * to determine if the flags should have inverted semantics. */ if (IS_ENABLED(CONFIG_SPI_MASTER) && !strcmp(propname, "cs-gpios") && - of_property_read_bool(np, "cs-gpios")) { + of_property_present(np, "cs-gpios")) { u32 cs; int ret;
The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/gpio/gpio-rockchip.c | 2 +- drivers/gpio/gpiolib-of.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)