| Message ID | 20241029084615.91049-1-xuanzhuo@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | virtio_net: enable premapped mode by default | expand |
On Tue, 29 Oct 2024 16:46:11 +0800 Xuan Zhuo wrote: > In the last linux version, we disabled this feature to fix the > regress[1]. > > The patch set is try to fix the problem and re-enable it. > > More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com Sorry to ping, Michael, Jason we're waiting to hear from you on this one.
Hi Jakub: On Tue, Nov 5, 2024 at 10:46 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 29 Oct 2024 16:46:11 +0800 Xuan Zhuo wrote: > > In the last linux version, we disabled this feature to fix the > > regress[1]. > > > > The patch set is try to fix the problem and re-enable it. > > > > More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com > > Sorry to ping, Michael, Jason we're waiting to hear from you on > this one. > Will review this today. Thanks
Hello: This series was applied to netdev/net-next.git (main) by Paolo Abeni <pabeni@redhat.com>: On Tue, 29 Oct 2024 16:46:11 +0800 you wrote: > v1: > 1. fix some small problems > 2. remove commit "virtio_net: introduce vi->mode" > > In the last linux version, we disabled this feature to fix the > regress[1]. > > [...] Here is the summary with links: - [net-next,v1,1/4] virtio-net: fix overflow inside virtnet_rq_alloc https://git.kernel.org/netdev/net-next/c/6aacd1484468 - [net-next,v1,2/4] virtio_net: big mode skip the unmap check https://git.kernel.org/netdev/net-next/c/a33f3df85075 - [net-next,v1,3/4] virtio_net: enable premapped mode for merge and small by default https://git.kernel.org/netdev/net-next/c/47008bb51c3e - [net-next,v1,4/4] virtio_net: rx remove premapped failover code https://git.kernel.org/netdev/net-next/c/fb22437c1ba3 You are awesome, thank you!
On Mon, Nov 04, 2024 at 06:46:41PM -0800, Jakub Kicinski wrote: > On Tue, 29 Oct 2024 16:46:11 +0800 Xuan Zhuo wrote: > > In the last linux version, we disabled this feature to fix the > > regress[1]. > > > > The patch set is try to fix the problem and re-enable it. > > > > More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com > > Sorry to ping, Michael, Jason we're waiting to hear from you on > this one. Can patch 1 be applied on net as well? Or I can take it through my tree. It's a bugfix, just for an uncommon configuration.
On Wed, 6 Nov 2024 02:38:40 -0500, "Michael S. Tsirkin" <mst@redhat.com> wrote: > On Mon, Nov 04, 2024 at 06:46:41PM -0800, Jakub Kicinski wrote: > > On Tue, 29 Oct 2024 16:46:11 +0800 Xuan Zhuo wrote: > > > In the last linux version, we disabled this feature to fix the > > > regress[1]. > > > > > > The patch set is try to fix the problem and re-enable it. > > > > > > More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com > > > > Sorry to ping, Michael, Jason we're waiting to hear from you on > > this one. > > Can patch 1 be applied on net as well? Or I can take it through > my tree. It's a bugfix, just for an uncommon configuration. Why? That can not be triggered in net branch. Thanks
On Wed, Nov 06, 2024 at 04:46:23PM +0800, Xuan Zhuo wrote: > On Wed, 6 Nov 2024 02:38:40 -0500, "Michael S. Tsirkin" <mst@redhat.com> wrote: > > On Mon, Nov 04, 2024 at 06:46:41PM -0800, Jakub Kicinski wrote: > > > On Tue, 29 Oct 2024 16:46:11 +0800 Xuan Zhuo wrote: > > > > In the last linux version, we disabled this feature to fix the > > > > regress[1]. > > > > > > > > The patch set is try to fix the problem and re-enable it. > > > > > > > > More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com > > > > > > Sorry to ping, Michael, Jason we're waiting to hear from you on > > > this one. > > > > Can patch 1 be applied on net as well? Or I can take it through > > my tree. It's a bugfix, just for an uncommon configuration. > > > Why? That can not be triggered in net branch. > > Thanks I thought it can but can't remember why now. OK, nm then, thanks!
On Wed, 6 Nov 2024 04:16:07 -0500 Michael S. Tsirkin wrote:
> I thought it can but can't remember why now. OK, nm then, thanks!
FWIW (I think there was confusion in earlier discussions) we do merge
net into net-next once a week. So we can always apply stuff to net,
and then depending patches to net-next within a week. Just for future
reference, this patch IIUC we just leave be.
v1: 1. fix some small problems 2. remove commit "virtio_net: introduce vi->mode" In the last linux version, we disabled this feature to fix the regress[1]. The patch set is try to fix the problem and re-enable it. More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com Thanks. [1]: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com Xuan Zhuo (4): virtio-net: fix overflow inside virtnet_rq_alloc virtio_net: big mode skip the unmap check virtio_net: enable premapped mode for merge and small by default virtio_net: rx remove premapped failover code drivers/net/virtio_net.c | 113 +++++++++++++++++++++++---------------- 1 file changed, 66 insertions(+), 47 deletions(-) -- 2.32.0.3.g01195cf9f