| Message ID | 20241105174403.850330-3-edumazet@google.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | cfe8394e06f22847ecae0312bdd0b633b471b3f0 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: add debug checks to skb_reset_xxx_header() | expand |
On Tue, Nov 05, 2024 at 05:43:58PM +0000, Eric Dumazet wrote: > Make sure (skb->data - skb->head) can fit in skb->inner_transport_header > > This needs CONFIG_DEBUG_NET=y. > > Signed-off-by: Eric Dumazet <edumazet@google.com> > --- > include/linux/skbuff.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Joe Damato <jdamato@fastly.com>
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index 5d8fefa71cac78d83b9565d9038c319112da1e2d..75795568803c0bfc83652ea69e27521eeeaf5d40 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -2937,7 +2937,10 @@ static inline int skb_inner_transport_offset(const struct sk_buff *skb) static inline void skb_reset_inner_transport_header(struct sk_buff *skb) { - skb->inner_transport_header = skb->data - skb->head; + long offset = skb->data - skb->head; + + DEBUG_NET_WARN_ON_ONCE(offset != (typeof(skb->inner_transport_header))offset); + skb->inner_transport_header = offset; } static inline void skb_set_inner_transport_header(struct sk_buff *skb,
Make sure (skb->data - skb->head) can fit in skb->inner_transport_header This needs CONFIG_DEBUG_NET=y. Signed-off-by: Eric Dumazet <edumazet@google.com> --- include/linux/skbuff.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)