mbox series

[net-next,v2,0/9] Support external snapshots on dwmac1000

Message ID 20241104170251.2202270-1-maxime.chevallier@bootlin.com (mailing list archive)
Headers show
Series Support external snapshots on dwmac1000 | expand

Message

Maxime Chevallier Nov. 4, 2024, 5:02 p.m. UTC 
Hi,

This series is another take on the pervious work [1] done by
Alexis Lothoré, that fixes the support for external snapshots
timestamping in GMAC3-based devices.

Details on why this is needed are mentionned on the cover [2] from V1.

This V2 addresses multiple issues found in V1 :

 - The PTP_TCR register is configured from multiple places, as reported
   by Alexis, so we need to make sure that the extts configuration
   doesn't interfere with the hwtstamp configuration.

 - The interrupt management in V1 was incomplete, as the interrupt
   wasn't correctly acked.

 - This series also makes so that we only enable the extts interrupt
   when necessary.

[1]: https://lore.kernel.org/netdev/20230616100409.164583-1-alexis.lothore@bootlin.com/
[2]: https://lore.kernel.org/netdev/20241029115419.1160201-1-maxime.chevallier@bootlin.com/

Thanks Alexis for laying the groundwork for this,

Best regards,

Maxime

Link to V1: https://lore.kernel.org/netdev/20241029115419.1160201-1-maxime.chevallier@bootlin.com/

Maxime Chevallier (9):
  net: stmmac: Don't modify the global ptp ops directly
  net: stmmac: Use per-hw ptp clock ops
  net: stmmac: Only update the auto-discovered PTP clock features
  net: stmmac: Introduce dwmac1000 ptp_clock_info and operations
  net: stmmac: Introduce dwmac1000 timestamping operations
  net: stmmac: Enable timestamping interrupt on dwmac1000
  net: stmmac: Don't include dwmac4 definitions in stmmac_ptp
  net: stmmac: Configure only the relevant bits for timestamping setup
  net: stmmac: dwmac_socfpga: This platform has GMAC

 drivers/net/ethernet/stmicro/stmmac/common.h  |   4 +
 .../ethernet/stmicro/stmmac/dwmac-socfpga.c   |   1 +
 .../net/ethernet/stmicro/stmmac/dwmac1000.h   |  12 +++
 .../ethernet/stmicro/stmmac/dwmac1000_core.c  | 101 ++++++++++++++++++
 drivers/net/ethernet/stmicro/stmmac/hwif.c    |  15 ++-
 .../ethernet/stmicro/stmmac/stmmac_hwtstamp.c |  26 ++++-
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.c  |  38 +++++--
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.h  |  10 ++
 8 files changed, 196 insertions(+), 11 deletions(-)

Comments

Jakub Kicinski Nov. 6, 2024, 2:20 a.m. UTC | #1 
On Mon,  4 Nov 2024 18:02:40 +0100 Maxime Chevallier wrote:
>   net: stmmac: Only update the auto-discovered PTP clock features

Minor conflict in the context on this one, please respin.
Maxime Chevallier Nov. 6, 2024, 9 a.m. UTC | #2 
On Tue, 5 Nov 2024 18:20:50 -0800
Jakub Kicinski <kuba@kernel.org> wrote:

> On Mon,  4 Nov 2024 18:02:40 +0100 Maxime Chevallier wrote:
> >   net: stmmac: Only update the auto-discovered PTP clock features  
> 
> Minor conflict in the context on this one, please respin.

Sure thing, I'll respin right away.

Thanks,

Maxime