| Message ID | 20241104085706.13872-1-lulie@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | virtio_net: Make RSS interact properly with queue number | expand |
Hi Jason, could you review this firstly? Thanks. On Mon, 4 Nov 2024 16:57:02 +0800, Philo Lu <lulie@linux.alibaba.com> wrote: > With this patch set, RSS updates with queue_pairs changing: > - When virtnet_probe, init default rss and commit > - When queue_pairs changes _without_ user rss configuration, update rss > with the new queue number > - When queue_pairs changes _with_ user rss configuration, keep rss as user > configured > > Patch 1 and 2 fix possible out of bound errors for indir_table and key. > Patch 3 and 4 add RSS update in probe() and set_queues(). > > Please review, thanks. > > Philo Lu (4): > virtio_net: Support dynamic rss indirection table size > virtio_net: Add hash_key_length check > virtio_net: Sync rss config to device when virtnet_probe > virtio_net: Update rss when set queue > > drivers/net/virtio_net.c | 119 ++++++++++++++++++++++++++++++++------- > 1 file changed, 100 insertions(+), 19 deletions(-) > > -- > 2.32.0.3.g01195cf9f >
On Mon, Nov 04, 2024 at 04:57:02PM +0800, Philo Lu wrote: > With this patch set, RSS updates with queue_pairs changing: > - When virtnet_probe, init default rss and commit > - When queue_pairs changes _without_ user rss configuration, update rss > with the new queue number > - When queue_pairs changes _with_ user rss configuration, keep rss as user > configured > > Patch 1 and 2 fix possible out of bound errors for indir_table and key. > Patch 3 and 4 add RSS update in probe() and set_queues(). > > Please review, thanks. Looks reasonable. Acked-by: Michael S. Tsirkin <mst@redhat.com> > Philo Lu (4): > virtio_net: Support dynamic rss indirection table size > virtio_net: Add hash_key_length check > virtio_net: Sync rss config to device when virtnet_probe > virtio_net: Update rss when set queue > > drivers/net/virtio_net.c | 119 ++++++++++++++++++++++++++++++++------- > 1 file changed, 100 insertions(+), 19 deletions(-) > > -- > 2.32.0.3.g01195cf9f
Hello: This series was applied to netdev/net.git (main) by Paolo Abeni <pabeni@redhat.com>: On Mon, 4 Nov 2024 16:57:02 +0800 you wrote: > With this patch set, RSS updates with queue_pairs changing: > - When virtnet_probe, init default rss and commit > - When queue_pairs changes _without_ user rss configuration, update rss > with the new queue number > - When queue_pairs changes _with_ user rss configuration, keep rss as user > configured > > [...] Here is the summary with links: - [net,1/4] virtio_net: Support dynamic rss indirection table size https://git.kernel.org/netdev/net/c/86a48a00efdf - [net,2/4] virtio_net: Add hash_key_length check https://git.kernel.org/netdev/net/c/3f7d9c1964fc - [net,3/4] virtio_net: Sync rss config to device when virtnet_probe https://git.kernel.org/netdev/net/c/dc749b7b0608 - [net,4/4] virtio_net: Update rss when set queue https://git.kernel.org/netdev/net/c/50bfcaedd78e You are awesome, thank you!
On Wed, Nov 6, 2024 at 5:00 PM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote: > > Hi Jason, could you review this firstly? > > Thanks. > It looks like the series has been merged. Anyhow it looks good to me. Thanks