| Message ID | 20241106-qcs8300-mm-patches-v3-3-f611a8f87f15@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for GPUCC, CAMCC and VIDEOCC on Qualcomm QCS8300 platform | expand |
On Wed, Nov 06, 2024 at 03:21:58PM +0530, Imran Shaik wrote: + > +#include "qcom,sa8775p-camcc.h" > + > +/* QCS8300 introduces below new clocks compared to SA8775P */ > + > +/* CAM_CC clocks */ > +#define CAM_CC_TITAN_TOP_ACCU_SHIFT_CLK 86 I really wonder what you are going to do when sa8775p grows by one clock and will get ID of 86 :) (and before you say sa8775p will use 87, let me just clarify it will have to get 86 because no gaps would be accepted in existing header) But that's not my problem: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 11/6/24 11:51, Imran Shaik wrote: > The QCS8300 camera clock controller is mostly identical to SA8775P, but > QCS8300 has one additional clock and minor differences. Hence, reuse the > SA8775P camera bindings and add additional clock required for QCS8300. > > Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com> > --- > .../devicetree/bindings/clock/qcom,sa8775p-camcc.yaml | 6 +++++- > include/dt-bindings/clock/qcom,qcs8300-camcc.h | 16 ++++++++++++++++ > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml > index 36a60d8f5ae3..81623f59d11d 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml > @@ -8,16 +8,20 @@ title: Qualcomm Camera Clock & Reset Controller on SA8775P > > maintainers: > - Taniya Das <quic_tdas@quicinc.com> > + - Imran Shaik <quic_imrashai@quicinc.com> > > description: | > Qualcomm camera clock control module provides the clocks, resets and power > domains on SA8775p. > > - See also: include/dt-bindings/clock/qcom,sa8775p-camcc.h > + See also: > + include/dt-bindings/clock/qcom,qcs8300-camcc.h > + include/dt-bindings/clock/qcom,sa8775p-camcc.h > > properties: > compatible: > enum: > + - qcom,qcs8300-camcc > - qcom,sa8775p-camcc > > clocks: > diff --git a/include/dt-bindings/clock/qcom,qcs8300-camcc.h b/include/dt-bindings/clock/qcom,qcs8300-camcc.h > new file mode 100644 > index 000000000000..fc535c847859 > --- /dev/null > +++ b/include/dt-bindings/clock/qcom,qcs8300-camcc.h > @@ -0,0 +1,16 @@ > +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ > +/* > + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#ifndef _DT_BINDINGS_CLK_QCOM_QCS8300_CAM_CC_H > +#define _DT_BINDINGS_CLK_QCOM_QCS8300_CAM_CC_H > + > +#include "qcom,sa8775p-camcc.h" > + > +/* QCS8300 introduces below new clocks compared to SA8775P */ > + > +/* CAM_CC clocks */ > +#define CAM_CC_TITAN_TOP_ACCU_SHIFT_CLK 86 > + > +#endif > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir
diff --git a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml index 36a60d8f5ae3..81623f59d11d 100644 --- a/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml +++ b/Documentation/devicetree/bindings/clock/qcom,sa8775p-camcc.yaml @@ -8,16 +8,20 @@ title: Qualcomm Camera Clock & Reset Controller on SA8775P maintainers: - Taniya Das <quic_tdas@quicinc.com> + - Imran Shaik <quic_imrashai@quicinc.com> description: | Qualcomm camera clock control module provides the clocks, resets and power domains on SA8775p. - See also: include/dt-bindings/clock/qcom,sa8775p-camcc.h + See also: + include/dt-bindings/clock/qcom,qcs8300-camcc.h + include/dt-bindings/clock/qcom,sa8775p-camcc.h properties: compatible: enum: + - qcom,qcs8300-camcc - qcom,sa8775p-camcc clocks: diff --git a/include/dt-bindings/clock/qcom,qcs8300-camcc.h b/include/dt-bindings/clock/qcom,qcs8300-camcc.h new file mode 100644 index 000000000000..fc535c847859 --- /dev/null +++ b/include/dt-bindings/clock/qcom,qcs8300-camcc.h @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (c) 2024, Qualcomm Innovation Center, Inc. All rights reserved. + */ + +#ifndef _DT_BINDINGS_CLK_QCOM_QCS8300_CAM_CC_H +#define _DT_BINDINGS_CLK_QCOM_QCS8300_CAM_CC_H + +#include "qcom,sa8775p-camcc.h" + +/* QCS8300 introduces below new clocks compared to SA8775P */ + +/* CAM_CC clocks */ +#define CAM_CC_TITAN_TOP_ACCU_SHIFT_CLK 86 + +#endif
The QCS8300 camera clock controller is mostly identical to SA8775P, but QCS8300 has one additional clock and minor differences. Hence, reuse the SA8775P camera bindings and add additional clock required for QCS8300. Signed-off-by: Imran Shaik <quic_imrashai@quicinc.com> --- .../devicetree/bindings/clock/qcom,sa8775p-camcc.yaml | 6 +++++- include/dt-bindings/clock/qcom,qcs8300-camcc.h | 16 ++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-)