| Message ID | 20241023-en7581-pinctrl-v9-4-afb0cbcab0ec@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add mfd, pinctrl and pwm support to EN7581 SoC | expand |
On Wed, 23 Oct 2024 01:20:04 +0200, Lorenzo Bianconi wrote: > Add support for Airoha EN7581 GPIO System Controller which provide a > register map for controlling the GPIO, pinctrl and PWM of the SoC via > dedicated pinctrl and pwm child nodes. > > Applied, thanks! [4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller commit: f49f37f3cfe1482d4dc77d26f3e8c38eab630d52 -- Lee Jones [李琼斯]
On Nov 06, Lee Jones wrote: > On Wed, 23 Oct 2024 01:20:04 +0200, Lorenzo Bianconi wrote: > > Add support for Airoha EN7581 GPIO System Controller which provide a > > register map for controlling the GPIO, pinctrl and PWM of the SoC via > > dedicated pinctrl and pwm child nodes. > > > > > > Applied, thanks! > > [4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller > commit: f49f37f3cfe1482d4dc77d26f3e8c38eab630d52 > > -- > Lee Jones [李琼斯] > Hi Lee, according to my understanding this patch has been already applied by Linus here: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=devel&id=50dedb1eb1e6755ccab55f6140916c2d192be765 Regards, Lorenzo
On Wed, 06 Nov 2024, Lorenzo Bianconi wrote: > On Nov 06, Lee Jones wrote: > > On Wed, 23 Oct 2024 01:20:04 +0200, Lorenzo Bianconi wrote: > > > Add support for Airoha EN7581 GPIO System Controller which provide a > > > register map for controlling the GPIO, pinctrl and PWM of the SoC via > > > dedicated pinctrl and pwm child nodes. > > > > > > > > > > Applied, thanks! > > > > [4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller > > commit: f49f37f3cfe1482d4dc77d26f3e8c38eab630d52 > > > > -- > > Lee Jones [李琼斯] > > > > Hi Lee, > > according to my understanding this patch has been already applied by Linus > here: > > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=devel&id=50dedb1eb1e6755ccab55f6140916c2d192be765 An interesting choice. Linus?
On Nov 06, Lee Jones wrote: > On Wed, 06 Nov 2024, Lorenzo Bianconi wrote: > > > On Nov 06, Lee Jones wrote: > > > On Wed, 23 Oct 2024 01:20:04 +0200, Lorenzo Bianconi wrote: > > > > Add support for Airoha EN7581 GPIO System Controller which provide a > > > > register map for controlling the GPIO, pinctrl and PWM of the SoC via > > > > dedicated pinctrl and pwm child nodes. > > > > > > > > > > > > > > Applied, thanks! > > > > > > [4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller > > > commit: f49f37f3cfe1482d4dc77d26f3e8c38eab630d52 > > > > > > -- > > > Lee Jones [李琼斯] > > > > > > > Hi Lee, > > > > according to my understanding this patch has been already applied by Linus > > here: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=devel&id=50dedb1eb1e6755ccab55f6140916c2d192be765 > > An interesting choice. Linus? I guess Linus applied all binding patches to his tree since there is a dependency between airoha,en7581-pwm.yaml/airoha,en7581-pinctrl.yaml and airoha,en7581-gpio-sysctl.yaml. Regards, Lorenzo > > -- > Lee Jones [李琼斯]
On Wed, Nov 6, 2024 at 12:00 PM Lee Jones <lee@kernel.org> wrote: > On Wed, 06 Nov 2024, Lorenzo Bianconi wrote: > > > On Nov 06, Lee Jones wrote: > > > On Wed, 23 Oct 2024 01:20:04 +0200, Lorenzo Bianconi wrote: > > > > Add support for Airoha EN7581 GPIO System Controller which provide a > > > > register map for controlling the GPIO, pinctrl and PWM of the SoC via > > > > dedicated pinctrl and pwm child nodes. > > > > > > > > > > > > > > Applied, thanks! > > > > > > [4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller > > > commit: f49f37f3cfe1482d4dc77d26f3e8c38eab630d52 > > > > > > -- > > > Lee Jones [李琼斯] > > > > > > > Hi Lee, > > > > according to my understanding this patch has been already applied by Linus > > here: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=devel&id=50dedb1eb1e6755ccab55f6140916c2d192be765 > > An interesting choice. Linus? Yes I suggested that I merge patches 1-5 on oct 29 and applied the day after: https://lore.kernel.org/linux-gpio/CACRpkdYshPusdA7bDW2y8H_wp-Fm3N-YCsY1_Qn=dZqRiFy12w@mail.gmail.com/ It's because the bindings are dependent on each other, this one patch has: + pinctrl: + type: object + $ref: /schemas/pinctrl/airoha,en7581-pinctrl.yaml + description: + Child node definition for EN7581 Pin controller + + pwm: + type: object + $ref: /schemas/pwm/airoha,en7581-pwm.yaml + description: + Child node definition for EN7581 PWM controller Those refs will explode unless the two others are merged at the same time. Usually we merge the whole shebang through MFD but this one felt different because there is no actual MFD driver, just using simple-mfd. In hindsight I should probs not have been so trigger happy and give some more time for this to settle... Merge window stress I guess. :/ It's fine to apply textually identical patches to two trees though as git will sort that out so technically it's no big deal, you can keep it applied if you want. Yours, Linus Walleij
On Wed, 06 Nov 2024, Linus Walleij wrote: > On Wed, Nov 6, 2024 at 12:00 PM Lee Jones <lee@kernel.org> wrote: > > On Wed, 06 Nov 2024, Lorenzo Bianconi wrote: > > > > > On Nov 06, Lee Jones wrote: > > > > On Wed, 23 Oct 2024 01:20:04 +0200, Lorenzo Bianconi wrote: > > > > > Add support for Airoha EN7581 GPIO System Controller which provide a > > > > > register map for controlling the GPIO, pinctrl and PWM of the SoC via > > > > > dedicated pinctrl and pwm child nodes. > > > > > > > > > > > > > > > > > > Applied, thanks! > > > > > > > > [4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller > > > > commit: f49f37f3cfe1482d4dc77d26f3e8c38eab630d52 > > > > > > > > -- > > > > Lee Jones [李琼斯] > > > > > > > > > > Hi Lee, > > > > > > according to my understanding this patch has been already applied by Linus > > > here: > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=devel&id=50dedb1eb1e6755ccab55f6140916c2d192be765 > > > > An interesting choice. Linus? > > Yes I suggested that I merge patches 1-5 on oct 29 and applied the > day after: > https://lore.kernel.org/linux-gpio/CACRpkdYshPusdA7bDW2y8H_wp-Fm3N-YCsY1_Qn=dZqRiFy12w@mail.gmail.com/ > > It's because the bindings are dependent on each other, this one patch has: > > + pinctrl: > + type: object > + $ref: /schemas/pinctrl/airoha,en7581-pinctrl.yaml > + description: > + Child node definition for EN7581 Pin controller > + > + pwm: > + type: object > + $ref: /schemas/pwm/airoha,en7581-pwm.yaml > + description: > + Child node definition for EN7581 PWM controller > > Those refs will explode unless the two others are merged at the same > time. > > Usually we merge the whole shebang through MFD but this one felt > different because there is no actual MFD driver, just using simple-mfd. > > In hindsight I should probs not have been so trigger happy and give > some more time for this to settle... Merge window stress I guess. :/ > > It's fine to apply textually identical patches to two trees though as > git will sort > that out so technically it's no big deal, you can keep it applied if you > want. It's okay. Life will be easier for everyone if I remove it.
On Mon, 11 Nov 2024, Lee Jones wrote: > On Wed, 06 Nov 2024, Linus Walleij wrote: > > > On Wed, Nov 6, 2024 at 12:00 PM Lee Jones <lee@kernel.org> wrote: > > > On Wed, 06 Nov 2024, Lorenzo Bianconi wrote: > > > > > > > On Nov 06, Lee Jones wrote: > > > > > On Wed, 23 Oct 2024 01:20:04 +0200, Lorenzo Bianconi wrote: > > > > > > Add support for Airoha EN7581 GPIO System Controller which provide a > > > > > > register map for controlling the GPIO, pinctrl and PWM of the SoC via > > > > > > dedicated pinctrl and pwm child nodes. > > > > > > > > > > > > > > > > > > > > > > Applied, thanks! > > > > > > > > > > [4/6] dt-bindings: mfd: Add support for Airoha EN7581 GPIO System Controller > > > > > commit: f49f37f3cfe1482d4dc77d26f3e8c38eab630d52 > > > > > > > > > > -- > > > > > Lee Jones [李琼斯] > > > > > > > > > > > > > Hi Lee, > > > > > > > > according to my understanding this patch has been already applied by Linus > > > > here: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/commit/?h=devel&id=50dedb1eb1e6755ccab55f6140916c2d192be765 > > > > > > An interesting choice. Linus? > > > > Yes I suggested that I merge patches 1-5 on oct 29 and applied the > > day after: > > https://lore.kernel.org/linux-gpio/CACRpkdYshPusdA7bDW2y8H_wp-Fm3N-YCsY1_Qn=dZqRiFy12w@mail.gmail.com/ > > > > It's because the bindings are dependent on each other, this one patch has: > > > > + pinctrl: > > + type: object > > + $ref: /schemas/pinctrl/airoha,en7581-pinctrl.yaml > > + description: > > + Child node definition for EN7581 Pin controller > > + > > + pwm: > > + type: object > > + $ref: /schemas/pwm/airoha,en7581-pwm.yaml > > + description: > > + Child node definition for EN7581 PWM controller > > > > Those refs will explode unless the two others are merged at the same > > time. > > > > Usually we merge the whole shebang through MFD but this one felt > > different because there is no actual MFD driver, just using simple-mfd. > > > > In hindsight I should probs not have been so trigger happy and give > > some more time for this to settle... Merge window stress I guess. :/ > > > > It's fine to apply textually identical patches to two trees though as > > git will sort > > that out so technically it's no big deal, you can keep it applied if you > > want. > > It's okay. Life will be easier for everyone if I remove it. Okay, I dropped it from my tree. Next time I would like a say/opportunity to Ack please.
On Tue, Nov 12, 2024 at 3:44 PM Lee Jones <lee@kernel.org> wrote: > > It's okay. Life will be easier for everyone if I remove it. > > Okay, I dropped it from my tree. Thanks! > Next time I would like a say/opportunity to Ack please. Yeah I was a bit trigger happy, sorry man. Yours, Linus Walleij
diff --git a/Documentation/devicetree/bindings/mfd/airoha,en7581-gpio-sysctl.yaml b/Documentation/devicetree/bindings/mfd/airoha,en7581-gpio-sysctl.yaml new file mode 100644 index 0000000000000000000000000000000000000000..4a81ed82ef34dc2b99594098584cc77f67f276c8 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/airoha,en7581-gpio-sysctl.yaml @@ -0,0 +1,90 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/airoha,en7581-gpio-sysctl.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Airoha EN7581 GPIO System Controller + +maintainers: + - Christian Marangi <ansuelsmth@gmail.com> + - Lorenzo Bianconi <lorenzo@kernel.org> + +description: + Airoha EN7581 SoC GPIO system controller which provided a register map + for controlling the GPIO, pins and PWM of the SoC. + +properties: + compatible: + items: + - const: airoha,en7581-gpio-sysctl + - const: syscon + - const: simple-mfd + + reg: + maxItems: 1 + + pinctrl: + type: object + $ref: /schemas/pinctrl/airoha,en7581-pinctrl.yaml + description: + Child node definition for EN7581 Pin controller + + pwm: + type: object + $ref: /schemas/pwm/airoha,en7581-pwm.yaml + description: + Child node definition for EN7581 PWM controller + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + + system-controller@1fbf0200 { + compatible = "airoha,en7581-gpio-sysctl", "syscon", "simple-mfd"; + reg = <0x1fbf0200 0xc0>; + + pinctrl { + compatible = "airoha,en7581-pinctrl"; + + interrupt-parent = <&gic>; + interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>; + + gpio-controller; + #gpio-cells = <2>; + + interrupt-controller; + #interrupt-cells = <2>; + + mmc-pins { + mux { + function = "emmc"; + groups = "emmc"; + }; + }; + + mdio-pins { + mux { + function = "mdio"; + groups = "mdio"; + }; + + conf { + pins = "gpio2"; + output-enable; + }; + }; + }; + + pwm { + compatible = "airoha,en7581-pwm"; + + #pwm-cells = <3>; + }; + };