| Message ID | 20241103223408.26274-1-mohan.prasad@microchip.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9b2f6b94132d14b1d2d2a7d3b65bac4f3a056aac |
| Delegated to: | Michal Kubecek |
| Headers | show |
| Series | [ethtool,v2] netlink: settings: Fix for wrong auto-negotiation state | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
Hello: This patch was applied to ethtool/ethtool.git (master) by Michal Kubecek <mkubecek@suse.cz>: On Mon, 4 Nov 2024 04:04:07 +0530 you wrote: > Auto-negotiation state in json format showed the > opposite state due to wrong comparison. > Fix for returning the correct auto-neg state implemented. > > Signed-off-by: Mohan Prasad J <mohan.prasad@microchip.com> > --- > Changes in v2: > Used simpler comparison statement for checking > auto-negotiation. > Link to v1:https://patchwork.kernel.org/project/netdevbpf/patch/20241016035848.292603-1-mohan.prasad@microchip.com/ > > [...] Here is the summary with links: - [ethtool,v2] netlink: settings: Fix for wrong auto-negotiation state https://git.kernel.org/pub/scm/network/ethtool/ethtool.git/commit/?id=9b2f6b94132d You are awesome, thank you!
diff --git a/netlink/settings.c b/netlink/settings.c index dbfb520..b9b3ba9 100644 --- a/netlink/settings.c +++ b/netlink/settings.c @@ -546,7 +546,7 @@ int linkmodes_reply_cb(const struct nlmsghdr *nlhdr, void *data) (autoneg == AUTONEG_DISABLE) ? "off" : "on"); else print_bool(PRINT_JSON, "auto-negotiation", NULL, - autoneg == AUTONEG_DISABLE); + autoneg != AUTONEG_DISABLE); } if (tb[ETHTOOL_A_LINKMODES_MASTER_SLAVE_CFG]) { uint8_t val;
Auto-negotiation state in json format showed the opposite state due to wrong comparison. Fix for returning the correct auto-neg state implemented. Signed-off-by: Mohan Prasad J <mohan.prasad@microchip.com> --- Changes in v2: Used simpler comparison statement for checking auto-negotiation. Link to v1:https://patchwork.kernel.org/project/netdevbpf/patch/20241016035848.292603-1-mohan.prasad@microchip.com/ --- --- netlink/settings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)