mbox series

[mptcp-next,v3,0/9] BPF path manager, part 1

Message ID cover.1730961809.git.tanggeliang@kylinos.cn (mailing list archive)
Headers show
Series BPF path manager, part 1 | expand

Message

Geliang Tang Nov. 7, 2024, 6:45 a.m. UTC 
From: Geliang Tang <tanggeliang@kylinos.cn>

v3:
 - address Matt's comments in v2 (thanks)
 - only include cleanups and refactoring patches in this set.

v2:
 - add BPF-related code in this set (32-36).

In order to implement BPF userspace path manager, it is necessary to
unify the interfaces of the path manager. This set contains some
cleanups and refactoring to unify the interfaces in kernel space.
Finally, define a struct mptcp_pm_ops for a userspace path manager
like this:

struct mptcp_pm_ops {
        int (*address_announce)(struct mptcp_sock *msk,
                                struct mptcp_pm_addr_entry *local);
        int (*address_remove)(struct mptcp_sock *msk, u8 id);
        int (*subflow_create)(struct mptcp_sock *msk,
                              struct mptcp_pm_addr_entry *local,
                              struct mptcp_addr_info *remote);
        int (*subflow_destroy)(struct mptcp_sock *msk,
                               struct mptcp_pm_addr_entry *local,
                               struct mptcp_addr_info *remote);
        int (*get_local_id)(struct mptcp_sock *msk,
                            struct mptcp_pm_addr_entry *local);
        u8 (*get_flags)(struct mptcp_sock *msk,
                        struct mptcp_addr_info *skc);
        struct mptcp_pm_addr_entry *(*get_addr)(struct mptcp_sock *msk,
                                                u8 id);
	int (*dump_addr)(struct mptcp_sock *msk,
			 mptcp_pm_addr_id_bitmap_t *bitmap);
        int (*set_flags)(struct mptcp_sock *msk,
                         struct mptcp_pm_addr_entry *local,
                         struct mptcp_addr_info *remote);

        u8                      type;
        struct module           *owner;
        struct list_head        list;

        void (*init)(struct mptcp_sock *msk);
        void (*release)(struct mptcp_sock *msk);
} ____cacheline_aligned_in_smp;

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/74

Geliang Tang (9):
  mptcp: add mptcp_userspace_pm_lookup_addr helper
  mptcp: add mptcp_for_each_userspace_pm_addr macro
  mptcp: add mptcp_userspace_pm_get_sock helper
  mptcp: move mptcp_pm_remove_addrs into pm_userspace
  mptcp: drop free_list for deleting entries
  mptcp: use mptcp_pm_local in pm_netlink only
  mptcp: drop struct mptcp_pm_add_entry
  mptcp: change local addr type of subflow_destroy
  mptcp: drop useless "err = 0" in subflow_destroy

 net/mptcp/pm_netlink.c   |  97 +++++--------
 net/mptcp/pm_userspace.c | 306 +++++++++++++++++----------------------
 net/mptcp/protocol.h     |  35 +++--
 net/mptcp/subflow.c      |   2 +-
 4 files changed, 198 insertions(+), 242 deletions(-)

Comments

MPTCP CI Nov. 7, 2024, 7:56 a.m. UTC | #1 
Hi Geliang,

Thank you for your modifications, that's great!

Our CI did some validations and here is its report:

- KVM Validation: normal: Unstable: 1 failed test(s): selftest_mptcp_connect
Matthieu Baerts Dec. 4, 2024, 5:48 p.m. UTC | #2 
Hi Geliang,

On 07/11/2024 07:45, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v3:

Thank you for the v3. Sorry, I forgot about this series...

>  - address Matt's comments in v2 (thanks)

Please next time add a short individual changelog in each modified
patch: here I obviously forgot my previous comments, but even when the
review of the new version is done the day after, I don't think I would
remember all of them :)

>  - only include cleanups and refactoring patches in this set.

Good idea!

I had just a few small comments, but globally it looks good.

Cheers,
Matt