| Message ID | 20241107080248.2028680-1-cmeioahs@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add RDMA monitor support | expand |
On Thu, 7 Nov 2024 10:02:43 +0200 Chiara Meiohas <cmeioahs@nvidia.com> wrote: > From: Chiara Meiohas <cmeiohas@nvidia.com> > > This series adds support to a new command to monitor IB events > and expands the rdma-sys command to indicate whether this new > functionality is supported. > We've also included a fix for a typo in rdma-link man page. > > Command usage and examples are in the commits and man pages. > > These patches are complimentary to the kernel patches: > https://lore.kernel.org/linux-rdma/20240821051017.7730-1-michaelgur@nvidia.com/ > https://lore.kernel.org/linux-rdma/093c978ef2766fd3ab4ff8798eeb68f2f11582f6.1730367038.git.leon@kernel.org/ What happens if you run new iproute2 with these commands on an older kernel? What error is reported?
On 07/11/2024 18:24, Stephen Hemminger wrote: > On Thu, 7 Nov 2024 10:02:43 +0200 > Chiara Meiohas <cmeioahs@nvidia.com> wrote: > >> From: Chiara Meiohas <cmeiohas@nvidia.com> >> >> This series adds support to a new command to monitor IB events >> and expands the rdma-sys command to indicate whether this new >> functionality is supported. >> We've also included a fix for a typo in rdma-link man page. >> >> Command usage and examples are in the commits and man pages. >> >> These patches are complimentary to the kernel patches: >> https://lore.kernel.org/linux-rdma/20240821051017.7730-1-michaelgur@nvidia.com/ >> https://lore.kernel.org/linux-rdma/093c978ef2766fd3ab4ff8798eeb68f2f11582f6.1730367038.git.leon@kernel.org/ > What happens if you run new iproute2 with these commands > on an older kernel? What error is reported? If we run "rdma monitor" on a kernel which doesn't support it: it requires sudo privileges to run the command without failure, then it will hang waiting to receive events. The "rdma sys show" command will show "monitor off" as described in the commit message. Best regards, Chiara
From: Chiara Meiohas <cmeiohas@nvidia.com> This series adds support to a new command to monitor IB events and expands the rdma-sys command to indicate whether this new functionality is supported. We've also included a fix for a typo in rdma-link man page. Command usage and examples are in the commits and man pages. These patches are complimentary to the kernel patches: https://lore.kernel.org/linux-rdma/20240821051017.7730-1-michaelgur@nvidia.com/ https://lore.kernel.org/linux-rdma/093c978ef2766fd3ab4ff8798eeb68f2f11582f6.1730367038.git.leon@kernel.org/ -- v1->v2 - Print hex value if an unknown event is received - Add IB device and net device names in the output - Add IB device and net device rename events Chiara Meiohas (5): rdma: Add support for rdma monitor rdma: Expose whether RDMA monitoring is supported rdma: Fix typo in rdma-link man page rdma: update uapi headers rdma: Add IB device and net device rename events include/mnl_utils.h | 1 + lib/mnl_utils.c | 5 + man/man8/rdma-link.8 | 2 +- man/man8/rdma-monitor.8 | 51 ++++++++ man/man8/rdma-system.8 | 9 +- man/man8/rdma.8 | 7 +- rdma/Makefile | 3 +- rdma/include/uapi/rdma/rdma_netlink.h | 2 + rdma/monitor.c | 171 ++++++++++++++++++++++++++ rdma/rdma.c | 3 +- rdma/rdma.h | 1 + rdma/sys.c | 6 + rdma/utils.c | 2 + 13 files changed, 255 insertions(+), 8 deletions(-) create mode 100644 man/man8/rdma-monitor.8 create mode 100644 rdma/monitor.c