| Message ID | 20241031134719.2508841-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | [v2,1/1] cpufreq: loongson3: Check for error code from devm_mutex_init() call | expand |
On Thu, Oct 31, 2024 at 03:46:34PM +0200, Andy Shevchenko wrote: > Even if it's not critical, the avoidance of checking the error code > from devm_mutex_init() call today diminishes the point of using devm > variant of it. Tomorrow it may even leak something. Add the missed > check. Any comments? Can this be applied now for fixes, please?
On 08-11-24, 11:27, Andy Shevchenko wrote: > On Thu, Oct 31, 2024 at 03:46:34PM +0200, Andy Shevchenko wrote: > > Even if it's not critical, the avoidance of checking the error code > > from devm_mutex_init() call today diminishes the point of using devm > > variant of it. Tomorrow it may even leak something. Add the missed > > check. > > Any comments? Can this be applied now for fixes, please? Applied. Thanks.
diff --git a/drivers/cpufreq/loongson3_cpufreq.c b/drivers/cpufreq/loongson3_cpufreq.c index 61ebebf69455..bd34bf0fafa5 100644 --- a/drivers/cpufreq/loongson3_cpufreq.c +++ b/drivers/cpufreq/loongson3_cpufreq.c @@ -346,8 +346,11 @@ static int loongson3_cpufreq_probe(struct platform_device *pdev) { int i, ret; - for (i = 0; i < MAX_PACKAGES; i++) - devm_mutex_init(&pdev->dev, &cpufreq_mutex[i]); + for (i = 0; i < MAX_PACKAGES; i++) { + ret = devm_mutex_init(&pdev->dev, &cpufreq_mutex[i]); + if (ret) + return ret; + } ret = do_service_request(0, 0, CMD_GET_VERSION, 0, 0); if (ret <= 0)
Even if it's not critical, the avoidance of checking the error code from devm_mutex_init() call today diminishes the point of using devm variant of it. Tomorrow it may even leak something. Add the missed check. Fixes: ccf51454145b ("cpufreq: Add Loongson-3 CPUFreq driver support") Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- v2: renamed loongson --> loongson3 in the Subject (Huacai) drivers/cpufreq/loongson3_cpufreq.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)