| Message ID | 20241107125209.1736277-2-michael.nemanov@ti.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | wifi: cc33xx: Add driver for new TI CC33xx wireless device family | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Thu, Nov 07, 2024 at 02:51:53PM +0200, Michael Nemanov wrote: > Add device-tree bindings for the CC33xx family. > > Signed-off-by: Michael Nemanov <michael.nemanov@ti.com> > --- > .../bindings/net/wireless/ti,cc33xx.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml > <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof
On 07/11/2024 13:51, Michael Nemanov wrote: > Add device-tree bindings for the CC33xx family. > > Signed-off-by: Michael Nemanov <michael.nemanov@ti.com> > --- > .../bindings/net/wireless/ti,cc33xx.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml > > diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml > new file mode 100644 > index 000000000000..fd6e1ee8426e > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/wireless/ti,cc33xx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Texas Instruments CC33xx Wireless LAN Controller > + > +maintainers: > + - Michael Nemanov <michael.nemanov@ti.com> > + > +description: > + The CC33xx is a family of IEEE 802.11ax chips from Texas Instruments. > + These chips must be connected via SDIO and support in-band / out-of-band IRQ. > + > +properties: > + $nodename: > + pattern: "^wifi@2" As I asked, drop. Best regards, Krzysztof
On 11/8/2024 2:02 PM, Krzysztof Kozlowski wrote: > On Thu, Nov 07, 2024 at 02:51:53PM +0200, Michael Nemanov wrote: >> Add device-tree bindings for the CC33xx family. >> >> Signed-off-by: Michael Nemanov <michael.nemanov@ti.com> >> --- >> .../bindings/net/wireless/ti,cc33xx.yaml | 59 +++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml >> > > <form letter> > This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > Thank you. > </form letter> > > Best regards, > Krzysztof > Are you referring to > diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml ... > + > +properties: > + $nodename: > + pattern: "^wifi@2" ? If so, I replied here https://lore.kernel.org/linux-wireless/8024aa1c-5bd1-40d8-b0c3-14b5fcd992e2@ti.com/#t But if you don't think it's worthwhile I'll remove it. Regards, Michael.
On 12/11/2024 07:45, Nemanov, Michael wrote: > On 11/8/2024 2:02 PM, Krzysztof Kozlowski wrote: >> On Thu, Nov 07, 2024 at 02:51:53PM +0200, Michael Nemanov wrote: >>> Add device-tree bindings for the CC33xx family. >>> >>> Signed-off-by: Michael Nemanov <michael.nemanov@ti.com> >>> --- >>> .../bindings/net/wireless/ti,cc33xx.yaml | 59 +++++++++++++++++++ >>> 1 file changed, 59 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml >>> >> >> <form letter> >> This is a friendly reminder during the review process. >> >> It seems my or other reviewer's previous comments were not fully >> addressed. Maybe the feedback got lost between the quotes, maybe you >> just forgot to apply it. Please go back to the previous discussion and >> either implement all requested changes or keep discussing them. >> >> Thank you. >> </form letter> >> >> Best regards, >> Krzysztof >> > > Are you referring to > >> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml > > ... > >> + >> +properties: >> + $nodename: >> + pattern: "^wifi@2" > > ? > > If so, I replied here > https://lore.kernel.org/linux-wireless/8024aa1c-5bd1-40d8-b0c3-14b5fcd992e2@ti.com/#t > But if you don't think it's worthwhile I'll remove it. I asked you to remove it. It's not correct, not needed, not beneficial at all. It is actually harmful because limits re-use. dtc already checks this. Best regards, Krzysztof
On 11/19/2024 11:15 AM, Krzysztof Kozlowski wrote: > On 12/11/2024 07:45, Nemanov, Michael wrote: >> On 11/8/2024 2:02 PM, Krzysztof Kozlowski wrote: >>> On Thu, Nov 07, 2024 at 02:51:53PM +0200, Michael Nemanov wrote: >>>> Add device-tree bindings for the CC33xx family. >>>> >>>> Signed-off-by: Michael Nemanov <michael.nemanov@ti.com> >>>> --- >>>> .../bindings/net/wireless/ti,cc33xx.yaml | 59 +++++++++++++++++++ >>>> 1 file changed, 59 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml >>>> >>> >>> <form letter> >>> This is a friendly reminder during the review process. >>> >>> It seems my or other reviewer's previous comments were not fully >>> addressed. Maybe the feedback got lost between the quotes, maybe you >>> just forgot to apply it. Please go back to the previous discussion and >>> either implement all requested changes or keep discussing them. >>> >>> Thank you. >>> </form letter> >>> >>> Best regards, >>> Krzysztof >>> >> >> Are you referring to >> >>> diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml >> >> ... >> >>> + >>> +properties: >>> + $nodename: >>> + pattern: "^wifi@2" >> >> ? >> >> If so, I replied here >> https://lore.kernel.org/linux-wireless/8024aa1c-5bd1-40d8-b0c3-14b5fcd992e2@ti.com/#t >> But if you don't think it's worthwhile I'll remove it. > > I asked you to remove it. It's not correct, not needed, not beneficial > at all. It is actually harmful because limits re-use. dtc already checks > this. > > Best regards, > Krzysztof > OK, I'll remove it in the next iteration. Regards, Michael.
diff --git a/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml new file mode 100644 index 000000000000..fd6e1ee8426e --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/wireless/ti,cc33xx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Texas Instruments CC33xx Wireless LAN Controller + +maintainers: + - Michael Nemanov <michael.nemanov@ti.com> + +description: + The CC33xx is a family of IEEE 802.11ax chips from Texas Instruments. + These chips must be connected via SDIO and support in-band / out-of-band IRQ. + +properties: + $nodename: + pattern: "^wifi@2" + + compatible: + oneOf: + - const: ti,cc3300 + - items: + - enum: + - ti,cc3301 + - ti,cc3350 + - ti,cc3351 + - const: ti,cc3300 + + reg: + const: 2 + + interrupts: + description: + The out-of-band interrupt line. + Can be IRQ_TYPE_EDGE_RISING or IRQ_TYPE_LEVEL_HIGH. + If property is omitted, SDIO in-band IRQ will be used. + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + mmc { + #address-cells = <1>; + #size-cells = <0>; + + wifi@2 { + compatible = "ti,cc3300"; + reg = <2>; + interrupts = <19 IRQ_TYPE_EDGE_RISING>; + }; + };
Add device-tree bindings for the CC33xx family. Signed-off-by: Michael Nemanov <michael.nemanov@ti.com> --- .../bindings/net/wireless/ti,cc33xx.yaml | 59 +++++++++++++++++++ 1 file changed, 59 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/ti,cc33xx.yaml