diff mbox series

[net,v2] arm: dts: socfpga: use reset-name "stmmaceth-ocp" instead of "ahb"

Message ID 20241028145907.1698960-1-mamta.shukla@leica-geosystems.com (mailing list archive)
State Not Applicable
Delegated to: Netdev Maintainers
Headers show
Series [net,v2] arm: dts: socfpga: use reset-name "stmmaceth-ocp" instead of "ahb" | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag present in non-next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers fail 4 maintainers not CCed: krzk+dt@kernel.org conor+dt@kernel.org robh@kernel.org devicetree@vger.kernel.org
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes fail Problems with Fixes tag: 1
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch warning WARNING: 'Link:' should be followed by a public http(s) link WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: 331085a423b2 ("arm64: dts: socfpga: change the reset-name of "stmmaceth-ocp" to "ahb"")'
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-29--03-00 (tests: 777)

Commit Message

Mamta Shukla Oct. 28, 2024, 2:59 p.m. UTC 
The ahb reset is deasserted in probe before first register access, while the
stmmacheth-ocp reset needs to be asserted every time before changing the phy
mode in Arria10[1].

Changed in Upstream to "ahb"(331085a423b  arm64: dts: socfpga: change the
reset-name of "stmmaceth-ocp" to "ahb" ).This change was intended for arm64
socfpga and it is not applicable to Arria10.

Further with STMMAC-SELFTEST Driver enabled, ethtool test also FAILS.
$ ethtool -t eth0
[  322.946709] socfpga-dwmac ff800000.ethernet eth0: entered promiscuous mode
[  323.374558] socfpga-dwmac ff800000.ethernet eth0: left promiscuous mode
The test result is FAIL
The test extra info:
 1. MAC Loopback                 0
 2. PHY Loopback                 -110
 3. MMC Counters                 -110
 4. EEE                          -95
 5. Hash Filter MC               0
 6. Perfect Filter UC            -110
 7. MC Filter                    -110
 8. UC Filter                    0
 9. Flow Control                 -110
10. RSS                          -95
11. VLAN Filtering               -95
12. VLAN Filtering (perf)        -95
13. Double VLAN Filter           -95
14. Double VLAN Filter (perf)    -95
15. Flexible RX Parser           -95
16. SA Insertion (desc)          -95
17. SA Replacement (desc)        -95
18. SA Insertion (reg)           -95
19. SA Replacement (reg)         -95
20. VLAN TX Insertion            -95
21. SVLAN TX Insertion           -95
22. L3 DA Filtering              -95
23. L3 SA Filtering              -95
24. L4 DA TCP Filtering          -95
25. L4 SA TCP Filtering          -95
26. L4 DA UDP Filtering          -95
27. L4 SA UDP Filtering          -95
28. ARP Offload                  -95
29. Jumbo Frame                  -110
30. Multichannel Jumbo           -95
31. Split Header                 -95
32. TBS (ETF Scheduler)          -95

[  324.881327] socfpga-dwmac ff800000.ethernet eth0: Link is Down
[  327.995360] socfpga-dwmac ff800000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx

Link:[1] https://www.intel.com/content/www/us/en/docs/programmable/683711/21-2/functional-description-of-the-emac.html
Fixes: 331085a423b ("arm64: dts: socfpga: change the reset-name of "stmmaceth-ocp" to "ahb")
Signed-off-by: Mamta Shukla <mamta.shukla@leica-geosystems.com>
Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Changes in v2:
- Fix subject prefix
- Reword commit message.

 arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Dinh Nguyen Nov. 8, 2024, 1:11 p.m. UTC | #1 
On 10/28/24 09:59, Mamta Shukla wrote:
> The ahb reset is deasserted in probe before first register access, while the
> stmmacheth-ocp reset needs to be asserted every time before changing the phy
> mode in Arria10[1].
> 
> Changed in Upstream to "ahb"(331085a423b  arm64: dts: socfpga: change the
> reset-name of "stmmaceth-ocp" to "ahb" ).This change was intended for arm64
> socfpga and it is not applicable to Arria10.
> 
> Further with STMMAC-SELFTEST Driver enabled, ethtool test also FAILS.
> $ ethtool -t eth0
> [  322.946709] socfpga-dwmac ff800000.ethernet eth0: entered promiscuous mode
> [  323.374558] socfpga-dwmac ff800000.ethernet eth0: left promiscuous mode
> The test result is FAIL
> The test extra info:
>   1. MAC Loopback                 0
>   2. PHY Loopback                 -110
>   3. MMC Counters                 -110
>   4. EEE                          -95
>   5. Hash Filter MC               0
>   6. Perfect Filter UC            -110
>   7. MC Filter                    -110
>   8. UC Filter                    0
>   9. Flow Control                 -110
> 10. RSS                          -95
> 11. VLAN Filtering               -95
> 12. VLAN Filtering (perf)        -95
> 13. Double VLAN Filter           -95
> 14. Double VLAN Filter (perf)    -95
> 15. Flexible RX Parser           -95
> 16. SA Insertion (desc)          -95
> 17. SA Replacement (desc)        -95
> 18. SA Insertion (reg)           -95
> 19. SA Replacement (reg)         -95
> 20. VLAN TX Insertion            -95
> 21. SVLAN TX Insertion           -95
> 22. L3 DA Filtering              -95
> 23. L3 SA Filtering              -95
> 24. L4 DA TCP Filtering          -95
> 25. L4 SA TCP Filtering          -95
> 26. L4 DA UDP Filtering          -95
> 27. L4 SA UDP Filtering          -95
> 28. ARP Offload                  -95
> 29. Jumbo Frame                  -110
> 30. Multichannel Jumbo           -95
> 31. Split Header                 -95
> 32. TBS (ETF Scheduler)          -95
> 
> [  324.881327] socfpga-dwmac ff800000.ethernet eth0: Link is Down
> [  327.995360] socfpga-dwmac ff800000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx
> 
> Link:[1] https://www.intel.com/content/www/us/en/docs/programmable/683711/21-2/functional-description-of-the-emac.html
> Fixes: 331085a423b ("arm64: dts: socfpga: change the reset-name of "stmmaceth-ocp" to "ahb")
> Signed-off-by: Mamta Shukla <mamta.shukla@leica-geosystems.com>
> Tested-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>

Applied, thanks!

Dinh
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
index f36063c57c7f..72c55e5187ca 100644
--- a/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
+++ b/arch/arm/boot/dts/intel/socfpga/socfpga_arria10.dtsi
@@ -440,7 +440,7 @@  gmac0: ethernet@ff800000 {
 			clocks = <&l4_mp_clk>, <&peri_emac_ptp_clk>;
 			clock-names = "stmmaceth", "ptp_ref";
 			resets = <&rst EMAC0_RESET>, <&rst EMAC0_OCP_RESET>;
-			reset-names = "stmmaceth", "ahb";
+			reset-names = "stmmaceth", "stmmaceth-ocp";
 			snps,axi-config = <&socfpga_axi_setup>;
 			status = "disabled";
 		};
@@ -460,7 +460,7 @@  gmac1: ethernet@ff802000 {
 			clocks = <&l4_mp_clk>, <&peri_emac_ptp_clk>;
 			clock-names = "stmmaceth", "ptp_ref";
 			resets = <&rst EMAC1_RESET>, <&rst EMAC1_OCP_RESET>;
-			reset-names = "stmmaceth", "ahb";
+			reset-names = "stmmaceth", "stmmaceth-ocp";
 			snps,axi-config = <&socfpga_axi_setup>;
 			status = "disabled";
 		};
@@ -480,7 +480,7 @@  gmac2: ethernet@ff804000 {
 			clocks = <&l4_mp_clk>, <&peri_emac_ptp_clk>;
 			clock-names = "stmmaceth", "ptp_ref";
 			resets = <&rst EMAC2_RESET>, <&rst EMAC2_OCP_RESET>;
-			reset-names = "stmmaceth", "ahb";
+			reset-names = "stmmaceth", "stmmaceth-ocp";
 			snps,axi-config = <&socfpga_axi_setup>;
 			status = "disabled";
 		};