| Message ID | 20241108145024.1490536-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] media: ov7251: Remap "reset" to "enable" for OV7251 | expand |
Hi, On 8-Nov-24 3:50 PM, Andy Shevchenko wrote: > The driver of OmniVision OV7251 expects "enable" pin instead of "reset". > Remap "reset" to "enable" and update polarity. > > In particular, the Linux kernel can't load the camera sensor > driver on Microsoft Surface Book without this change: > > ov7251 i2c-INT347E:00: supply vdddo not found, using dummy regulator > ov7251 i2c-INT347E:00: supply vddd not found, using dummy regulator > ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator > ov7251 i2c-INT347E:00: cannot get enable gpio > ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -2 > > Suggested-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/media/i2c/ov7251.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/media/i2c/ov7251.c b/drivers/media/i2c/ov7251.c > index 30f61e04ecaf..7b35add1e0ed 100644 > --- a/drivers/media/i2c/ov7251.c > +++ b/drivers/media/i2c/ov7251.c > @@ -1696,7 +1696,21 @@ static int ov7251_probe(struct i2c_client *client) > return PTR_ERR(ov7251->analog_regulator); > } > > + /* > + * The device-tree bindings call this pin "enable", but the > + * datasheet describes the pin as "reset (active low with internal > + * pull down resistor)". The ACPI tables describing this sensor > + * on, e.g., the Microsoft Surface Book use the ACPI equivalent of > + * "reset" as pin name, which ACPI glue code then maps to "reset". > + * Check for a "reset" pin if there is no "enable" pin. > + */ > ov7251->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); > + if (IS_ERR(ov7251->enable_gpio) && > + PTR_ERR(ov7251->enable_gpio) != -EPROBE_DEFER) { > + ov7251->enable_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); > + if (!IS_ERR(ov7251->enable_gpio)) > + gpiod_toggle_active_low(ov7251->enable_gpio); > + } > if (IS_ERR(ov7251->enable_gpio)) { > dev_err(dev, "cannot get enable gpio\n"); > return PTR_ERR(ov7251->enable_gpio);
Hi Andy, Thanks for the patch. On Fri, Nov 08, 2024 at 04:50:24PM +0200, Andy Shevchenko wrote: > The driver of OmniVision OV7251 expects "enable" pin instead of "reset". > Remap "reset" to "enable" and update polarity. > > In particular, the Linux kernel can't load the camera sensor > driver on Microsoft Surface Book without this change: > > ov7251 i2c-INT347E:00: supply vdddo not found, using dummy regulator > ov7251 i2c-INT347E:00: supply vddd not found, using dummy regulator > ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator > ov7251 i2c-INT347E:00: cannot get enable gpio > ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -2 > > Suggested-by: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Should this be cc'd to stable? I guess it's not exactly a fix in the driver but a BIOS bug, but it can be worked around in the driver. :-) > --- > drivers/media/i2c/ov7251.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/media/i2c/ov7251.c b/drivers/media/i2c/ov7251.c > index 30f61e04ecaf..7b35add1e0ed 100644 > --- a/drivers/media/i2c/ov7251.c > +++ b/drivers/media/i2c/ov7251.c > @@ -1696,7 +1696,21 @@ static int ov7251_probe(struct i2c_client *client) > return PTR_ERR(ov7251->analog_regulator); > } > > + /* > + * The device-tree bindings call this pin "enable", but the > + * datasheet describes the pin as "reset (active low with internal > + * pull down resistor)". The ACPI tables describing this sensor It's the functionality that matters albeit I guess this is somewhat a matter of taste: a similar pin was named "reset" for MIPI CCS. > + * on, e.g., the Microsoft Surface Book use the ACPI equivalent of > + * "reset" as pin name, which ACPI glue code then maps to "reset". > + * Check for a "reset" pin if there is no "enable" pin. > + */ > ov7251->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); > + if (IS_ERR(ov7251->enable_gpio) && > + PTR_ERR(ov7251->enable_gpio) != -EPROBE_DEFER) { > + ov7251->enable_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); This looks like it'd benefit from a line wrap. I can do that if there's no need for v2 otherwise. > + if (!IS_ERR(ov7251->enable_gpio)) > + gpiod_toggle_active_low(ov7251->enable_gpio); > + } > if (IS_ERR(ov7251->enable_gpio)) { > dev_err(dev, "cannot get enable gpio\n"); > return PTR_ERR(ov7251->enable_gpio);
On Fri, Nov 08, 2024 at 04:06:39PM +0000, Sakari Ailus wrote: > On Fri, Nov 08, 2024 at 04:50:24PM +0200, Andy Shevchenko wrote: > > The driver of OmniVision OV7251 expects "enable" pin instead of "reset". > > Remap "reset" to "enable" and update polarity. > > > > In particular, the Linux kernel can't load the camera sensor > > driver on Microsoft Surface Book without this change: > > > > ov7251 i2c-INT347E:00: supply vdddo not found, using dummy regulator > > ov7251 i2c-INT347E:00: supply vddd not found, using dummy regulator > > ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator > > ov7251 i2c-INT347E:00: cannot get enable gpio > > ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -2 ... > Should this be cc'd to stable? I guess it's not exactly a fix in the driver > but a BIOS bug, but it can be worked around in the driver. :-) It's everything, but a BIOS bug, it's DT bug and whoever first introduced that GPIO in the driver. Even in the DT present in kernel the pin was referred as CAM_RST_N, which is exactly how this patch names it. OTOH it's a fix to the driver that never worked for ACPI case, so there never was a regression to fix.
Hi Andy, On Fri, Nov 08, 2024 at 06:28:05PM +0200, Andy Shevchenko wrote: > On Fri, Nov 08, 2024 at 04:06:39PM +0000, Sakari Ailus wrote: > > On Fri, Nov 08, 2024 at 04:50:24PM +0200, Andy Shevchenko wrote: > > > The driver of OmniVision OV7251 expects "enable" pin instead of "reset". > > > Remap "reset" to "enable" and update polarity. > > > > > > In particular, the Linux kernel can't load the camera sensor > > > driver on Microsoft Surface Book without this change: > > > > > > ov7251 i2c-INT347E:00: supply vdddo not found, using dummy regulator > > > ov7251 i2c-INT347E:00: supply vddd not found, using dummy regulator > > > ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator > > > ov7251 i2c-INT347E:00: cannot get enable gpio > > > ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -2 > > ... > > > Should this be cc'd to stable? I guess it's not exactly a fix in the driver > > but a BIOS bug, but it can be worked around in the driver. :-) > > It's everything, but a BIOS bug, it's DT bug and whoever first introduced that > GPIO in the driver. Even in the DT present in kernel the pin was referred as How is that a DT (binding?) bug? > CAM_RST_N, which is exactly how this patch names it. > > OTOH it's a fix to the driver that never worked for ACPI case, so there never > was a regression to fix. It probably worked just fine, just not with that Surface Book. The polarity of the enable gpio appears to be set wrong in devm_gpiod_get() call. I can post a patch but cannot test it. Similarly, you should actually set the flags to GPIOD_OUT_HIGH as reset should be enabled here -- it's disabled only in power_on() as part of the power-on sequence.
Hi, On 8-Nov-24 5:42 PM, Sakari Ailus wrote: > Hi Andy, > > On Fri, Nov 08, 2024 at 06:28:05PM +0200, Andy Shevchenko wrote: >> On Fri, Nov 08, 2024 at 04:06:39PM +0000, Sakari Ailus wrote: >>> On Fri, Nov 08, 2024 at 04:50:24PM +0200, Andy Shevchenko wrote: >>>> The driver of OmniVision OV7251 expects "enable" pin instead of "reset". >>>> Remap "reset" to "enable" and update polarity. >>>> >>>> In particular, the Linux kernel can't load the camera sensor >>>> driver on Microsoft Surface Book without this change: >>>> >>>> ov7251 i2c-INT347E:00: supply vdddo not found, using dummy regulator >>>> ov7251 i2c-INT347E:00: supply vddd not found, using dummy regulator >>>> ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator >>>> ov7251 i2c-INT347E:00: cannot get enable gpio >>>> ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -2 >> >> ... >> >>> Should this be cc'd to stable? I guess it's not exactly a fix in the driver >>> but a BIOS bug, but it can be worked around in the driver. :-) >> >> It's everything, but a BIOS bug, it's DT bug and whoever first introduced that >> GPIO in the driver. Even in the DT present in kernel the pin was referred as > > How is that a DT (binding?) bug? Since it is not following the datasheet name for the pin, it arguably is a DT binding bug But whatever, the whole discussion about if it is a bug and whose bug it is is not useful. Since we cannot go back in time and change the DT binding DT and ACPI are simply going to disagree on the name and we will need something like this patch. >> CAM_RST_N, which is exactly how this patch names it. >> >> OTOH it's a fix to the driver that never worked for ACPI case, so there never >> was a regression to fix. > > It probably worked just fine, just not with that Surface Book. > > The polarity of the enable gpio appears to be set wrong in devm_gpiod_get() > call. I can post a patch but cannot test it. That is on purpose, at least the polarity if the devm_gpiod_get(..., "reset", ...) is inverted from the existing one for "enable" because reset needs to be inactive/disabled to enable the sensor. > Similarly, you should actually set the flags to GPIOD_OUT_HIGH as reset > should be enabled here -- it's disabled only in power_on() as part of the > power-on sequence. This seems to be a pre-existing bug in this driver, which currently starts driving enable high, enabling the sensor at gpiod_get() time. Note that fixing this is tricky-ish, if the pin was already high at gpiod_get() time then changing the gpiod_get() to drive it low will result in it only being driven low for a very short time since ov7251_set_power_on() will get called almost immediately after this and it will drive the pin high again without any delays. So if the pin was already high then making it low at gpiod_get() time will result in a very short spike to low, immediately followed by the pin going high again. This short spike may very well leave the sensor in a confused state rather then properly resetting it... OTOH if the pin was already high with the old code where gpiod_get("enable") requests the pin as high (so it is left high), then the existing state of the sensor is simply preserved (no reset) which should be fine for the initial probe which just checks the id register. And if the pin was low then it is driven high once and kept high, so again no glitch / spike. So arguably the old code is fine. If this is changed then a delay needs to be added to ensure that the pin is guaranteed to be driven low for some minimum amount of time. Regards, Hans
Hi Hans, On Fri, Nov 08, 2024 at 07:19:05PM +0100, Hans de Goede wrote: > Hi, > > On 8-Nov-24 5:42 PM, Sakari Ailus wrote: > > Hi Andy, > > > > On Fri, Nov 08, 2024 at 06:28:05PM +0200, Andy Shevchenko wrote: > >> On Fri, Nov 08, 2024 at 04:06:39PM +0000, Sakari Ailus wrote: > >>> On Fri, Nov 08, 2024 at 04:50:24PM +0200, Andy Shevchenko wrote: > >>>> The driver of OmniVision OV7251 expects "enable" pin instead of "reset". > >>>> Remap "reset" to "enable" and update polarity. > >>>> > >>>> In particular, the Linux kernel can't load the camera sensor > >>>> driver on Microsoft Surface Book without this change: > >>>> > >>>> ov7251 i2c-INT347E:00: supply vdddo not found, using dummy regulator > >>>> ov7251 i2c-INT347E:00: supply vddd not found, using dummy regulator > >>>> ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator > >>>> ov7251 i2c-INT347E:00: cannot get enable gpio > >>>> ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -2 > >> > >> ... > >> > >>> Should this be cc'd to stable? I guess it's not exactly a fix in the driver > >>> but a BIOS bug, but it can be worked around in the driver. :-) > >> > >> It's everything, but a BIOS bug, it's DT bug and whoever first introduced that > >> GPIO in the driver. Even in the DT present in kernel the pin was referred as > > > > How is that a DT (binding?) bug? > > Since it is not following the datasheet name for the pin, > it arguably is a DT binding bug > > But whatever, the whole discussion about if it is a bug and whose > bug it is is not useful. Since we cannot go back in time and change > the DT binding DT and ACPI are simply going to disagree on the name > and we will need something like this patch. > > >> CAM_RST_N, which is exactly how this patch names it. > >> > >> OTOH it's a fix to the driver that never worked for ACPI case, so there never > >> was a regression to fix. > > > > It probably worked just fine, just not with that Surface Book. > > > > The polarity of the enable gpio appears to be set wrong in devm_gpiod_get() > > call. I can post a patch but cannot test it. > > That is on purpose, at least the polarity if the devm_gpiod_get(..., "reset", > ...) is inverted from the existing one for "enable" because reset needs > to be inactive/disabled to enable the sensor. > > > Similarly, you should actually set the flags to GPIOD_OUT_HIGH as reset > > should be enabled here -- it's disabled only in power_on() as part of the > > power-on sequence. > > This seems to be a pre-existing bug in this driver, which currently > starts driving enable high, enabling the sensor at gpiod_get() time. > > Note that fixing this is tricky-ish, if the pin was already high at > gpiod_get() time then changing the gpiod_get() to drive it low > will result in it only being driven low for a very short time since > ov7251_set_power_on() will get called almost immediately after this > and it will drive the pin high again without any delays. The question here is not about how long the hard reset is applied, but whether or not the sensor's power-on sequence is followed. Currently it is not. > > So if the pin was already high then making it low at gpiod_get() > time will result in a very short spike to low, immediately followed > by the pin going high again. This short spike may very well leave > the sensor in a confused state rather then properly resetting it... > > OTOH if the pin was already high with the old code where > gpiod_get("enable") requests the pin as high (so it is left high), > then the existing state of the sensor is simply preserved (no reset) > which should be fine for the initial probe which just checks > the id register. > > And if the pin was low then it is driven high once and kept high, > so again no glitch / spike. So arguably the old code is fine. I'm not sure how do you reach that conclusion. Because it happens to work, presumably at least somewhere? The code appears to be part of the > > If this is changed then a delay needs to be added to ensure that > the pin is guaranteed to be driven low for some minimum amount > of time.
Hi, On 11-Nov-24 8:55 AM, Sakari Ailus wrote: > Hi Hans, > > On Fri, Nov 08, 2024 at 07:19:05PM +0100, Hans de Goede wrote: >> Hi, >> >> On 8-Nov-24 5:42 PM, Sakari Ailus wrote: >>> Hi Andy, >>> >>> On Fri, Nov 08, 2024 at 06:28:05PM +0200, Andy Shevchenko wrote: >>>> On Fri, Nov 08, 2024 at 04:06:39PM +0000, Sakari Ailus wrote: >>>>> On Fri, Nov 08, 2024 at 04:50:24PM +0200, Andy Shevchenko wrote: >>>>>> The driver of OmniVision OV7251 expects "enable" pin instead of "reset". >>>>>> Remap "reset" to "enable" and update polarity. >>>>>> >>>>>> In particular, the Linux kernel can't load the camera sensor >>>>>> driver on Microsoft Surface Book without this change: >>>>>> >>>>>> ov7251 i2c-INT347E:00: supply vdddo not found, using dummy regulator >>>>>> ov7251 i2c-INT347E:00: supply vddd not found, using dummy regulator >>>>>> ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator >>>>>> ov7251 i2c-INT347E:00: cannot get enable gpio >>>>>> ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -2 >>>> >>>> ... >>>> >>>>> Should this be cc'd to stable? I guess it's not exactly a fix in the driver >>>>> but a BIOS bug, but it can be worked around in the driver. :-) >>>> >>>> It's everything, but a BIOS bug, it's DT bug and whoever first introduced that >>>> GPIO in the driver. Even in the DT present in kernel the pin was referred as >>> >>> How is that a DT (binding?) bug? >> >> Since it is not following the datasheet name for the pin, >> it arguably is a DT binding bug >> >> But whatever, the whole discussion about if it is a bug and whose >> bug it is is not useful. Since we cannot go back in time and change >> the DT binding DT and ACPI are simply going to disagree on the name >> and we will need something like this patch. >> >>>> CAM_RST_N, which is exactly how this patch names it. >>>> >>>> OTOH it's a fix to the driver that never worked for ACPI case, so there never >>>> was a regression to fix. >>> >>> It probably worked just fine, just not with that Surface Book. >>> >>> The polarity of the enable gpio appears to be set wrong in devm_gpiod_get() >>> call. I can post a patch but cannot test it. >> >> That is on purpose, at least the polarity if the devm_gpiod_get(..., "reset", >> ...) is inverted from the existing one for "enable" because reset needs >> to be inactive/disabled to enable the sensor. >> >>> Similarly, you should actually set the flags to GPIOD_OUT_HIGH as reset >>> should be enabled here -- it's disabled only in power_on() as part of the >>> power-on sequence. >> >> This seems to be a pre-existing bug in this driver, which currently >> starts driving enable high, enabling the sensor at gpiod_get() time. >> >> Note that fixing this is tricky-ish, if the pin was already high at >> gpiod_get() time then changing the gpiod_get() to drive it low >> will result in it only being driven low for a very short time since >> ov7251_set_power_on() will get called almost immediately after this >> and it will drive the pin high again without any delays. > > The question here is not about how long the hard reset is applied, but > whether or not the sensor's power-on sequence is followed. Currently it is > not. Right / agreed. The 2 points which I am trying to make are: 1. This is a pre-existing problem unrelated to this patch. So this should be fixed in a separate patch. 2. That separate patch should put a delay after requesting the GPIO to enforce that it is (logically) low (for "enable") for a minimum amount of time. Regards, Hans
diff --git a/drivers/media/i2c/ov7251.c b/drivers/media/i2c/ov7251.c index 30f61e04ecaf..7b35add1e0ed 100644 --- a/drivers/media/i2c/ov7251.c +++ b/drivers/media/i2c/ov7251.c @@ -1696,7 +1696,21 @@ static int ov7251_probe(struct i2c_client *client) return PTR_ERR(ov7251->analog_regulator); } + /* + * The device-tree bindings call this pin "enable", but the + * datasheet describes the pin as "reset (active low with internal + * pull down resistor)". The ACPI tables describing this sensor + * on, e.g., the Microsoft Surface Book use the ACPI equivalent of + * "reset" as pin name, which ACPI glue code then maps to "reset". + * Check for a "reset" pin if there is no "enable" pin. + */ ov7251->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); + if (IS_ERR(ov7251->enable_gpio) && + PTR_ERR(ov7251->enable_gpio) != -EPROBE_DEFER) { + ov7251->enable_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); + if (!IS_ERR(ov7251->enable_gpio)) + gpiod_toggle_active_low(ov7251->enable_gpio); + } if (IS_ERR(ov7251->enable_gpio)) { dev_err(dev, "cannot get enable gpio\n"); return PTR_ERR(ov7251->enable_gpio);
The driver of OmniVision OV7251 expects "enable" pin instead of "reset". Remap "reset" to "enable" and update polarity. In particular, the Linux kernel can't load the camera sensor driver on Microsoft Surface Book without this change: ov7251 i2c-INT347E:00: supply vdddo not found, using dummy regulator ov7251 i2c-INT347E:00: supply vddd not found, using dummy regulator ov7251 i2c-INT347E:00: supply vdda not found, using dummy regulator ov7251 i2c-INT347E:00: cannot get enable gpio ov7251 i2c-INT347E:00: probe with driver ov7251 failed with error -2 Suggested-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/media/i2c/ov7251.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)