| Message ID | 20241109-b4-max17042-v1-1-9e2b07e54e76@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | power: supply: max17042: cleanup and more features | expand |
On 09/11/2024 13:44, Dzmitry Sankouski wrote: > If specified, driver should request irq as shared. > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > --- > Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > index 085e2504d0dc..e98ffdad1ec3 100644 > --- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml > @@ -59,6 +59,11 @@ properties: > Voltage threshold to report battery as over voltage (in mV). > Default is not to report over-voltage events. > > + shared-irq: > + description: | > + Request interrupt as shared. > + Set in case of other devices using same interrupt pin. Why you cannot request shared interrupt always? It's not the property of this device to know whether its interrupt is shared or not. What if we add overlay sharing the interrupt? Nope, that's just describing OS behavior. Best regards, Krzysztof
On Sat, 09 Nov 2024 15:44:33 +0300, Dzmitry Sankouski wrote: > If specified, driver should request irq as shared. > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > --- > Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml: shared-irq: missing type definition doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241109-b4-max17042-v1-1-9e2b07e54e76@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml index 085e2504d0dc..e98ffdad1ec3 100644 --- a/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml +++ b/Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml @@ -59,6 +59,11 @@ properties: Voltage threshold to report battery as over voltage (in mV). Default is not to report over-voltage events. + shared-irq: + description: | + Request interrupt as shared. + Set in case of other devices using same interrupt pin. + power-supplies: true required: @@ -79,5 +84,6 @@ examples: maxim,rsns-microohm = <10000>; maxim,over-heat-temp = <600>; maxim,over-volt = <4300>; + shared-irq; }; };
If specified, driver should request irq as shared. Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> --- Documentation/devicetree/bindings/power/supply/maxim,max17042.yaml | 6 ++++++ 1 file changed, 6 insertions(+)