[v1,0/6] exfat: reduce FAT chain traversal

Message

[e-mail] Oct. 30, 2024, 6:11 a.m. UTC

This patch set is designed to reduce FAT traversal, it includes the
patch to implement this feature as well as the patches to optimize and
clean up the code to facilitate the implementation of this feature.

Yuezhang Mo (6):
  exfat: remove unnecessary read entry in __exfat_rename()
  exfat: add exfat_get_dentry_set_by_inode() helper
  exfat: move exfat_chain_set() out of __exfat_resolve_path()
  exfat: remove argument 'p_dir' from exfat_add_entry()
  exfat: code cleanup for exfat_readdir()
  exfat: reduce FAT chain traversal

 fs/exfat/dir.c      |  38 ++++-------
 fs/exfat/exfat_fs.h |   2 +
 fs/exfat/inode.c    |   2 +-
 fs/exfat/namei.c    | 155 +++++++++++++++++++-------------------------
 4 files changed, 82 insertions(+), 115 deletions(-)

Comments

Sungjong Seo Nov. 8, 2024, 11:39 a.m. UTC | #1

Hi, Yuezhang,
> This patch set is designed to reduce FAT traversal, it includes the
> patch to implement this feature as well as the patches to optimize and
> clean up the code to facilitate the implementation of this feature.
> 
> Yuezhang Mo (6):
>   exfat: remove unnecessary read entry in __exfat_rename()
>   exfat: add exfat_get_dentry_set_by_inode() helper
>   exfat: move exfat_chain_set() out of __exfat_resolve_path()
>   exfat: remove argument 'p_dir' from exfat_add_entry()
>   exfat: code cleanup for exfat_readdir()
>   exfat: reduce FAT chain traversal

You are awesome! Looks good!
It seems like a lot of inefficient code has been cleaned up overall.

BTW, only one thing about the patch 'reduce FAT chain traversal',
there may be confusion as the concepts of 'dir' and 'entry' within
'struct exfat_dir_entry' have changed from what we previously understood.

To clarify the changed concept, how about leaving an inline description
for each of 'dir' and 'entry' in 'struct exfat_dir_entry'?

> 
>  fs/exfat/dir.c      |  38 ++++-------
>  fs/exfat/exfat_fs.h |   2 +
>  fs/exfat/inode.c    |   2 +-
>  fs/exfat/namei.c    | 155 +++++++++++++++++++-------------------------
>  4 files changed, 82 insertions(+), 115 deletions(-)
> 
> --
> 2.43.0

[e-mail] Nov. 11, 2024, 6:04 a.m. UTC | #2

> BTW, only one thing about the patch 'reduce FAT chain traversal',
> there may be confusion as the concepts of 'dir' and 'entry' within
> 'struct exfat_dir_entry' have changed from what we previously understood.
>
> To clarify the changed concept, how about leaving an inline description
> for each of 'dir' and 'entry' in 'struct exfat_dir_entry'?

Thanks for your comment.
I will add inline descriptions for 'dir' and 'entry'  in  'struct exfat_dir_entry' and
'struct exfat_inode_info'.