mbox series

[v2,0/5] fscache/cachefiles: Some bugfixes

Message ID 20241107110649.3980193-1-wozizhi@huawei.com (mailing list archive)
Headers show
Series fscache/cachefiles: Some bugfixes | expand

Message

Zizhi Wo Nov. 7, 2024, 11:06 a.m. UTC
Changes since V1[1]:
 - Removed some incorrect patches.
 - Modified the description of the first patch.
 - Modified the fourth patch to move fput out of lock execution.

Recently, I sent the first version of the patch series. After some
discussions, I made modifications to a few patches and have now officially
sent this second version.

This patchset mainly includes 5 fix patches about fscache/cachefiles.
Additionally, patches 2, 3, and 5 have already been ACKed. The first patch
fixes an issue with the incorrect return length, and the fourth patch
addresses a null pointer dereference issue with file.

[1] https://lore.kernel.org/all/20240821024301.1058918-1-wozizhi@huawei.com/

Zizhi Wo (5):
  cachefiles: Fix incorrect length return value in
    cachefiles_ondemand_fd_write_iter()
  cachefiles: Fix missing pos updates in
    cachefiles_ondemand_fd_write_iter()
  cachefiles: Clean up in cachefiles_commit_tmpfile()
  cachefiles: Fix NULL pointer dereference in object->file
  netfs/fscache: Add a memory barrier for FSCACHE_VOLUME_CREATING

 fs/cachefiles/interface.c | 14 ++++++++++----
 fs/cachefiles/namei.c     |  5 -----
 fs/cachefiles/ondemand.c  | 38 +++++++++++++++++++++++++++++---------
 fs/netfs/fscache_volume.c |  3 +--
 4 files changed, 40 insertions(+), 20 deletions(-)

Comments

Christian Brauner Nov. 11, 2024, 11:33 a.m. UTC | #1
On Thu, 07 Nov 2024 19:06:44 +0800, Zizhi Wo wrote:
> Changes since V1[1]:
>  - Removed some incorrect patches.
>  - Modified the description of the first patch.
>  - Modified the fourth patch to move fput out of lock execution.
> 
> Recently, I sent the first version of the patch series. After some
> discussions, I made modifications to a few patches and have now officially
> sent this second version.
> 
> [...]

Applied to the vfs.netfs branch of the vfs/vfs.git tree.
Patches in the vfs.netfs branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.netfs

[1/5] cachefiles: Fix incorrect length return value in cachefiles_ondemand_fd_write_iter()
      https://git.kernel.org/vfs/vfs/c/544e429e5bc6
[2/5] cachefiles: Fix missing pos updates in cachefiles_ondemand_fd_write_iter()
      https://git.kernel.org/vfs/vfs/c/a89ef3809efd
[3/5] cachefiles: Clean up in cachefiles_commit_tmpfile()
      https://git.kernel.org/vfs/vfs/c/d76293bc8658
[4/5] cachefiles: Fix NULL pointer dereference in object->file
      https://git.kernel.org/vfs/vfs/c/53260e5cb920
[5/5] netfs/fscache: Add a memory barrier for FSCACHE_VOLUME_CREATING
      https://git.kernel.org/vfs/vfs/c/37e1f64cbc1b