| Message ID | 20241025161501.485684-21-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | spi-nand/spi-mem DTR support | expand |
On 10/25/24 5:14 PM, Miquel Raynal wrote: > Follow the order used by all the other similar macros: > - nbytes > - value/buffer > - buswidth > - other fields > > There is no functional change. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > include/linux/spi/spi-mem.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h > index 379c048b2eb4..318ea7b193cc 100644 > --- a/include/linux/spi/spi-mem.h > +++ b/include/linux/spi/spi-mem.h > @@ -15,9 +15,9 @@ > > #define SPI_MEM_OP_CMD(__opcode, __buswidth) \ > { \ > - .buswidth = __buswidth, \ > - .opcode = __opcode, \ > .nbytes = 1, \ > + .opcode = __opcode, \ > + .buswidth = __buswidth, \ > } > I don't mind, but shouldn't we follow the order used at struct declaration? struct spi_mem_op { struct { u8 nbytes; u8 buswidth; u8 dtr : 1; u8 __pad : 7; u16 opcode; } cmd;
diff --git a/include/linux/spi/spi-mem.h b/include/linux/spi/spi-mem.h index 379c048b2eb4..318ea7b193cc 100644 --- a/include/linux/spi/spi-mem.h +++ b/include/linux/spi/spi-mem.h @@ -15,9 +15,9 @@ #define SPI_MEM_OP_CMD(__opcode, __buswidth) \ { \ - .buswidth = __buswidth, \ - .opcode = __opcode, \ .nbytes = 1, \ + .opcode = __opcode, \ + .buswidth = __buswidth, \ } #define SPI_MEM_OP_ADDR(__nbytes, __val, __buswidth) \
Follow the order used by all the other similar macros: - nbytes - value/buffer - buswidth - other fields There is no functional change. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- include/linux/spi/spi-mem.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)