| Message ID | 20241111123125.2034898-1-quic_amisjain@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 486aeafd87bc23bb7969671b06ceaafc124dea84 |
| Headers | show |
| Series | [v1] obex: Check for supported features bit value for legacy server | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=908391 ---Test result--- Test Summary: CheckPatch PASS 0.44 seconds GitLint PASS 0.41 seconds BuildEll PASS 24.74 seconds BluezMake PASS 1800.88 seconds MakeCheck PASS 13.58 seconds MakeDistcheck PASS 188.59 seconds CheckValgrind PASS 262.96 seconds CheckSmatch PASS 371.16 seconds bluezmakeextell PASS 125.55 seconds IncrementalBuild PASS 1695.02 seconds ScanBuild PASS 1078.32 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 11 Nov 2024 18:01:25 +0530 you wrote: > This fix is required for below PTS testcase: > > 1. PBAP/PCE/SSM/BV-10-C > Description - Verify that the PCE does not share its > PbapSupportedFeatures bits with a legacy server. > > Incase of legacy server, check for 'supported features bit' > uint_32_t value instead of directly checking the pointer > holding the attribute. > As pointer 'data' won't be null as PbapSupportedFeatures > attribute is present in SDP record but it's value is zero. > > [...] Here is the summary with links: - [v1] obex: Check for supported features bit value for legacy server https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=486aeafd87bc You are awesome, thank you!
diff --git a/obexd/client/pbap.c b/obexd/client/pbap.c index bc3fdcf9f..09d3fd425 100644 --- a/obexd/client/pbap.c +++ b/obexd/client/pbap.c @@ -1219,6 +1219,7 @@ static void *pbap_supported_features(struct obc_session *session) { const void *data; uint16_t version; + uint32_t features; /* Version */ data = obc_session_get_attribute(session, SDP_ATTR_PFILE_DESC_LIST); @@ -1233,7 +1234,9 @@ static void *pbap_supported_features(struct obc_session *session) /* Supported Feature Bits */ data = obc_session_get_attribute(session, SDP_ATTR_PBAP_SUPPORTED_FEATURES); - if (!data) + + features = *(uint32_t *) data; + if (!features) return NULL; return g_obex_apparam_set_uint32(NULL, SUPPORTED_FEATURES_TAG,