diff mbox series

[net-next,1/2] dt-bindings: net: dsa: microchip: Add SGMII port support to KSZ9477 switch

Message ID 20241109015633.82638-2-Tristram.Ha@microchip.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series net: dsa: microchip: Add SGMII port support to KSZ9477 switch | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 3 this patch: 3
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 13 of 13 maintainers
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 13 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-11-09--03-00 (tests: 784)

Commit Message

Tristram.Ha@microchip.com Nov. 9, 2024, 1:56 a.m. UTC 
From: Tristram Ha <tristram.ha@microchip.com>

Update the KSZ9477 switch example to use SFP cage for SGMII support.

Signed-off-by: Tristram Ha <tristram.ha@microchip.com>
---
 .../devicetree/bindings/net/dsa/microchip,ksz.yaml         | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Krzysztof Kozlowski Nov. 9, 2024, 10:43 a.m. UTC | #1 
On Fri, Nov 08, 2024 at 05:56:32PM -0800, Tristram.Ha@microchip.com wrote:
> From: Tristram Ha <tristram.ha@microchip.com>
> 
> Update the KSZ9477 switch example to use SFP cage for SGMII support.

Why? That's just an example. Why do we want it? Why no changes to
bindings? Your commit msg must answer to all these.

Best regards,
Krzysztof
Tristram.Ha@microchip.com Nov. 12, 2024, 2:45 a.m. UTC | #2 
> Subject: Re: [PATCH net-next 1/2] dt-bindings: net: dsa: microchip: Add SGMII port
> support to KSZ9477 switch
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content
> is safe
> 
> On Fri, Nov 08, 2024 at 05:56:32PM -0800, Tristram.Ha@microchip.com wrote:
> > From: Tristram Ha <tristram.ha@microchip.com>
> >
> > Update the KSZ9477 switch example to use SFP cage for SGMII support.
> 
> Why? That's just an example. Why do we want it? Why no changes to
> bindings? Your commit msg must answer to all these.

As the added SGMII support needs the correct device tree declaration to
activate the SFP code, users may need that to use the port.  However the
driver can operate the port without that code, if the current patch is
accepted.  But if you say it is not necessary then it is better to not
change the file.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
index 30c0c3e6f37a..e989723f5ad6 100644
--- a/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/microchip,ksz.yaml
@@ -180,6 +180,13 @@  examples:
                         full-duplex;
                     };
                 };
+                port@6 {
+                    reg = <6>;
+                    label = "lan6";
+                    phy-mode = "sgmii";
+                    sfp = <&sfp>;
+                    managed = "in-band-status";
+                };
             };
         };