| Message ID | 20241104190742.276710-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | In Next |
| Headers | show |
| Series | pmdomain: imx: Use of_property_present() for non-boolean properties | expand |
On Mon, 4 Nov 2024 at 20:07, Rob Herring (Arm) <robh@kernel.org> wrote: > > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Applied for next, thanks! Kind regards Uffe > --- > drivers/pmdomain/imx/gpc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pmdomain/imx/gpc.c b/drivers/pmdomain/imx/gpc.c > index 80a4dcc77199..fbb4c90b72c4 100644 > --- a/drivers/pmdomain/imx/gpc.c > +++ b/drivers/pmdomain/imx/gpc.c > @@ -411,7 +411,7 @@ static int imx_gpc_probe(struct platform_device *pdev) > pgc_node = of_get_child_by_name(pdev->dev.of_node, "pgc"); > > /* bail out if DT too old and doesn't provide the necessary info */ > - if (!of_property_read_bool(pdev->dev.of_node, "#power-domain-cells") && > + if (!of_property_present(pdev->dev.of_node, "#power-domain-cells") && > !pgc_node) > return 0; > > @@ -511,7 +511,7 @@ static void imx_gpc_remove(struct platform_device *pdev) > pgc_node = of_get_child_by_name(pdev->dev.of_node, "pgc"); > > /* bail out if DT too old and doesn't provide the necessary info */ > - if (!of_property_read_bool(pdev->dev.of_node, "#power-domain-cells") && > + if (!of_property_present(pdev->dev.of_node, "#power-domain-cells") && > !pgc_node) > return; > > -- > 2.45.2 >
diff --git a/drivers/pmdomain/imx/gpc.c b/drivers/pmdomain/imx/gpc.c index 80a4dcc77199..fbb4c90b72c4 100644 --- a/drivers/pmdomain/imx/gpc.c +++ b/drivers/pmdomain/imx/gpc.c @@ -411,7 +411,7 @@ static int imx_gpc_probe(struct platform_device *pdev) pgc_node = of_get_child_by_name(pdev->dev.of_node, "pgc"); /* bail out if DT too old and doesn't provide the necessary info */ - if (!of_property_read_bool(pdev->dev.of_node, "#power-domain-cells") && + if (!of_property_present(pdev->dev.of_node, "#power-domain-cells") && !pgc_node) return 0; @@ -511,7 +511,7 @@ static void imx_gpc_remove(struct platform_device *pdev) pgc_node = of_get_child_by_name(pdev->dev.of_node, "pgc"); /* bail out if DT too old and doesn't provide the necessary info */ - if (!of_property_read_bool(pdev->dev.of_node, "#power-domain-cells") && + if (!of_property_present(pdev->dev.of_node, "#power-domain-cells") && !pgc_node) return;
The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/pmdomain/imx/gpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)