mbox series

[RESEND,net,0/7] There are some bugfix for the HNS3 ethernet driver

Message ID 20241107133023.3813095-1-shaojijie@huawei.com (mailing list archive)
Headers show
Series There are some bugfix for the HNS3 ethernet driver | expand

Message

Jijie Shao Nov. 7, 2024, 1:30 p.m. UTC
There's a series of bugfix that's been accepted:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=d80a3091308491455b6501b1c4b68698c4a7cd24

However, The series is making the driver poke into IOMMU internals instead of
implementing appropriate IOMMU workarounds. After discussion, the series was reverted:
https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=249cfa318fb1b77eb726c2ff4f74c9685f04e568

But only two patches are related to the IOMMU.
Other patches involve only the modification of the driver.
This series resends other patches.

Hao Lan (4):
  net: hns3: fixed reset failure issues caused by the incorrect reset
    type
  net: hns3: fix missing features due to dev->features configuration too
    early
  net: hns3: Resolved the issue that the debugfs query result is
    inconsistent.
  net: hns3: fixed hclge_fetch_pf_reg accesses bar space out of bounds
    issue

Jian Shen (2):
  net: hns3: don't auto enable misc vector
  net: hns3: initialize reset_timer before hclgevf_misc_irq_init()

Jie Wang (1):
  net: hns3: fix kernel crash when 1588 is sent on HIP08 devices

 .../ethernet/hisilicon/hns3/hns3_debugfs.c    |  4 +-
 .../net/ethernet/hisilicon/hns3/hns3_enet.c   |  1 -
 .../hisilicon/hns3/hns3pf/hclge_main.c        | 45 +++++++++++++++----
 .../hisilicon/hns3/hns3pf/hclge_ptp.c         |  3 ++
 .../hisilicon/hns3/hns3pf/hclge_regs.c        |  9 ++--
 .../hisilicon/hns3/hns3vf/hclgevf_main.c      | 40 ++++++++++++++---
 .../hisilicon/hns3/hns3vf/hclgevf_regs.c      |  9 ++--
 7 files changed, 85 insertions(+), 26 deletions(-)

Comments

Simon Horman Nov. 12, 2024, 5:08 p.m. UTC | #1
On Thu, Nov 07, 2024 at 09:30:16PM +0800, Jijie Shao wrote:
> There's a series of bugfix that's been accepted:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=d80a3091308491455b6501b1c4b68698c4a7cd24
> 
> However, The series is making the driver poke into IOMMU internals instead of
> implementing appropriate IOMMU workarounds. After discussion, the series was reverted:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=249cfa318fb1b77eb726c2ff4f74c9685f04e568
> 
> But only two patches are related to the IOMMU.
> Other patches involve only the modification of the driver.
> This series resends other patches.

Hi Jijie Shao,

Cover letters for patch-sets for Networking do make it into git history,
e.g. This cover letter [1] became this commit [2]. So please consider a
subject that will be more meaningful there.

e.g. [PATCH net v2 0/7] net: hns3: implement IOMMU workarounds

Thanks!

[1] [PATCH net v2 0/3] virtio/vsock: Fix memory leaks
    https://lore.kernel.org/netdev/20241107-vsock-mem-leaks-v2-0-4e21bfcfc818@rbox.co/
[2] 20bbe5b80249 ("Merge branch 'virtio-vsock-fix-memory-leaks'")
    https://git.kernel.org/netdev/net/c/20bbe5b80249

...
Jijie Shao Nov. 13, 2024, 3:21 a.m. UTC | #2
on 2024/11/13 1:08, Simon Horman wrote:
> On Thu, Nov 07, 2024 at 09:30:16PM +0800, Jijie Shao wrote:
>> There's a series of bugfix that's been accepted:
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=d80a3091308491455b6501b1c4b68698c4a7cd24
>>
>> However, The series is making the driver poke into IOMMU internals instead of
>> implementing appropriate IOMMU workarounds. After discussion, the series was reverted:
>> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=249cfa318fb1b77eb726c2ff4f74c9685f04e568
>>
>> But only two patches are related to the IOMMU.
>> Other patches involve only the modification of the driver.
>> This series resends other patches.
> Hi Jijie Shao,
>
> Cover letters for patch-sets for Networking do make it into git history,
> e.g. This cover letter [1] became this commit [2]. So please consider a
> subject that will be more meaningful there.
>
> e.g. [PATCH net v2 0/7] net: hns3: implement IOMMU workarounds


Okay, no problem. I'll pay more attention to this.

Thanks
Jijie Shao

>
> Thanks!
>
> [1] [PATCH net v2 0/3] virtio/vsock: Fix memory leaks
>      https://lore.kernel.org/netdev/20241107-vsock-mem-leaks-v2-0-4e21bfcfc818@rbox.co/
> [2] 20bbe5b80249 ("Merge branch 'virtio-vsock-fix-memory-leaks'")
>      https://git.kernel.org/netdev/net/c/20bbe5b80249
>
> ...