| Message ID | 20241104132513.15890-1-yi.l.liu@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | iommufd support pasid attach/replace | expand |
On Mon, Nov 04, 2024 at 05:25:01AM -0800, Yi Liu wrote: > This series is based on the preparation series [1] [2], it first adds a > missing iommu API to replace the domain for a pasid. Let's try hard to get some of these dependencies merged this cycle.. Thanks, Jason
On 11/13/24 09:37, Jason Gunthorpe wrote: > On Mon, Nov 04, 2024 at 05:25:01AM -0800, Yi Liu wrote: > >> This series is based on the preparation series [1] [2], it first adds a >> missing iommu API to replace the domain for a pasid. > Let's try hard to get some of these dependencies merged this cycle.. The pasid replace has been merged in the iommu tree. Yi, did I overlook anything? -- baolu
On 2024/11/13 11:01, Baolu Lu wrote: > On 11/13/24 09:37, Jason Gunthorpe wrote: >> On Mon, Nov 04, 2024 at 05:25:01AM -0800, Yi Liu wrote: >> >>> This series is based on the preparation series [1] [2], it first adds a >>> missing iommu API to replace the domain for a pasid. >> Let's try hard to get some of these dependencies merged this cycle.. > > The pasid replace has been merged in the iommu tree. > > Yi, did I overlook anything? I think Jason means the two series I listed. The first one has already been merged by you and Joerg [1]. While the second one [2] is not yet. It might not be a hard dependency of the iommufd pasid series, but as it was originated from the iommufd pasid series, so it is listed here as well. I think it is already in good shape except one nit spotted by you. Perhaps I can update a version and see what we can do for it. [1] https://lore.kernel.org/linux-iommu/20241108021406.173972-1-baolu.lu@linux.intel.com/ [2] https://lore.kernel.org/linux-iommu/20241108021406.173972-1-baolu.lu@linux.intel.com/
On 2024/11/13 11:24, Yi Liu wrote: > On 2024/11/13 11:01, Baolu Lu wrote: >> On 11/13/24 09:37, Jason Gunthorpe wrote: >>> On Mon, Nov 04, 2024 at 05:25:01AM -0800, Yi Liu wrote: >>> >>>> This series is based on the preparation series [1] [2], it first adds a >>>> missing iommu API to replace the domain for a pasid. >>> Let's try hard to get some of these dependencies merged this cycle.. >> >> The pasid replace has been merged in the iommu tree. >> >> Yi, did I overlook anything? > > I think Jason means the two series I listed. The first one has already been > merged by you and Joerg [1]. While the second one [2] is not yet. It might > not be a hard dependency of the iommufd pasid series, but as it was > originated from the iommufd pasid series, so it is listed here as well. I > think it is already in good shape except one nit spotted by you. Perhaps I > can update a version and see what we can do for it. > > [1] > https://lore.kernel.org/linux-iommu/20241108021406.173972-1-baolu.lu@linux.intel.com/ > [2] https://lore.kernel.org/linux-iommu/20241108120427.13562-1-yi.l.liu@intel.com/ > corrected the link [2].
PASID (Process Address Space ID) is a PCIe extension to tag the DMA transactions out of a physical device, and most modern IOMMU hardware have supported PASID granular address translation. So a PASID-capable device can be attached to multiple hwpts (a.k.a. domains), and each attachment is tagged with a pasid. This series is based on the preparation series [1] [2], it first adds a missing iommu API to replace the domain for a pasid. Based on the iommu pasid attach/ replace/detach APIs, this series adds iommufd APIs for device drivers to attach/replace/detach pasid to/from hwpt per userspace's request, and adds selftest to validate the iommufd APIs. The completed code can be found in the below link [3]. Heads up! The existing iommufd selftest was broken, there was a fix [4] to it, but not been upstreamed yet. If want to run the iommufd selftest, please apply that fix. Sorry for the inconvenience. [1] https://lore.kernel.org/linux-iommu/20241104131842.13303-1-yi.l.liu@intel.com/ [2] https://lore.kernel.org/linux-iommu/20241104132033.14027-1-yi.l.liu@intel.com/ [3] https://github.com/yiliu1765/iommufd/tree/iommufd_pasid [4] https://lore.kernel.org/linux-iommu/20240111073213.180020-1-baolu.lu@linux.intel.com/ Change log: v5: - Fix a mistake in patch 02 of v4 (Kevin) - Move the iommufd_handle helpers to device.c - Add IOMMU_HWPT_ALLOC_PASID check to enforce pasid-compatible domain for pasid capable device in iommufd - Update the iommufd selftest to use IOMMU_HWPT_ALLOC_PASID v4: https://lore.kernel.org/linux-iommu/20240912131255.13305-1-yi.l.liu@intel.com/ - Replace remove_dev_pasid() by supporting set_dev_pasid() for blocking domain (Kevin) - This is done by the preparation series "Support attaching PASID to the blocked_domain" - Misc tweaks to foil the merging of the iommufd iopf series. Three new patches are added: - iommufd: Always pass iommu_attach_handle to iommu core - iommufd: Move the iommufd_handle helpers to iommufd_private.h - iommufd: Refactor __fault_domain_replace_dev() to be a wrapper of iommu_replace_group_handle() - Renmae patch 03 of v3 to be "iommufd: Support pasid attach/replace" - Add test case for attaching/replacing iopf-capable hwpt to pasid v3: https://lore.kernel.org/kvm/20240628090557.50898-1-yi.l.liu@intel.com/ - Split the set_dev_pasid op enhancements for domain replacement to be a separate series "Make set_dev_pasid op supportting domain replacement" [1]. The below changes are made in the separate series. *) set_dev_pasid() callback should keep the old config if failed to attach to a domain. This simplifies the caller a lot as caller does not need to attach it back to old domain explicitly. This also avoids some corner cases in which the core may do duplicated domain attachment as described in below link (Jason) https://lore.kernel.org/linux-iommu/BN9PR11MB52768C98314A95AFCD2FA6478C0F2@BN9PR11MB5276.namprd11.prod.outlook.com/ *) Drop patch 10 of v2 as it's a bug fix and can be submitted separately (Kevin) *) Rebase on top of Baolu's domain_alloc_paging refactor series (Jason) - Drop the attach_data which includes attach_fn and pasid, insteadly passing the pasid through the device attach path. (Jason) - Add a pasid-num-bits property to mock dev to make pasid selftest work (Kevin) v2: https://lore.kernel.org/linux-iommu/20240412081516.31168-1-yi.l.liu@intel.com/ - Domain replace for pasid should be handled in set_dev_pasid() callbacks instead of remove_dev_pasid and call set_dev_pasid afteward in iommu layer (Jason) - Make xarray operations more self-contained in iommufd pasid attach/replace/detach (Jason) - Tweak the dev_iommu_get_max_pasids() to allow iommu driver to populate the max_pasids. This makes the iommufd selftest simpler to meet the max_pasids check in iommu_attach_device_pasid() (Jason) v1: https://lore.kernel.org/kvm/20231127063428.127436-1-yi.l.liu@intel.com/#r - Implemnet iommu_replace_device_pasid() to fall back to the original domain if this replacement failed (Kevin) - Add check in do_attach() to check corressponding attach_fn per the pasid value. rfc: https://lore.kernel.org/linux-iommu/20230926092651.17041-1-yi.l.liu@intel.com/ Regards, Yi Liu Yi Liu (12): iommu: Introduce a replace API for device pasid iommufd: Refactor __fault_domain_replace_dev() to be a wrapper of iommu_replace_group_handle() iommufd: Move the iommufd_handle helpers to device.c iommufd: Always pass iommu_attach_handle to iommu core iommufd: Pass pasid through the device attach/replace path iommufd: Support pasid attach/replace iommufd: Allocate auto_domain with IOMMU_HWPT_ALLOC_PASID flag if device is PASID-capable iommufd: Enforce pasid compatible domain for PASID-capable device iommufd/selftest: Add set_dev_pasid in mock iommu iommufd/selftest: Add a helper to get test device iommufd/selftest: Add test ops to test pasid attach/detach iommufd/selftest: Add coverage for iommufd pasid attach/detach drivers/iommu/intel/iommu.c | 6 +- drivers/iommu/iommu-priv.h | 4 + drivers/iommu/iommu.c | 90 +++++- drivers/iommu/iommufd/Makefile | 1 + drivers/iommu/iommufd/device.c | 111 +++++-- drivers/iommu/iommufd/fault.c | 88 ++---- drivers/iommu/iommufd/hw_pagetable.c | 12 +- drivers/iommu/iommufd/iommufd_private.h | 81 ++++- drivers/iommu/iommufd/iommufd_test.h | 31 ++ drivers/iommu/iommufd/pasid.c | 157 ++++++++++ drivers/iommu/iommufd/selftest.c | 210 ++++++++++++- include/linux/iommufd.h | 7 + tools/testing/selftests/iommu/iommufd.c | 277 ++++++++++++++++++ .../selftests/iommu/iommufd_fail_nth.c | 35 ++- tools/testing/selftests/iommu/iommufd_utils.h | 78 +++++ 15 files changed, 1054 insertions(+), 134 deletions(-) create mode 100644 drivers/iommu/iommufd/pasid.c