| Message ID | 20240920-dev-maxh-svukte-rebase-v1-1-7864a88a62bd@sifive.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | riscv: add Svukte extension | expand |
| Context | Check | Description |
|---|---|---|
| conchuod/vmtest-fixes-PR | fail | merge-conflict |
On Fri, Sep 20, 2024 at 03:39:03PM +0800, Max Hsu wrote: > Add an entry for the Svukte extension to the riscv,isa-extensions > property. > > Reviewed-by: Samuel Holland <samuel.holland@sifive.com> > Signed-off-by: Max Hsu <max.hsu@sifive.com> > --- > Documentation/devicetree/bindings/riscv/extensions.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml > index a06dbc6b4928958704855c8993291b036e3d1a63..df96aea5e53a70b0cb8905332464a42a264e56e6 100644 > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml > @@ -171,6 +171,13 @@ properties: > memory types as ratified in the 20191213 version of the privileged > ISA specification. > > + - const: svukte > + description: > + The standard Svukte supervisor-level extensions for making user-mode > + accesses to supervisor memory raise page faults in constant time, > + mitigating attacks that attempt to discover the supervisor > + software's address-space layout, as PR#1564 of riscv-isa-manual. I'm surprised this doesn't fail dt_binding_check, with the # in it. I'd like to see a commit hash here though, in the same format as the other extensions using them. > + > - const: zacas > description: | > The Zacas extension for Atomic Compare-and-Swap (CAS) instructions > > -- > 2.43.2 >
Thanks, Conor, I will modify the format and send it as RFC v2. Since the Svukte extension is still in the review stage, I will put the latest commit of the PR in the riscv-isa-manual as an indication, Once the Svukte extension is ratified, I will modify it and send it as a formal patch. Best, Max Hsu On Sun, Sep 22, 2024 at 6:05 AM Conor Dooley <conor@kernel.org> wrote: > > On Fri, Sep 20, 2024 at 03:39:03PM +0800, Max Hsu wrote: > > Add an entry for the Svukte extension to the riscv,isa-extensions > > property. > > > > Reviewed-by: Samuel Holland <samuel.holland@sifive.com> > > Signed-off-by: Max Hsu <max.hsu@sifive.com> > > --- > > Documentation/devicetree/bindings/riscv/extensions.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml > > index a06dbc6b4928958704855c8993291b036e3d1a63..df96aea5e53a70b0cb8905332464a42a264e56e6 100644 > > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml > > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml > > @@ -171,6 +171,13 @@ properties: > > memory types as ratified in the 20191213 version of the privileged > > ISA specification. > > > > + - const: svukte > > + description: > > + The standard Svukte supervisor-level extensions for making user-mode > > + accesses to supervisor memory raise page faults in constant time, > > + mitigating attacks that attempt to discover the supervisor > > + software's address-space layout, as PR#1564 of riscv-isa-manual. > > I'm surprised this doesn't fail dt_binding_check, with the # in it. I'd > like to see a commit hash here though, in the same format as the other > extensions using them. > > > + > > - const: zacas > > description: | > > The Zacas extension for Atomic Compare-and-Swap (CAS) instructions > > > > -- > > 2.43.2 > >
On Fri, Sep 20, 2024 at 03:39:03PM +0800, Max Hsu wrote: >Add an entry for the Svukte extension to the riscv,isa-extensions >property. > >Reviewed-by: Samuel Holland <samuel.holland@sifive.com> >Signed-off-by: Max Hsu <max.hsu@sifive.com> >--- > Documentation/devicetree/bindings/riscv/extensions.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml >index a06dbc6b4928958704855c8993291b036e3d1a63..df96aea5e53a70b0cb8905332464a42a264e56e6 100644 >--- a/Documentation/devicetree/bindings/riscv/extensions.yaml >+++ b/Documentation/devicetree/bindings/riscv/extensions.yaml >@@ -171,6 +171,13 @@ properties: > memory types as ratified in the 20191213 version of the privileged > ISA specification. > >+ - const: svukte >+ description: >+ The standard Svukte supervisor-level extensions for making user-mode >+ accesses to supervisor memory raise page faults in constant time, >+ mitigating attacks that attempt to discover the supervisor >+ software's address-space layout, as PR#1564 of riscv-isa-manual. >+ Reviewed-by: Deepak Gupta <debug@rivosinc.com> > >
Hi Max, On 20/09/2024 09:39, Max Hsu wrote: > Add an entry for the Svukte extension to the riscv,isa-extensions > property. > > Reviewed-by: Samuel Holland <samuel.holland@sifive.com> > Signed-off-by: Max Hsu <max.hsu@sifive.com> > --- > Documentation/devicetree/bindings/riscv/extensions.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml > index a06dbc6b4928958704855c8993291b036e3d1a63..df96aea5e53a70b0cb8905332464a42a264e56e6 100644 > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml > @@ -171,6 +171,13 @@ properties: > memory types as ratified in the 20191213 version of the privileged > ISA specification. > > + - const: svukte > + description: > + The standard Svukte supervisor-level extensions for making user-mode s/extensions/extension > + accesses to supervisor memory raise page faults in constant time, > + mitigating attacks that attempt to discover the supervisor > + software's address-space layout, as PR#1564 of riscv-isa-manual. > + > - const: zacas > description: | > The Zacas extension for Atomic Compare-and-Swap (CAS) instructions > You'll need a new version for the proper commit sha1 once it gets ratified anyway, so with the typo fixed, you can add: Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com> Thanks, Alex
Hi Alexandre, Thanks for the suggestion. I will send a typo fix in the RFC v3 patches Best regards, Max Hsu On Thu, Nov 14, 2024 at 12:15 AM Alexandre Ghiti <alex@ghiti.fr> wrote: > > Hi Max, > > On 20/09/2024 09:39, Max Hsu wrote: > > Add an entry for the Svukte extension to the riscv,isa-extensions > > property. > > > > Reviewed-by: Samuel Holland <samuel.holland@sifive.com> > > Signed-off-by: Max Hsu <max.hsu@sifive.com> > > --- > > Documentation/devicetree/bindings/riscv/extensions.yaml | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml > > index a06dbc6b4928958704855c8993291b036e3d1a63..df96aea5e53a70b0cb8905332464a42a264e56e6 100644 > > --- a/Documentation/devicetree/bindings/riscv/extensions.yaml > > +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml > > @@ -171,6 +171,13 @@ properties: > > memory types as ratified in the 20191213 version of the privileged > > ISA specification. > > > > + - const: svukte > > + description: > > + The standard Svukte supervisor-level extensions for making user-mode > > > s/extensions/extension > > > > + accesses to supervisor memory raise page faults in constant time, > > + mitigating attacks that attempt to discover the supervisor > > + software's address-space layout, as PR#1564 of riscv-isa-manual. > > + > > - const: zacas > > description: | > > The Zacas extension for Atomic Compare-and-Swap (CAS) instructions > > > > You'll need a new version for the proper commit sha1 once it gets > ratified anyway, so with the typo fixed, you can add: > > Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com> > > Thanks, > > Alex >
diff --git a/Documentation/devicetree/bindings/riscv/extensions.yaml b/Documentation/devicetree/bindings/riscv/extensions.yaml index a06dbc6b4928958704855c8993291b036e3d1a63..df96aea5e53a70b0cb8905332464a42a264e56e6 100644 --- a/Documentation/devicetree/bindings/riscv/extensions.yaml +++ b/Documentation/devicetree/bindings/riscv/extensions.yaml @@ -171,6 +171,13 @@ properties: memory types as ratified in the 20191213 version of the privileged ISA specification. + - const: svukte + description: + The standard Svukte supervisor-level extensions for making user-mode + accesses to supervisor memory raise page faults in constant time, + mitigating attacks that attempt to discover the supervisor + software's address-space layout, as PR#1564 of riscv-isa-manual. + - const: zacas description: | The Zacas extension for Atomic Compare-and-Swap (CAS) instructions