| Message ID | 20241018113045.2050295-1-bwawrzyn@cisco.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: cadence: Lower severity of message when phy-names property is absent in DTS | expand |
Hello, > The phy-names property is optional, so the message indicating its absence > during the probe should be of 'info' severity rather than 'error' severity. Applied to controller/cadence, thank you! [01/01] PCI: cadence: Lower severity of message when phy-names property is absent in DTS https://git.kernel.org/pci/pci/c/e3e309b2bea8 Krzysztof
diff --git a/drivers/pci/controller/cadence/pcie-cadence.c b/drivers/pci/controller/cadence/pcie-cadence.c index 4251fac5e310..88122d480432 100644 --- a/drivers/pci/controller/cadence/pcie-cadence.c +++ b/drivers/pci/controller/cadence/pcie-cadence.c @@ -197,7 +197,7 @@ int cdns_pcie_init_phy(struct device *dev, struct cdns_pcie *pcie) phy_count = of_property_count_strings(np, "phy-names"); if (phy_count < 1) { - dev_err(dev, "no phy-names. PHY will not be initialized\n"); + dev_info(dev, "no phy-names. PHY will not be initialized\n"); pcie->phy_count = 0; return 0; }
The phy-names property is optional, so the message indicating its absence during the probe should be of 'info' severity rather than 'error' severity. Signed-off-by: Bartosz Wawrzyniak <bwawrzyn@cisco.com> --- drivers/pci/controller/cadence/pcie-cadence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)