| Message ID | KL1PR06MB6133B5403AA55BC79C13FF3B935B2@KL1PR06MB6133.apcprd06.prod.outlook.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | net: wwan: Add WWAN sahara port type | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Guessing tree name failed - patch did not apply |
Hello Jerry, On 14.11.2024 10:45, Jerry Meng(蒙杰) wrote: > Add a Sahara protocol-based interface for downloading ramdump > from Qualcomm modems in SBL ramdump mode. > > Signed-off-by: Jerry Meng <jerry.meng@quectel.com> > --- > drivers/net/wwan/mhi_wwan_ctrl.c | 3 ++- > drivers/net/wwan/wwan_core.c | 4 ++++ > include/linux/wwan.h | 2 ++ > 3 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c > index e9f979d2d..2c6a754af 100644 > --- a/drivers/net/wwan/mhi_wwan_ctrl.c > +++ b/drivers/net/wwan/mhi_wwan_ctrl.c > @@ -263,7 +263,8 @@ static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = { > { .chan = "QMI", .driver_data = WWAN_PORT_QMI }, > { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM }, > { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE }, > - {}, > + { .chan = "SAHARA", .driver_data = WWAN_PORT_SAHARA}, ^ White space is missed between the port type and '}' -' Please run the checkpatch.pl before submission, and use git-send-email(1) when it is possible. $ ./scripts/checkpatch.pl net-wwan-Add-WWAN-sahara-port-type.patch ... total: 6 errors, 6 warnings, 33 lines check -- Sergey
Hell Jerry, On 14.11.2024 22:16, Sergey Ryazanov wrote: > On 14.11.2024 10:45, Jerry Meng(蒙杰) wrote: >> Add a Sahara protocol-based interface for downloading ramdump >> from Qualcomm modems in SBL ramdump mode. >> >> Signed-off-by: Jerry Meng <jerry.meng@quectel.com> >> --- >> drivers/net/wwan/mhi_wwan_ctrl.c | 3 ++- >> drivers/net/wwan/wwan_core.c | 4 ++++ >> include/linux/wwan.h | 2 ++ >> 3 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/ >> mhi_wwan_ctrl.c >> index e9f979d2d..2c6a754af 100644 >> --- a/drivers/net/wwan/mhi_wwan_ctrl.c >> +++ b/drivers/net/wwan/mhi_wwan_ctrl.c >> @@ -263,7 +263,8 @@ static const struct mhi_device_id >> mhi_wwan_ctrl_match_table[] = { >> { .chan = "QMI", .driver_data = WWAN_PORT_QMI }, >> { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM }, >> { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE }, >> - {}, >> + { .chan = "SAHARA", .driver_data = WWAN_PORT_SAHARA}, > ^ > White space is missed between the port type and '}' -' > > Please run the checkpatch.pl before submission, and use git-send- > email(1) when it is possible. > > > $ ./scripts/checkpatch.pl net-wwan-Add-WWAN-sahara-port-type.patch > ... > total: 6 errors, 6 warnings, 33 lines check One more thing regarding the patch formatting. Just noticed it. A network subsystem patch should indicate the target tree (repository) in the subject, either it should be 'net' or 'net-next'. This patch introduces new functionality, so it should be targeted to 'net-next'. The subject for V2 if you going to send it should be: '[PATCH net-next v2] net: wwan: ...' See the '--subject-prefix' option of git-format-patch(1). -- Sergey
diff --git a/drivers/net/wwan/mhi_wwan_ctrl.c b/drivers/net/wwan/mhi_wwan_ctrl.c index e9f979d2d..2c6a754af 100644 --- a/drivers/net/wwan/mhi_wwan_ctrl.c +++ b/drivers/net/wwan/mhi_wwan_ctrl.c @@ -263,7 +263,8 @@ static const struct mhi_device_id mhi_wwan_ctrl_match_table[] = { { .chan = "QMI", .driver_data = WWAN_PORT_QMI }, { .chan = "DIAG", .driver_data = WWAN_PORT_QCDM }, { .chan = "FIREHOSE", .driver_data = WWAN_PORT_FIREHOSE }, - {}, + { .chan = "SAHARA", .driver_data = WWAN_PORT_SAHARA}, + {}, }; MODULE_DEVICE_TABLE(mhi, mhi_wwan_ctrl_match_table); diff --git a/drivers/net/wwan/wwan_core.c b/drivers/net/wwan/wwan_core.c index a51e27559..d2fe603e6 100644 --- a/drivers/net/wwan/wwan_core.c +++ b/drivers/net/wwan/wwan_core.c @@ -342,6 +342,10 @@ static const struct { .name = "MIPC", .devsuf = "mipc", }, + [WWAN_PORT_SAHARA] = { + .name = "SAHARA", + .devsuf = "sahara", + }, }; static ssize_t type_show(struct device *dev, struct device_attribute *attr, diff --git a/include/linux/wwan.h b/include/linux/wwan.h index 79c781875..b0ea276f2 100644 --- a/include/linux/wwan.h +++ b/include/linux/wwan.h @@ -19,6 +19,7 @@ * @WWAN_PORT_FASTBOOT: Fastboot protocol control * @WWAN_PORT_ADB: ADB protocol control * @WWAN_PORT_MIPC: MTK MIPC diagnostic interface + * @WWAN_PORT_SAHARA: Sahara protocol-based interface for downloading ramdump from Qualcomm modems * * @WWAN_PORT_MAX: Highest supported port types * @WWAN_PORT_UNKNOWN: Special value to indicate an unknown port type @@ -34,6 +35,7 @@ enum wwan_port_type { WWAN_PORT_FASTBOOT, WWAN_PORT_ADB, WWAN_PORT_MIPC, + WWAN_PORT_SAHARA, /* Add new port types above this line */
Add a Sahara protocol-based interface for downloading ramdump from Qualcomm modems in SBL ramdump mode. Signed-off-by: Jerry Meng <jerry.meng@quectel.com> --- drivers/net/wwan/mhi_wwan_ctrl.c | 3 ++- drivers/net/wwan/wwan_core.c | 4 ++++ include/linux/wwan.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-)