| Message ID | 1342593663-23938-1-git-send-email-anilkumar@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote: > Fixes below build error if CONFIG_REGULATOR is not enabled. > > drivers/built-in.o: In function `tps65217_probe': > tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match' This isn't a patch to the regulator driver, this is a patch to the MFD. Normally this would be fixed by making the MFD driver not depend on the regulator API - why is the MFD driver using the regulator API?
Mark, On Wed, Jul 18, 2012 at 15:14:49, Mark Brown wrote: > On Wed, Jul 18, 2012 at 12:11:03PM +0530, AnilKumar Ch wrote: > > Fixes below build error if CONFIG_REGULATOR is not enabled. > > > > drivers/built-in.o: In function `tps65217_probe': > > tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match' > > This isn't a patch to the regulator driver, this is a patch to the MFD. > Normally this would be fixed by making the MFD driver not depend on the > regulator API - why is the MFD driver using the regulator API? > Regulators platform data is added to platform device in MFD driver, which we need for regulator driver, of_regulator_match() is used to check the regulator consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then of_regulator_match() is not exported, so we see this error. Regards AnilKumar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 18, 2012 at 09:55:57AM +0000, AnilKumar, Chimata wrote: > Regulators platform data is added to platform device in MFD driver, which we > need for regulator driver, of_regulator_match() is used to check the regulator > consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then > of_regulator_match() is not exported, so we see this error. Why are you doing that in the MFD driver?
Hi Mark, On Wed, Jul 18, 2012 at 15:30:13, Mark Brown wrote: > On Wed, Jul 18, 2012 at 09:55:57AM +0000, AnilKumar, Chimata wrote: > > > Regulators platform data is added to platform device in MFD driver, which we > > need for regulator driver, of_regulator_match() is used to check the regulator > > consumers if we pass DT data. If we do not enable CONFIG_REGULATOR then > > of_regulator_match() is not exported, so we see this error. > > Why are you doing that in the MFD driver? > I got your point, I referred tps6586x driver while developing the initial driver. Based on tps6586x MFD driver I added REGULATOR flag. I think tps6586x MFD driver need to be cleaned up. I will submit a patch to make tps65217 MFD driver independent of REGULATOR framework. Thanks AnilKumar-- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index e129c82..01c929a 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -159,6 +159,7 @@ config TPS6507X config MFD_TPS65217 tristate "TPS65217 Power Management / White LED chips" depends on I2C + depends on REGULATOR select MFD_CORE select REGMAP_I2C help
Fixes below build error if CONFIG_REGULATOR is not enabled. drivers/built-in.o: In function `tps65217_probe': tps65217.c:(.devinit.text+0x13e37): undefined reference to `of_regulator_match' Signed-off-by: AnilKumar Ch <anilkumar@ti.com> --- drivers/mfd/Kconfig | 1 + 1 file changed, 1 insertion(+)