| Message ID | 20241114120455.5413-4-divya.koppera@microchip.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add ptp library for Microchip phys | expand |
On 14/11/2024 12:04, Divya Koppera wrote: > Add ptp library support in Kconfig > As some of Microchip T1 phys support ptp, add dependency > of 1588 optional flag in Kconfig > > Signed-off-by: Divya Koppera <divya.koppera@microchip.com> > --- > v1 -> v2 -> v3 -> v4 > - No changes > --- Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
On Thu, 14 Nov 2024 17:34:53 +0530 Divya Koppera wrote: > config MICROCHIP_T1_PHY > tristate "Microchip T1 PHYs" > + select MICROCHIP_PHYPTP if NETWORK_PHY_TIMESTAMPING > + depends on PTP_1588_CLOCK_OPTIONAL I presume the dependency is because select doesn't obey dependencies, but you only select PHYPTP if NETWORK_PHY_TIMESTAMPING. Maybe it's possible to create a intermediate meta-symbol which is NETWORK_PHY_TIMESTAMPING && PTP_1588_CLOCK_OPTIONAL and use that in the select.. if ... clause? > + help > + Supports the LAN8XXX PHYs. > + > +config MICROCHIP_PHYPTP > + tristate "Microchip PHY PTP" > help nit: tabs vs spaces > - Supports the LAN87XX PHYs. > + Currently supports LAN887X T1 PHY This Kconfig is likely unsafe. You have to make sure PHYPTP is not a module when T1_PHY is built in.
Hi Jakub, > -----Original Message----- > From: Jakub Kicinski <kuba@kernel.org> > Sent: Saturday, November 16, 2024 6:07 AM > To: Divya Koppera - I30481 <Divya.Koppera@microchip.com> > Cc: andrew@lunn.ch; Arun Ramadoss - I17769 > <Arun.Ramadoss@microchip.com>; UNGLinuxDriver > <UNGLinuxDriver@microchip.com>; hkallweit1@gmail.com; > linux@armlinux.org.uk; davem@davemloft.net; edumazet@google.com; > pabeni@redhat.com; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; > richardcochran@gmail.com; vadim.fedorenko@linux.dev > Subject: Re: [PATCH net-next v4 3/5] net: phy: Kconfig: Add ptp library > support and 1588 optional flag in Microchip phys > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Thu, 14 Nov 2024 17:34:53 +0530 Divya Koppera wrote: > > config MICROCHIP_T1_PHY > > tristate "Microchip T1 PHYs" > > + select MICROCHIP_PHYPTP if NETWORK_PHY_TIMESTAMPING > > + depends on PTP_1588_CLOCK_OPTIONAL > > I presume the dependency is because select doesn't obey dependencies, but > you only select PHYPTP if NETWORK_PHY_TIMESTAMPING. > Maybe it's possible to create a intermediate meta-symbol which is > NETWORK_PHY_TIMESTAMPING && PTP_1588_CLOCK_OPTIONAL and use > that in the select.. if ... clause? > This way is not harmful as it is clock optional. Suggestion is good as it will be more efficient. Will apply this in next revision. > > + help > > + Supports the LAN8XXX PHYs. > > + > > +config MICROCHIP_PHYPTP > > + tristate "Microchip PHY PTP" > > help > > nit: tabs vs spaces > Oh.. This didn't caught in check patch. Will change in next revision. > > - Supports the LAN87XX PHYs. > > + Currently supports LAN887X T1 PHY > > This Kconfig is likely unsafe. > You have to make sure PHYPTP is not a module when T1_PHY is built in. I tried changing options in make menuconfig, PHYPTP takes the option from T1_PHY. If T1_PHY chosen m or y, PHYPTP takes m or y accordingly. Also tried modifying .config with t1_phy as y and PHYPTP as m, it automates and changed PHYPTP to y. Thanks, Divya > -- > pw-bot: cr
diff --git a/drivers/net/phy/Kconfig b/drivers/net/phy/Kconfig index 15828f4710a9..efa027b2bf69 100644 --- a/drivers/net/phy/Kconfig +++ b/drivers/net/phy/Kconfig @@ -287,8 +287,15 @@ config MICROCHIP_PHY config MICROCHIP_T1_PHY tristate "Microchip T1 PHYs" + select MICROCHIP_PHYPTP if NETWORK_PHY_TIMESTAMPING + depends on PTP_1588_CLOCK_OPTIONAL + help + Supports the LAN8XXX PHYs. + +config MICROCHIP_PHYPTP + tristate "Microchip PHY PTP" help - Supports the LAN87XX PHYs. + Currently supports LAN887X T1 PHY config MICROSEMI_PHY tristate "Microsemi PHYs"
Add ptp library support in Kconfig As some of Microchip T1 phys support ptp, add dependency of 1588 optional flag in Kconfig Signed-off-by: Divya Koppera <divya.koppera@microchip.com> --- v1 -> v2 -> v3 -> v4 - No changes --- drivers/net/phy/Kconfig | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-)