| Message ID | 20241112012928.102478-1-xuanzhuo@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | virtio-net: support AF_XDP zero copy (tx) | expand |
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 12 Nov 2024 09:29:15 +0800 you wrote: > v4: > 1. rebase net-next > 2. update the kdoc for the new APIs > > v3: > 1. use sg_dma_address/length api to set the premapped sg > 2. remove 'premapped' parameter from the new APIs > 3. tweak the comment of commit #2,#3 > > [...] Here is the summary with links: - [net-next,v4,01/13] virtio_ring: introduce vring_need_unmap_buffer https://git.kernel.org/netdev/net-next/c/9f19c084057a - [net-next,v4,02/13] virtio_ring: split: record extras for indirect buffers https://git.kernel.org/netdev/net-next/c/bc2b4c3401c6 - [net-next,v4,03/13] virtio_ring: packed: record extras for indirect buffers https://git.kernel.org/netdev/net-next/c/aaa789843a93 - [net-next,v4,04/13] virtio_ring: perform premapped operations based on per-buffer https://git.kernel.org/netdev/net-next/c/c7e1b422afac - [net-next,v4,05/13] virtio_ring: introduce add api for premapped https://git.kernel.org/netdev/net-next/c/3ef66af31fea - [net-next,v4,06/13] virtio-net: rq submits premapped per-buffer https://git.kernel.org/netdev/net-next/c/31f3cd4e5756 - [net-next,v4,07/13] virtio_ring: remove API virtqueue_set_dma_premapped https://git.kernel.org/netdev/net-next/c/880ebcbe0663 - [net-next,v4,08/13] virtio_net: refactor the xmit type https://git.kernel.org/netdev/net-next/c/7db956707f5f - [net-next,v4,09/13] virtio_net: xsk: bind/unbind xsk for tx https://git.kernel.org/netdev/net-next/c/21a4e3ce6dc7 - [net-next,v4,10/13] virtio_net: xsk: prevent disable tx napi https://git.kernel.org/netdev/net-next/c/1df5116a41a8 - [net-next,v4,11/13] virtio_net: xsk: tx: support xmit xsk buffer https://git.kernel.org/netdev/net-next/c/89f86675cb03 - [net-next,v4,12/13] virtio_net: update tx timeout record https://git.kernel.org/netdev/net-next/c/e2c5c57f1af8 - [net-next,v4,13/13] virtio_net: xdp_features add NETDEV_XDP_ACT_XSK_ZEROCOPY https://git.kernel.org/netdev/net-next/c/37e0ca657a3d You are awesome, thank you!
v4: 1. rebase net-next 2. update the kdoc for the new APIs v3: 1. use sg_dma_address/length api to set the premapped sg 2. remove 'premapped' parameter from the new APIs 3. tweak the comment of commit #2,#3 v2: 1. use new api to submit premapped buffer instead of using sgs to pass this info 2. some small fixes for http://lore.kernel.org/all/20240924013204.13763-1-xuanzhuo@linux.alibaba.com v1: 1. some small fixes for http://lore.kernel.org/all/20240820073330.9161-1-xuanzhuo@linux.alibaba.com 1. fix the title of the commit #2, #3 2. fix the gcc error for commit #3 3. use virtqueue_dma_xxxx for tx hdr 4. rename virtnet_ptr_to_xsk to virtnet_ptr_to_xsk_buff_len 5. squash #11 in last patch set to #10 ================================================================================ ## AF_XDP XDP socket(AF_XDP) is an excellent bypass kernel network framework. The zero copy feature of xsk (XDP socket) needs to be supported by the driver. The performance of zero copy is very good. mlx5 and intel ixgbe already support this feature, This patch set allows virtio-net to support xsk's zerocopy xmit feature. At present, we have completed some preparation: 1. vq-reset (virtio spec and kernel code) 2. virtio-core premapped dma 3. virtio-net xdp refactor So it is time for Virtio-Net to complete the support for the XDP Socket Zerocopy. Virtio-net can not increase the queue num at will, so xsk shares the queue with kernel. This patch set includes some refactor to the virtio-net to let that to support AF_XDP. ## About virtio premapped mode The current configuration sets the virtqueue (vq) to premapped mode, implying that all buffers submitted to this queue must be mapped ahead of time. This presents a challenge for the virtnet send queue (sq): the virtnet driver would be required to keep track of dma information for vq size * 17, which can be substantial. However, if the premapped mode were applied on a per-buffer basis, the complexity would be greatly reduced. With AF_XDP enabled, AF_XDP buffers would become premapped, while kernel skb buffers could remain unmapped. We can distinguish them by sg_page(sg), When sg_page(sg) is NULL, this indicates that the driver has performed DMA mapping in advance, allowing the Virtio core to directly utilize sg_dma_address(sg) without conducting any internal DMA mapping. Additionally, DMA unmap operations for this buffer will be bypassed. ## performance ENV: Qemu with vhost-user(polling mode). Host CPU: Intel(R) Xeon(R) Platinum 8163 CPU @ 2.50GHz ### virtio PMD in guest with testpmd testpmd> show port stats all ######################## NIC statistics for port 0 ######################## RX-packets: 19531092064 RX-missed: 0 RX-bytes: 1093741155584 RX-errors: 0 RX-nombuf: 0 TX-packets: 5959955552 TX-errors: 0 TX-bytes: 371030645664 Throughput (since last show) Rx-pps: 8861574 Rx-bps: 3969985208 Tx-pps: 8861493 Tx-bps: 3969962736 ############################################################################ ### AF_XDP PMD in guest with testpmd testpmd> show port stats all ######################## NIC statistics for port 0 ######################## RX-packets: 68152727 RX-missed: 0 RX-bytes: 3816552712 RX-errors: 0 RX-nombuf: 0 TX-packets: 68114967 TX-errors: 33216 TX-bytes: 3814438152 Throughput (since last show) Rx-pps: 6333196 Rx-bps: 2837272088 Tx-pps: 6333227 Tx-bps: 2837285936 ############################################################################ But AF_XDP consumes more CPU for tx and rx napi(100% and 86%). Please review. Thanks. Xuan Zhuo (13): virtio_ring: introduce vring_need_unmap_buffer virtio_ring: split: record extras for indirect buffers virtio_ring: packed: record extras for indirect buffers virtio_ring: perform premapped operations based on per-buffer virtio_ring: introduce add api for premapped virtio-net: rq submits premapped per-buffer virtio_ring: remove API virtqueue_set_dma_premapped virtio_net: refactor the xmit type virtio_net: xsk: bind/unbind xsk for tx virtio_net: xsk: prevent disable tx napi virtio_net: xsk: tx: support xmit xsk buffer virtio_net: update tx timeout record virtio_net: xdp_features add NETDEV_XDP_ACT_XSK_ZEROCOPY drivers/net/virtio_net.c | 369 ++++++++++++++++++++++++++++------- drivers/virtio/virtio_ring.c | 356 ++++++++++++++++----------------- include/linux/virtio.h | 13 +- 3 files changed, 489 insertions(+), 249 deletions(-) -- 2.32.0.3.g01195cf9f