| Message ID | 20241104190714.275977-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | PCI: dwc: Use of_property_present() for non-boolean properties | expand |
Hello, > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. Applied to controller/dwc, thank you! [01/01] PCI: dwc: Use of_property_present() for non-boolean properties https://git.kernel.org/pci/pci/c/6734997ebd6e Krzysztof
On Mon, Nov 04, 2024 at 01:07:13PM -0600, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/pci/controller/dwc/pcie-designware-host.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c > index 3e41865c7290..d2291c3ceb8b 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-host.c > +++ b/drivers/pci/controller/dwc/pcie-designware-host.c > @@ -474,8 +474,8 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) > > if (pci_msi_enabled()) { > pp->has_msi_ctrl = !(pp->ops->msi_init || > - of_property_read_bool(np, "msi-parent") || > - of_property_read_bool(np, "msi-map")); > + of_property_present(np, "msi-parent") || > + of_property_present(np, "msi-map")); > > /* > * For the has_msi_ctrl case the default assignment is handled > -- > 2.45.2 >
Hello, > > The use of of_property_read_bool() for non-boolean properties is > > deprecated in favor of of_property_present() when testing for property > > presence. > > > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Picked this tag, too. Thank you! Krzysztof
diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c index 3e41865c7290..d2291c3ceb8b 100644 --- a/drivers/pci/controller/dwc/pcie-designware-host.c +++ b/drivers/pci/controller/dwc/pcie-designware-host.c @@ -474,8 +474,8 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp) if (pci_msi_enabled()) { pp->has_msi_ctrl = !(pp->ops->msi_init || - of_property_read_bool(np, "msi-parent") || - of_property_read_bool(np, "msi-map")); + of_property_present(np, "msi-parent") || + of_property_present(np, "msi-map")); /* * For the has_msi_ctrl case the default assignment is handled
The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/pci/controller/dwc/pcie-designware-host.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)