| Message ID | 20241115-converge-secs-to-jiffies-v2-1-911fb7595e79@linux.microsoft.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Converge on using secs_to_jiffies() | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/SubjectPrefix | fail | "Bluetooth: " prefix is not specified in the subject |
| tedd_an/BuildKernel | fail | BuildKernel: FAIL: net/bluetooth/mgmt.c: In function ‘enable_service_cache’: net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration] 213 | #define CACHE_TIMEOUT secs_to_jiffies(2) | ^~~~~~~~~~~~~~~ net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’ 2699 | CACHE_TIMEOUT); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:478: net] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2 make: *** [Makefile:224: __sub-make] Error 2 |
| tedd_an/CheckAllWarning | fail | CheckAllWarning: FAIL: net/bluetooth/mgmt.c: In function ‘enable_service_cache’: net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration] 213 | #define CACHE_TIMEOUT secs_to_jiffies(2) | ^~~~~~~~~~~~~~~ net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’ 2699 | CACHE_TIMEOUT); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:478: net] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2 make: *** [Makefile:224: __sub-make] Error 2 |
| tedd_an/CheckSparse | fail | CheckSparse: FAIL: net/bluetooth/af_bluetooth.c:245:25: warning: context imbalance in 'bt_accept_enqueue' - different lock contexts for basic block net/bluetooth/mgmt.c: In function ‘enable_service_cache’: net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration] 213 | #define CACHE_TIMEOUT secs_to_jiffies(2) | ^~~~~~~~~~~~~~~ net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’ 2699 | CACHE_TIMEOUT); | ^~~~~~~~~~~~~ drivers/bluetooth/hci_ag6xx.c:257:24: warning: restricted __le32 degrades to integer net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h): ./include/net/bluetooth/hci.h:2616:47: warning: array of flexible structures ./include/net/bluetooth/hci.h:2702:43: warning: array of flexible structures drivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integer drivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integer cc1: some warnings being treated as errors make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:478: net] Error 2 make[2]: *** Waiting for unfinished jobs.... drivers/bluetooth/hci_nokia.c:279:23: warning: incorrect type in assignment (different base types) drivers/bluetooth/hci_nokia.c:279:23: expected unsigned short [usertype] baud drivers/bluetooth/hci_nokia.c:279:23: got restricted __le16 [usertype] drivers/bluetooth/hci_nokia.c:282:26: warning: incorrect type in assignment (different base types) drivers/bluetooth/hci_nokia.c:282:26: expected unsigned short [usertype] sys_clk drivers/bluetooth/hci_nokia.c:282:26: got restricted __le16 [usertype] make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2 make: *** [Makefile:224: __sub-make] Error 2 |
| tedd_an/BuildKernel32 | fail | BuildKernel32: FAIL: net/bluetooth/mgmt.c: In function ‘enable_service_cache’: net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration] 213 | #define CACHE_TIMEOUT secs_to_jiffies(2) | ^~~~~~~~~~~~~~~ net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’ 2699 | CACHE_TIMEOUT); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:478: net] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2 make: *** [Makefile:224: __sub-make] Error 2 |
| tedd_an/TestRunnerSetup | fail | Kernel Build FAIL: net/bluetooth/mgmt.c: In function ‘enable_service_cache’: net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration] 213 | #define CACHE_TIMEOUT secs_to_jiffies(2) | ^~~~~~~~~~~~~~~ net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’ 2699 | CACHE_TIMEOUT); | ^~~~~~~~~~~~~ cc1: some warnings being treated as errors make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1 make[4]: *** Waiting for unfinished jobs.... make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:478: net] Error 2 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2 make: *** [Makefile:224: __sub-make] Error 2 |
| tedd_an/TestRunner_l2cap-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_iso-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_bnep-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_mgmt-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_rfcomm-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_sco-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_ioctl-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_mesh-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_smp-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
| tedd_an/TestRunner_userchan-tester | fail | Could not access KVM kernel module: No such file or directory qemu-system-x86_64: failed to initialize KVM: No such file or directory qemu-system-x86_64: Back to tcg accelerator qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=910176
---Test result---
Test Summary:
CheckPatch PENDING 0.28 seconds
GitLint PENDING 0.24 seconds
SubjectPrefix FAIL 2.72 seconds
BuildKernel FAIL 21.58 seconds
CheckAllWarning FAIL 22.48 seconds
CheckSparse FAIL 24.80 seconds
BuildKernel32 FAIL 21.51 seconds
TestRunnerSetup FAIL 423.05 seconds
TestRunner_l2cap-tester FAIL 0.14 seconds
TestRunner_iso-tester FAIL 0.14 seconds
TestRunner_bnep-tester FAIL 0.32 seconds
TestRunner_mgmt-tester FAIL 0.14 seconds
TestRunner_rfcomm-tester FAIL 0.17 seconds
TestRunner_sco-tester FAIL 0.14 seconds
TestRunner_ioctl-tester FAIL 0.14 seconds
TestRunner_mesh-tester FAIL 0.14 seconds
TestRunner_smp-tester FAIL 0.14 seconds
TestRunner_userchan-tester FAIL 1.50 seconds
IncrementalBuild PENDING 0.46 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
##############################
Test: BuildKernel - FAIL
Desc: Build Kernel for Bluetooth
Output:
net/bluetooth/mgmt.c: In function ‘enable_service_cache’:
net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration]
213 | #define CACHE_TIMEOUT secs_to_jiffies(2)
| ^~~~~~~~~~~~~~~
net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’
2699 | CACHE_TIMEOUT);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:478: net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2
make: *** [Makefile:224: __sub-make] Error 2
##############################
Test: CheckAllWarning - FAIL
Desc: Run linux kernel with all warning enabled
Output:
net/bluetooth/mgmt.c: In function ‘enable_service_cache’:
net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration]
213 | #define CACHE_TIMEOUT secs_to_jiffies(2)
| ^~~~~~~~~~~~~~~
net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’
2699 | CACHE_TIMEOUT);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:478: net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2
make: *** [Makefile:224: __sub-make] Error 2
##############################
Test: CheckSparse - FAIL
Desc: Run sparse tool with linux kernel
Output:
net/bluetooth/af_bluetooth.c:245:25: warning: context imbalance in 'bt_accept_enqueue' - different lock contexts for basic block
net/bluetooth/mgmt.c: In function ‘enable_service_cache’:
net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration]
213 | #define CACHE_TIMEOUT secs_to_jiffies(2)
| ^~~~~~~~~~~~~~~
net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’
2699 | CACHE_TIMEOUT);
| ^~~~~~~~~~~~~
drivers/bluetooth/hci_ag6xx.c:257:24: warning: restricted __le32 degrades to integer
net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h):
./include/net/bluetooth/hci.h:2616:47: warning: array of flexible structures
./include/net/bluetooth/hci.h:2702:43: warning: array of flexible structures
drivers/bluetooth/hci_mrvl.c:170:23: warning: restricted __le16 degrades to integer
drivers/bluetooth/hci_mrvl.c:203:23: warning: restricted __le16 degrades to integer
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:478: net] Error 2
make[2]: *** Waiting for unfinished jobs....
drivers/bluetooth/hci_nokia.c:279:23: warning: incorrect type in assignment (different base types)
drivers/bluetooth/hci_nokia.c:279:23: expected unsigned short [usertype] baud
drivers/bluetooth/hci_nokia.c:279:23: got restricted __le16 [usertype]
drivers/bluetooth/hci_nokia.c:282:26: warning: incorrect type in assignment (different base types)
drivers/bluetooth/hci_nokia.c:282:26: expected unsigned short [usertype] sys_clk
drivers/bluetooth/hci_nokia.c:282:26: got restricted __le16 [usertype]
make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2
make: *** [Makefile:224: __sub-make] Error 2
##############################
Test: BuildKernel32 - FAIL
Desc: Build 32bit Kernel for Bluetooth
Output:
net/bluetooth/mgmt.c: In function ‘enable_service_cache’:
net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration]
213 | #define CACHE_TIMEOUT secs_to_jiffies(2)
| ^~~~~~~~~~~~~~~
net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’
2699 | CACHE_TIMEOUT);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:478: net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2
make: *** [Makefile:224: __sub-make] Error 2
##############################
Test: TestRunnerSetup - FAIL
Desc: Setup kernel and bluez for test-runner
Output:
Kernel:
net/bluetooth/mgmt.c: In function ‘enable_service_cache’:
net/bluetooth/mgmt.c:213:23: error: implicit declaration of function ‘secs_to_jiffies’; did you mean ‘nsecs_to_jiffies’? [-Werror=implicit-function-declaration]
213 | #define CACHE_TIMEOUT secs_to_jiffies(2)
| ^~~~~~~~~~~~~~~
net/bluetooth/mgmt.c:2699:8: note: in expansion of macro ‘CACHE_TIMEOUT’
2699 | CACHE_TIMEOUT);
| ^~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[4]: *** [scripts/Makefile.build:229: net/bluetooth/mgmt.o] Error 1
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:478: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:478: net] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/github/workspace/src/src/Makefile:1936: .] Error 2
make: *** [Makefile:224: __sub-make] Error 2
##############################
Test: TestRunner_l2cap-tester - FAIL
Desc: Run l2cap-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_bnep-tester - FAIL
Desc: Run bnep-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_rfcomm-tester - FAIL
Desc: Run rfcomm-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_sco-tester - FAIL
Desc: Run sco-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_ioctl-tester - FAIL
Desc: Run ioctl-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_mesh-tester - FAIL
Desc: Run mesh-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_smp-tester - FAIL
Desc: Run smp-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: TestRunner_userchan-tester - FAIL
Desc: Run userchan-tester with test-runner
Output:
Could not access KVM kernel module: No such file or directory
qemu-system-x86_64: failed to initialize KVM: No such file or directory
qemu-system-x86_64: Back to tcg accelerator
qemu: could not open kernel file '/github/workspace/src/src/arch/x86/boot/bzImage': No such file or directory
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
Hi Easwar, On Fri, 15 Nov 2024 21:26:18 +0000 Easwar Hariharan <eahariha@linux.microsoft.com> wrote: > > static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { > - [SCTP_CONNTRACK_CLOSED] = 10 SECS, > - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, > - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, > - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, > - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, > + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), > + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), > + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), You have changed this last timeout from 30 seconds to 3 (presumably just a copy and paste error).
On 11/15/2024 2:34 PM, Stephen Rothwell wrote: > Hi Easwar, > > On Fri, 15 Nov 2024 21:26:18 +0000 Easwar Hariharan <eahariha@linux.microsoft.com> wrote: >> >> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { >> - [SCTP_CONNTRACK_CLOSED] = 10 SECS, >> - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, >> - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, >> - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, >> + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), >> + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), >> + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), > > You have changed this last timeout from 30 seconds to 3 (presumably > just a copy and paste error). > Will fix in v3.
Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > [Vous ne recevez pas souvent de courriers de eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] > > None of the higher order definitions are used anymore, so remove > definitions for minutes, hours, and days timeouts. Convert the seconds > denominated timeouts to secs_to_jiffies() There is very similar things with tcp_timeouts[] in nf_conntrack_proto_tcp.c, why not convert it as well ? > > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > --- > net/netfilter/nf_conntrack_proto_sctp.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) > > diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c > index 4cc97f971264ed779434ab4597dd0162586b3736..6c95ac96fa42a39acafb5b88a7cf8898010e911c 100644 > --- a/net/netfilter/nf_conntrack_proto_sctp.c > +++ b/net/netfilter/nf_conntrack_proto_sctp.c > @@ -39,20 +39,15 @@ static const char *const sctp_conntrack_names[] = { > [SCTP_CONNTRACK_HEARTBEAT_SENT] = "HEARTBEAT_SENT", > }; > > -#define SECS * HZ > -#define MINS * 60 SECS > -#define HOURS * 60 MINS > -#define DAYS * 24 HOURS > - > static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { > - [SCTP_CONNTRACK_CLOSED] = 10 SECS, > - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, > - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, > - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, > - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, > + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), > + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), > + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), > + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), Was 30 before, if you think it must be changed to 3 you must explain it in the commit message, or maybe do another patch for that change. > }; > > #define SCTP_FLAG_HEARTBEAT_VTAG_FAILED 1 > > -- > 2.34.1 > Christophe
On 11/16/2024 1:40 AM, Christophe Leroy wrote: > > > Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : >> [Vous ne recevez pas souvent de courriers de >> eahariha@linux.microsoft.com. Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> None of the higher order definitions are used anymore, so remove >> definitions for minutes, hours, and days timeouts. Convert the seconds >> denominated timeouts to secs_to_jiffies() > > There is very similar things with tcp_timeouts[] in > nf_conntrack_proto_tcp.c, why not convert it as well ? This patch happens to have been hand-modified and not by Coccinelle. I'll consider tcp_timeouts[] for v3, but that actually seems to have minute, hour, and days denominated timeouts, and replacing the 4 SECS timeouts may actually hinder readability in that file. > >> >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> >> --- >> net/netfilter/nf_conntrack_proto_sctp.c | 21 ++++++++------------- >> 1 file changed, 8 insertions(+), 13 deletions(-) >> >> diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/ >> nf_conntrack_proto_sctp.c >> index >> 4cc97f971264ed779434ab4597dd0162586b3736..6c95ac96fa42a39acafb5b88a7cf8898010e911c 100644 >> --- a/net/netfilter/nf_conntrack_proto_sctp.c >> +++ b/net/netfilter/nf_conntrack_proto_sctp.c >> @@ -39,20 +39,15 @@ static const char *const sctp_conntrack_names[] = { >> [SCTP_CONNTRACK_HEARTBEAT_SENT] = "HEARTBEAT_SENT", >> }; >> >> -#define SECS * HZ >> -#define MINS * 60 SECS >> -#define HOURS * 60 MINS >> -#define DAYS * 24 HOURS >> - >> static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { >> - [SCTP_CONNTRACK_CLOSED] = 10 SECS, >> - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, >> - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, >> - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, >> - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, >> - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, >> + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), >> + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), >> + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), >> + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), > > Was 30 before, if you think it must be changed to 3 you must explain it > in the commit message, or maybe do another patch for that change. This one's a typo, I'll fix it in v3. Thanks, Easwar
diff --git a/net/netfilter/nf_conntrack_proto_sctp.c b/net/netfilter/nf_conntrack_proto_sctp.c index 4cc97f971264ed779434ab4597dd0162586b3736..6c95ac96fa42a39acafb5b88a7cf8898010e911c 100644 --- a/net/netfilter/nf_conntrack_proto_sctp.c +++ b/net/netfilter/nf_conntrack_proto_sctp.c @@ -39,20 +39,15 @@ static const char *const sctp_conntrack_names[] = { [SCTP_CONNTRACK_HEARTBEAT_SENT] = "HEARTBEAT_SENT", }; -#define SECS * HZ -#define MINS * 60 SECS -#define HOURS * 60 MINS -#define DAYS * 24 HOURS - static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] = { - [SCTP_CONNTRACK_CLOSED] = 10 SECS, - [SCTP_CONNTRACK_COOKIE_WAIT] = 3 SECS, - [SCTP_CONNTRACK_COOKIE_ECHOED] = 3 SECS, - [SCTP_CONNTRACK_ESTABLISHED] = 210 SECS, - [SCTP_CONNTRACK_SHUTDOWN_SENT] = 3 SECS, - [SCTP_CONNTRACK_SHUTDOWN_RECD] = 3 SECS, - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = 3 SECS, - [SCTP_CONNTRACK_HEARTBEAT_SENT] = 30 SECS, + [SCTP_CONNTRACK_CLOSED] = secs_to_jiffies(10), + [SCTP_CONNTRACK_COOKIE_WAIT] = secs_to_jiffies(3), + [SCTP_CONNTRACK_COOKIE_ECHOED] = secs_to_jiffies(3), + [SCTP_CONNTRACK_ESTABLISHED] = secs_to_jiffies(210), + [SCTP_CONNTRACK_SHUTDOWN_SENT] = secs_to_jiffies(3), + [SCTP_CONNTRACK_SHUTDOWN_RECD] = secs_to_jiffies(3), + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] = secs_to_jiffies(3), + [SCTP_CONNTRACK_HEARTBEAT_SENT] = secs_to_jiffies(3), }; #define SCTP_FLAG_HEARTBEAT_VTAG_FAILED 1
None of the higher order definitions are used anymore, so remove definitions for minutes, hours, and days timeouts. Convert the seconds denominated timeouts to secs_to_jiffies() Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> --- net/netfilter/nf_conntrack_proto_sctp.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-)