| Message ID | 20241118202011.1115968-1-smayhew@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [nfs-utils] nfsd: dump default number of threads to 16 | expand |
Subject line should say "bump", not "dump". -Scott On Mon, 18 Nov 2024, Scott Mayhew wrote: > nfsdctl defaults to 16 threads. Since the nfs-server.service file first > tries nfsdctl and then falls back to rpc.nfsd, it would probably be wise > to make the default in rpc.nfsd and nfs.conf 16, for the sake of > consistency and to avoid surprises. > > Signed-off-by: Scott Mayhew <smayhew@redhat.com> > --- > nfs.conf | 2 +- > utils/nfsd/nfsd.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/nfs.conf b/nfs.conf > index 23b5f7d4..087d7372 100644 > --- a/nfs.conf > +++ b/nfs.conf > @@ -66,7 +66,7 @@ > # > [nfsd] > # debug=0 > -# threads=8 > +# threads=16 > # host= > # port=0 > # grace-time=90 > diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c > index 249df00b..f787583e 100644 > --- a/utils/nfsd/nfsd.c > +++ b/utils/nfsd/nfsd.c > @@ -32,7 +32,7 @@ > #include "xcommon.h" > > #ifndef NFSD_NPROC > -#define NFSD_NPROC 8 > +#define NFSD_NPROC 16 > #endif > > static void usage(const char *); > -- > 2.46.2 > >
On Mon, 2024-11-18 at 15:20 -0500, Scott Mayhew wrote: > nfsdctl defaults to 16 threads. Since the nfs-server.service file first > tries nfsdctl and then falls back to rpc.nfsd, it would probably be wise > to make the default in rpc.nfsd and nfs.conf 16, for the sake of > consistency and to avoid surprises. > > Signed-off-by: Scott Mayhew <smayhew@redhat.com> > --- > nfs.conf | 2 +- > utils/nfsd/nfsd.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/nfs.conf b/nfs.conf > index 23b5f7d4..087d7372 100644 > --- a/nfs.conf > +++ b/nfs.conf > @@ -66,7 +66,7 @@ > # > [nfsd] > # debug=0 > -# threads=8 > +# threads=16 > # host= > # port=0 > # grace-time=90 > diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c > index 249df00b..f787583e 100644 > --- a/utils/nfsd/nfsd.c > +++ b/utils/nfsd/nfsd.c > @@ -32,7 +32,7 @@ > #include "xcommon.h" > > #ifndef NFSD_NPROC > -#define NFSD_NPROC 8 > +#define NFSD_NPROC 16 > #endif > > static void usage(const char *); I sort of consider rpc.nfsd to be legacy code and think we shouldn't touch it, but I don't have a strong technical reason to oppose this. I'm fine with this if it's the consensus. Acked-by: Jeff Layton <jlayton@kernel.org>
On 11/18/24 3:20 PM, Scott Mayhew wrote: > nfsdctl defaults to 16 threads. Since the nfs-server.service file first > tries nfsdctl and then falls back to rpc.nfsd, it would probably be wise > to make the default in rpc.nfsd and nfs.conf 16, for the sake of > consistency and to avoid surprises. > > Signed-off-by: Scott Mayhew <smayhew@redhat.com> Committed... (tag: nfs-utils-2-8-2-rc3) steved. > --- > nfs.conf | 2 +- > utils/nfsd/nfsd.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/nfs.conf b/nfs.conf > index 23b5f7d4..087d7372 100644 > --- a/nfs.conf > +++ b/nfs.conf > @@ -66,7 +66,7 @@ > # > [nfsd] > # debug=0 > -# threads=8 > +# threads=16 > # host= > # port=0 > # grace-time=90 > diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c > index 249df00b..f787583e 100644 > --- a/utils/nfsd/nfsd.c > +++ b/utils/nfsd/nfsd.c > @@ -32,7 +32,7 @@ > #include "xcommon.h" > > #ifndef NFSD_NPROC > -#define NFSD_NPROC 8 > +#define NFSD_NPROC 16 > #endif > > static void usage(const char *);
diff --git a/nfs.conf b/nfs.conf index 23b5f7d4..087d7372 100644 --- a/nfs.conf +++ b/nfs.conf @@ -66,7 +66,7 @@ # [nfsd] # debug=0 -# threads=8 +# threads=16 # host= # port=0 # grace-time=90 diff --git a/utils/nfsd/nfsd.c b/utils/nfsd/nfsd.c index 249df00b..f787583e 100644 --- a/utils/nfsd/nfsd.c +++ b/utils/nfsd/nfsd.c @@ -32,7 +32,7 @@ #include "xcommon.h" #ifndef NFSD_NPROC -#define NFSD_NPROC 8 +#define NFSD_NPROC 16 #endif static void usage(const char *);
nfsdctl defaults to 16 threads. Since the nfs-server.service file first tries nfsdctl and then falls back to rpc.nfsd, it would probably be wise to make the default in rpc.nfsd and nfs.conf 16, for the sake of consistency and to avoid surprises. Signed-off-by: Scott Mayhew <smayhew@redhat.com> --- nfs.conf | 2 +- utils/nfsd/nfsd.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)