diff mbox series

[v2,1/6] dt-bindings: arm: qcom: Document sm8750 SoC and boards

Message ID 20241112004936.2810509-2-quic_molvera@quicinc.com (mailing list archive)
State New
Headers show
Series dts: qcom: Introduce SM8750 device trees | expand

Commit Message

Melody Olvera Nov. 12, 2024, 12:49 a.m. UTC 
Document the SM8750 SoC binding and the boards which use it.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Dmitry Baryshkov Nov. 15, 2024, 2:49 p.m. UTC | #1 
On Mon, Nov 11, 2024 at 04:49:31PM -0800, Melody Olvera wrote:
> Document the SM8750 SoC binding and the boards which use it.

Nit: In subject you have 'sm8750'. Please use single style for all SoC
names (I think it's preferred to use uppercase).

> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 7c8c3a97506a..f4e8f8821405 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -86,6 +86,7 @@ description: |
>          sm8450
>          sm8550
>          sm8650
> +        sm8750
>          x1e80100
>  
>    There are many devices in the list below that run the standard ChromeOS
> @@ -1077,6 +1078,12 @@ properties:
>                - qcom,sm8650-qrd
>            - const: qcom,sm8650
>  
> +      - items:
> +          - enum:
> +              - qcom,sm8750-mtp
> +              - qcom,sm8750-qrd
> +          - const: qcom,sm8750
> +
>        - items:
>            - enum:
>                - qcom,x1e001de-devkit
> -- 
> 2.46.1
>
Melody Olvera Nov. 18, 2024, 10:08 p.m. UTC | #2 
On 11/15/2024 6:49 AM, Dmitry Baryshkov wrote:
> On Mon, Nov 11, 2024 at 04:49:31PM -0800, Melody Olvera wrote:
>> Document the SM8750 SoC binding and the boards which use it.
> Nit: In subject you have 'sm8750'. Please use single style for all SoC
> names (I think it's preferred to use uppercase).

Sure thing. Will use upper case.

Thanks,
Melody

>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 7c8c3a97506a..f4e8f8821405 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -86,6 +86,7 @@ description: |
>>           sm8450
>>           sm8550
>>           sm8650
>> +        sm8750
>>           x1e80100
>>   
>>     There are many devices in the list below that run the standard ChromeOS
>> @@ -1077,6 +1078,12 @@ properties:
>>                 - qcom,sm8650-qrd
>>             - const: qcom,sm8650
>>   
>> +      - items:
>> +          - enum:
>> +              - qcom,sm8750-mtp
>> +              - qcom,sm8750-qrd
>> +          - const: qcom,sm8750
>> +
>>         - items:
>>             - enum:
>>                 - qcom,x1e001de-devkit
>> -- 
>> 2.46.1
>>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 7c8c3a97506a..f4e8f8821405 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -86,6 +86,7 @@  description: |
         sm8450
         sm8550
         sm8650
+        sm8750
         x1e80100
 
   There are many devices in the list below that run the standard ChromeOS
@@ -1077,6 +1078,12 @@  properties:
               - qcom,sm8650-qrd
           - const: qcom,sm8650
 
+      - items:
+          - enum:
+              - qcom,sm8750-mtp
+              - qcom,sm8750-qrd
+          - const: qcom,sm8750
+
       - items:
           - enum:
               - qcom,x1e001de-devkit