| Message ID | 20241014-add_display_support_for_qcs615-v1-4-4efa191dbdd4@quicinc.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | add_display_support_for_QCS615 | expand |
On Mon, Oct 14, 2024 at 05:47:30PM +0800, fangez via B4 Relay wrote: > From: lliu6 <quic_lliu6@quicinc.com> > > QCS615 platform uses the 14nm DSI PHY driver. - bindings describe the hardware, not the drivers. - other platforms also have 14nm DSI PHY. Why do you need a separate compatible? > > Signed-off-by: lliu6 <quic_lliu6@quicinc.com> > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > index 52bbe132e6dae57246200757767edcd1c8ec2d77..029606d9e87e3b184bd10bd4a5076d6923d60e9e 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > @@ -20,6 +20,7 @@ properties: > - qcom,dsi-phy-14nm-660 > - qcom,dsi-phy-14nm-8953 > - qcom,sm6125-dsi-phy-14nm > + - qcom,qcs615-dsi-phy-14nm > > reg: > items: > > -- > 2.25.1 > >
On 14/10/2024 11:47, fangez via B4 Relay wrote: > From: lliu6 <quic_lliu6@quicinc.com> > > QCS615 platform uses the 14nm DSI PHY driver. This patchset is not ready for submission. Please perform first internal review. Please run scripts/checkpatch.pl and fix reported warnings. Then please run `scripts/checkpatch.pl --strict` and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> > > Signed-off-by: lliu6 <quic_lliu6@quicinc.com> > --- > Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > index 52bbe132e6dae57246200757767edcd1c8ec2d77..029606d9e87e3b184bd10bd4a5076d6923d60e9e 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > @@ -20,6 +20,7 @@ properties: > - qcom,dsi-phy-14nm-660 > - qcom,dsi-phy-14nm-8953 > - qcom,sm6125-dsi-phy-14nm > + - qcom,qcs615-dsi-phy-14nm Keep the order. Best regards, Krzysztof
On 2024/10/14 18:30, Dmitry Baryshkov wrote: > On Mon, Oct 14, 2024 at 05:47:30PM +0800, fangez via B4 Relay wrote: >> From: lliu6 <quic_lliu6@quicinc.com> >> >> QCS615 platform uses the 14nm DSI PHY driver. > > - bindings describe the hardware, not the drivers. > - other platforms also have 14nm DSI PHY. Why do you need a separate > compatible? We need to introduce a new regulator configuration for the PHY: dsi_phy_14nm_36mA_regulators. This configuration has not been used before. > >> >> Signed-off-by: lliu6 <quic_lliu6@quicinc.com> >> --- >> Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> index 52bbe132e6dae57246200757767edcd1c8ec2d77..029606d9e87e3b184bd10bd4a5076d6923d60e9e 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> @@ -20,6 +20,7 @@ properties: >> - qcom,dsi-phy-14nm-660 >> - qcom,dsi-phy-14nm-8953 >> - qcom,sm6125-dsi-phy-14nm >> + - qcom,qcs615-dsi-phy-14nm sorry, still have some question about this yaml file. it's necessary for b4 check checkpatch.pl: drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:564: WARNING: DT compatible string "qcom,dsi-phy-14nm-6150" appears un-doc umented -- check ./Documentation/devicetree/bindings/ need to add this new 6150 node for dsi-phy-14nm. shall i add it? >> >> reg: >> items: >> >> -- >> 2.25.1 >> >> > and could you please help to review the new version? Author: Li Liu <quic_lliu6@quicinc.com> Date: Tue Nov 19 12:35:12 2024 +0800 dt-bindings: display/msm: Add SM6150 DSI phy Add new compatible for SM6150 with dsi_phy_14nm_36mA_regulators Signed-off-by: Li Liu <quic_lliu6@quicinc.com> Signed-off-by: Fange Zhang <quic_fangez@quicinc.com> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml index 52bbe132e6da..fd6eb3434450 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml @@ -17,6 +17,7 @@ properties: enum: - qcom,dsi-phy-14nm - qcom,dsi-phy-14nm-2290 + - qcom,dsi-phy-14nm-6150 - qcom,dsi-phy-14nm-660 - qcom,dsi-phy-14nm-8953 - qcom,sm6125-dsi-phy-14nm
On Tue, Nov 19, 2024 at 12:45:00PM +0800, fange zhang wrote: > > > On 2024/10/14 18:30, Dmitry Baryshkov wrote: > > On Mon, Oct 14, 2024 at 05:47:30PM +0800, fangez via B4 Relay wrote: > > > From: lliu6 <quic_lliu6@quicinc.com> > > > > > > QCS615 platform uses the 14nm DSI PHY driver. > > > > - bindings describe the hardware, not the drivers. > > - other platforms also have 14nm DSI PHY. Why do you need a separate > > compatible? > We need to introduce a new regulator configuration for the PHY: > dsi_phy_14nm_36mA_regulators. This configuration has not been used before. > > > > > > > > > Signed-off-by: lliu6 <quic_lliu6@quicinc.com> > > > --- > > > Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > > > index 52bbe132e6dae57246200757767edcd1c8ec2d77..029606d9e87e3b184bd10bd4a5076d6923d60e9e 100644 > > > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > > > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > > > @@ -20,6 +20,7 @@ properties: > > > - qcom,dsi-phy-14nm-660 > > > - qcom,dsi-phy-14nm-8953 > > > - qcom,sm6125-dsi-phy-14nm > > > + - qcom,qcs615-dsi-phy-14nm qcom,sm6150-dsi-phy-14nm > sorry, still have some question about this yaml file. > it's necessary for b4 check > > checkpatch.pl: drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:564: WARNING: DT > compatible string "qcom,dsi-phy-14nm-6150" appears un-doc > umented -- check ./Documentation/devicetree/bindings/ > > need to add this new 6150 node for dsi-phy-14nm. > shall i add it? > > > > reg: > > > items: > > > > > > -- > > > 2.25.1 > > > > > > > > > > and could you please help to review the new version? > Author: Li Liu <quic_lliu6@quicinc.com> > Date: Tue Nov 19 12:35:12 2024 +0800 > > dt-bindings: display/msm: Add SM6150 DSI phy > > Add new compatible for SM6150 with dsi_phy_14nm_36mA_regulators > > Signed-off-by: Li Liu <quic_lliu6@quicinc.com> > Signed-off-by: Fange Zhang <quic_fangez@quicinc.com> > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > index 52bbe132e6da..fd6eb3434450 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml > @@ -17,6 +17,7 @@ properties: > enum: > - qcom,dsi-phy-14nm > - qcom,dsi-phy-14nm-2290 > + - qcom,dsi-phy-14nm-6150 qcom,sm6150-dsi-phy-14nm > - qcom,dsi-phy-14nm-660 > - qcom,dsi-phy-14nm-8953 > - qcom,sm6125-dsi-phy-14nm >
On 2024/11/20 20:22, Dmitry Baryshkov wrote: > On Tue, Nov 19, 2024 at 12:45:00PM +0800, fange zhang wrote: >> >> >> On 2024/10/14 18:30, Dmitry Baryshkov wrote: >>> On Mon, Oct 14, 2024 at 05:47:30PM +0800, fangez via B4 Relay wrote: >>>> From: lliu6 <quic_lliu6@quicinc.com> >>>> >>>> QCS615 platform uses the 14nm DSI PHY driver. >>> >>> - bindings describe the hardware, not the drivers. >>> - other platforms also have 14nm DSI PHY. Why do you need a separate >>> compatible? >> We need to introduce a new regulator configuration for the PHY: >> dsi_phy_14nm_36mA_regulators. This configuration has not been used before. >> >>> >>>> >>>> Signed-off-by: lliu6 <quic_lliu6@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >>>> index 52bbe132e6dae57246200757767edcd1c8ec2d77..029606d9e87e3b184bd10bd4a5076d6923d60e9e 100644 >>>> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >>>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >>>> @@ -20,6 +20,7 @@ properties: >>>> - qcom,dsi-phy-14nm-660 >>>> - qcom,dsi-phy-14nm-8953 >>>> - qcom,sm6125-dsi-phy-14nm >>>> + - qcom,qcs615-dsi-phy-14nm > > qcom,sm6150-dsi-phy-14nm ok, will fix it in next patch >> sorry, still have some question about this yaml file. >> it's necessary for b4 check >> >> checkpatch.pl: drivers/gpu/drm/msm/dsi/phy/dsi_phy.c:564: WARNING: DT >> compatible string "qcom,dsi-phy-14nm-6150" appears un-doc >> umented -- check ./Documentation/devicetree/bindings/ >> >> need to add this new 6150 node for dsi-phy-14nm. >> shall i add it? >> >>>> reg: >>>> items: >>>> >>>> -- >>>> 2.25.1 >>>> >>>> >>> >> >> and could you please help to review the new version? >> Author: Li Liu <quic_lliu6@quicinc.com> >> Date: Tue Nov 19 12:35:12 2024 +0800 >> >> dt-bindings: display/msm: Add SM6150 DSI phy >> >> Add new compatible for SM6150 with dsi_phy_14nm_36mA_regulators >> >> Signed-off-by: Li Liu <quic_lliu6@quicinc.com> >> Signed-off-by: Fange Zhang <quic_fangez@quicinc.com> >> >> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> index 52bbe132e6da..fd6eb3434450 100644 >> --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml >> @@ -17,6 +17,7 @@ properties: >> enum: >> - qcom,dsi-phy-14nm >> - qcom,dsi-phy-14nm-2290 >> + - qcom,dsi-phy-14nm-6150 > > qcom,sm6150-dsi-phy-14nm ok, will fix it in next patch > >> - qcom,dsi-phy-14nm-660 >> - qcom,dsi-phy-14nm-8953 >> - qcom,sm6125-dsi-phy-14nm >> >
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml index 52bbe132e6dae57246200757767edcd1c8ec2d77..029606d9e87e3b184bd10bd4a5076d6923d60e9e 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-phy-14nm.yaml @@ -20,6 +20,7 @@ properties: - qcom,dsi-phy-14nm-660 - qcom,dsi-phy-14nm-8953 - qcom,sm6125-dsi-phy-14nm + - qcom,qcs615-dsi-phy-14nm reg: items: