mbox series

[net-next,0/3] Add Aspeed G7 MDIO support

Message ID 20241118104735.3741749-1-jacky_chou@aspeedtech.com (mailing list archive)
Headers show
Series Add Aspeed G7 MDIO support | expand

Message

Jacky Chou Nov. 18, 2024, 10:47 a.m. UTC 
The Aspeed 7th generation SoC features three MDIO controllers.
The design of AST2700 MDIO controller is the same as AST2600.

Jacky Chou (3):
  dt-bindings: net: add support for AST2700
  net: mdio: aspeed: Add support for AST2700
  net: mdio: aspeed: Add dummy read for fire control

 .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml      | 4 +++-
 drivers/net/mdio/mdio-aspeed.c                            | 8 ++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

Comments

Andrew Lunn Nov. 19, 2024, 1:50 a.m. UTC | #1 
On Mon, Nov 18, 2024 at 06:47:32PM +0800, Jacky Chou wrote:
> The Aspeed 7th generation SoC features three MDIO controllers.
> The design of AST2700 MDIO controller is the same as AST2600.

If they are identical, why do you need a new compatible?

	Andrew
Jacky Chou Nov. 19, 2024, 5:35 a.m. UTC | #2 
Hi Andrew Lunn

Thank you for your reply.

> > The Aspeed 7th generation SoC features three MDIO controllers.
> > The design of AST2700 MDIO controller is the same as AST2600.
> 
> If they are identical, why do you need a new compatible?

We want consistent naming in the DTS of the new SoC, even if Its 
design is the same as the older SoC.

Thanks,
Jacky
Andrew Lunn Nov. 19, 2024, 1:25 p.m. UTC | #3 
On Tue, Nov 19, 2024 at 05:35:40AM +0000, Jacky Chou wrote:
> Hi Andrew Lunn
> 
> Thank you for your reply.
> 
> > > The Aspeed 7th generation SoC features three MDIO controllers.
> > > The design of AST2700 MDIO controller is the same as AST2600.
> > 
> > If they are identical, why do you need a new compatible?
> 
> We want consistent naming in the DTS of the new SoC, even if Its 
> design is the same as the older SoC.

You might find the DT Maintainers push back against this. What you
want is effectively a Marketing game, it has little to do with
technology, describing the hardware.

	Andrew