| Message ID | 20241112075826.28296-2-quic_rlaggysh@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add EPSS L3 provider support on SA8775P SoC | expand |
On Tue, Nov 12, 2024 at 07:58:24AM +0000, Raviteja Laggyshetty wrote: > Add Epoch Subsystem (EPSS) L3 interconnect provider binding on > SA8775P SoCs. > > Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> > --- > Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > index 21dae0b92819..94f7f283787a 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > @@ -33,6 +33,7 @@ properties: > - qcom,sm6375-cpucp-l3 > - qcom,sm8250-epss-l3 > - qcom,sm8350-epss-l3 > + - qcom,sa8775p-epss-l3 > - const: qcom,epss-l3 No, sa8775p isn't compatible with qcom,epss-l3. I asked you to split the driver patch, not to change the compatibles.
On 11/12/2024 7:20 PM, Dmitry Baryshkov wrote: > On Tue, Nov 12, 2024 at 07:58:24AM +0000, Raviteja Laggyshetty wrote: >> Add Epoch Subsystem (EPSS) L3 interconnect provider binding on >> SA8775P SoCs. >> >> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> >> --- >> Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml >> index 21dae0b92819..94f7f283787a 100644 >> --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml >> @@ -33,6 +33,7 @@ properties: >> - qcom,sm6375-cpucp-l3 >> - qcom,sm8250-epss-l3 >> - qcom,sm8350-epss-l3 >> + - qcom,sa8775p-epss-l3 >> - const: qcom,epss-l3 > > No, sa8775p isn't compatible with qcom,epss-l3. I asked you to split the > driver patch, not to change the compatibles. > > Got it, I will split the driver code changes into two patches. First patch will contain the SoC-specific compatible change and multi device support. Second patch will contain the generic compatible addition to of_match table.
On Mon, 18 Nov 2024 at 13:07, Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> wrote: > > > > On 11/12/2024 7:20 PM, Dmitry Baryshkov wrote: > > On Tue, Nov 12, 2024 at 07:58:24AM +0000, Raviteja Laggyshetty wrote: > >> Add Epoch Subsystem (EPSS) L3 interconnect provider binding on > >> SA8775P SoCs. > >> > >> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> > >> --- > >> Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > >> index 21dae0b92819..94f7f283787a 100644 > >> --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > >> +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > >> @@ -33,6 +33,7 @@ properties: > >> - qcom,sm6375-cpucp-l3 > >> - qcom,sm8250-epss-l3 > >> - qcom,sm8350-epss-l3 > >> + - qcom,sa8775p-epss-l3 > >> - const: qcom,epss-l3 > > > > No, sa8775p isn't compatible with qcom,epss-l3. I asked you to split the > > driver patch, not to change the compatibles. > > > > > Got it, I will split the driver code changes into two patches. > First patch will contain the SoC-specific compatible change and multi device support. no ands, just multidev. > Second patch will contain the generic compatible addition to of_match table. >
On 11/18/2024 4:42 PM, Dmitry Baryshkov wrote: > On Mon, 18 Nov 2024 at 13:07, Raviteja Laggyshetty > <quic_rlaggysh@quicinc.com> wrote: >> >> >> >> On 11/12/2024 7:20 PM, Dmitry Baryshkov wrote: >>> On Tue, Nov 12, 2024 at 07:58:24AM +0000, Raviteja Laggyshetty wrote: >>>> Add Epoch Subsystem (EPSS) L3 interconnect provider binding on >>>> SA8775P SoCs. >>>> >>>> Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml >>>> index 21dae0b92819..94f7f283787a 100644 >>>> --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml >>>> +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml >>>> @@ -33,6 +33,7 @@ properties: >>>> - qcom,sm6375-cpucp-l3 >>>> - qcom,sm8250-epss-l3 >>>> - qcom,sm8350-epss-l3 >>>> + - qcom,sa8775p-epss-l3 >>>> - const: qcom,epss-l3 >>> >>> No, sa8775p isn't compatible with qcom,epss-l3. I asked you to split the >>> driver patch, not to change the compatibles. >>> >>> >> Got it, I will split the driver code changes into two patches. >> First patch will contain the SoC-specific compatible change and multi device support. > > no ands, just multidev. ok, Will split multidev support as one patch. Generic and SoC-specific compatibles addition as second patch. > >> Second patch will contain the generic compatible addition to of_match table. >> > >
diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml index 21dae0b92819..94f7f283787a 100644 --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml @@ -33,6 +33,7 @@ properties: - qcom,sm6375-cpucp-l3 - qcom,sm8250-epss-l3 - qcom,sm8350-epss-l3 + - qcom,sa8775p-epss-l3 - const: qcom,epss-l3 reg:
Add Epoch Subsystem (EPSS) L3 interconnect provider binding on SA8775P SoCs. Signed-off-by: Raviteja Laggyshetty <quic_rlaggysh@quicinc.com> --- Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml | 1 + 1 file changed, 1 insertion(+)