| Message ID | 20241115-blaize-blzp1600_init_board_support-v5-1-c09094e63dc5@blaize.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Blaize BLZP1600 SoC | expand |
On 15/11/2024 15:58, Niko Pasaloukos wrote: > Blaize, Inc. (www.blaize.com) is a SoC manufacturer with integrated > programmable Graph-Streaming-Processors for AI and ML. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com> Here and in all other patches - you still have the same checkpatch warning I asked to fix. git format-patch -6 -v5 scripts/checkpatch.pl v5* Your SoB does not match From. This MUST be fixed. Best regards, Krzysztof
On 19/11/2024 13:05, Krzysztof Kozlowski wrote: > On 15/11/2024 15:58, Niko Pasaloukos wrote: >> Blaize, Inc. (www.blaize.com) is a SoC manufacturer with integrated >> programmable Graph-Streaming-Processors for AI and ML. >> >> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com> > Here and in all other patches - you still have the same checkpatch > warning I asked to fix. > > > git format-patch -6 -v5 > scripts/checkpatch.pl v5* > > Your SoB does not match From. This MUST be fixed. > > Best regards, > Krzysztof Hi Krzysztof, Just to be certain and fix it properly, do you mean that the issue that you are talking about is that the 'From' appears as 'Niko Pasaloukos' and I am signing with SoB as 'Nikolaos Pasaloukos'? I'm really sorry, if that's the case, I will fix it and yes, there must be a misconfiguration on my system. Would I need to prepare a v6 for this? If it is not that, then I am really sorry but I will need more information. Best regards, Nikolaos Pasaloukos
On 19/11/2024 14:33, Nikolaos Pasaloukos wrote: > On 19/11/2024 13:05, Krzysztof Kozlowski wrote: >> On 15/11/2024 15:58, Niko Pasaloukos wrote: >>> Blaize, Inc. (www.blaize.com) is a SoC manufacturer with integrated >>> programmable Graph-Streaming-Processors for AI and ML. >>> >>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >>> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com> >> Here and in all other patches - you still have the same checkpatch >> warning I asked to fix. >> >> >> git format-patch -6 -v5 >> scripts/checkpatch.pl v5* >> >> Your SoB does not match From. This MUST be fixed. >> >> Best regards, >> Krzysztof > > Hi Krzysztof, > > Just to be certain and fix it properly, do you mean that the issue that you > are talking about is that the 'From' appears as 'Niko Pasaloukos' and I am > signing with SoB as 'Nikolaos Pasaloukos'? Yes > I'm really sorry, if that's the case, I will fix it and yes, there must be > a misconfiguration on my system. Would I need to prepare a v6 for this? > If it is not that, then I am really sorry but I will need more information. Just run checkpatch. I am repeating this over and over. If you run it like above and there is no error, then provide some details. Best regards, Krzysztof
On 19/11/2024 13:37, Krzysztof Kozlowski wrote: > On 19/11/2024 14:33, Nikolaos Pasaloukos wrote: >> On 19/11/2024 13:05, Krzysztof Kozlowski wrote: >>> On 15/11/2024 15:58, Niko Pasaloukos wrote: >>>> Blaize, Inc. (www.blaize.com) is a SoC manufacturer with integrated >>>> programmable Graph-Streaming-Processors for AI and ML. >>>> >>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >>>> Signed-off-by: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com> >>> Here and in all other patches - you still have the same checkpatch >>> warning I asked to fix. >>> >>> >>> git format-patch -6 -v5 >>> scripts/checkpatch.pl v5* >>> >>> Your SoB does not match From. This MUST be fixed. >>> >>> Best regards, >>> Krzysztof >> Hi Krzysztof, >> >> Just to be certain and fix it properly, do you mean that the issue that you >> are talking about is that the 'From' appears as 'Niko Pasaloukos' and I am >> signing with SoB as 'Nikolaos Pasaloukos'? > Yes > >> I'm really sorry, if that's the case, I will fix it and yes, there must be >> a misconfiguration on my system. Would I need to prepare a v6 for this? >> If it is not that, then I am really sorry but I will need more information. > Just run checkpatch. I am repeating this over and over. If you run it > like above and there is no error, then provide some details. > > > Best regards, > Krzysztof Hi Krzysztof, That's a very tricky error to pick it up. `checkpatch` on my end doesn't produce an error. The header file on my patches starts as: 'From: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>' I had set the mail account as Forname: Nikolaos, Surname: Pasaloukos and preferred name as Niko. It is an Outlook365 issue I think. That said, when I was trying to send my patches, the mail server was converting my name 'Nikolaos Pasaloukos' to the preferred name 'Niko Pasaloukos'. Do I need to resend v5 again after this is fixed, having applied all the additional Reviewed-by? What would be my next step here? Best regards, Nikolaos Pasaloukos
On 19/11/2024 16:23, Nikolaos Pasaloukos wrote: > Hi Krzysztof, > > That's a very tricky error to pick it up. `checkpatch` on my end doesn't produce > an error. The header file on my patches starts as: > 'From: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>' > I had set the mail account as Forname: Nikolaos, Surname: Pasaloukos and > preferred name as Niko. It is an Outlook365 issue I think. > > That said, when I was trying to send my patches, the mail server was converting > my name 'Nikolaos Pasaloukos' to the preferred name 'Niko Pasaloukos'. Usually it is not a problem to commit patches with one name and send with other - git send-email will properly add two From headers like: https://lore.kernel.org/all/20241119154245.442961-4-pablo@netfilter.org/ If your git history has correct From matching SoB, then indeed checkpatch on your end will not complain. If that is the case, it means your SMTP server *rewrites* the From header. Not nice... but what to expect from Microsoft? They learnt open source just recently and before open source was communism for them... You can change your local name to match whatever Microsoft wants to set or you can use b4 relay to send the patches. https://b4.docs.kernel.org/en/latest/contributor/send.html > > Do I need to resend v5 again after this is fixed, having applied all the > additional Reviewed-by? What would be my next step here? Yes, please resend a v5 with tags applied and fixed problem with From/SoB. Best regards, Krzysztof
On 19/11/2024 15:52, Krzysztof Kozlowski wrote: > On 19/11/2024 16:23, Nikolaos Pasaloukos wrote: >> Hi Krzysztof, >> >> That's a very tricky error to pick it up. `checkpatch` on my end doesn't produce >> an error. The header file on my patches starts as: >> 'From: Nikolaos Pasaloukos <nikolaos.pasaloukos@blaize.com>' >> I had set the mail account as Forname: Nikolaos, Surname: Pasaloukos and >> preferred name as Niko. It is an Outlook365 issue I think. >> >> That said, when I was trying to send my patches, the mail server was converting >> my name 'Nikolaos Pasaloukos' to the preferred name 'Niko Pasaloukos'. > Usually it is not a problem to commit patches with one name and send > with other - git send-email will properly add two From headers like: > https://urldefense.com/v3/__https://lore.kernel.org/all/20241119154245.442961-4-pablo@netfilter.org/__;!!FddXBOku!jmi9Ec3WZ4N6TfC0XlHzSmeISVpB19XDD-TfRyCDgkc6WpnZnjDJMz4bZWeoOY8X6YaL9GnapF-AIw-Cjyer$ > > If your git history has correct From matching SoB, then indeed > checkpatch on your end will not complain. > > If that is the case, it means your SMTP server *rewrites* the From > header. Not nice... but what to expect from Microsoft? They learnt open > source just recently and before open source was communism for them... > > You can change your local name to match whatever Microsoft wants to set > or you can use b4 relay to send the patches. I'll add your Reviewed-by on the patches and I will send again v5 patches using the b4 relay endpoint instead of my SMTP server. > > https://urldefense.com/v3/__https://b4.docs.kernel.org/en/latest/contributor/send.html__;!!FddXBOku!jmi9Ec3WZ4N6TfC0XlHzSmeISVpB19XDD-TfRyCDgkc6WpnZnjDJMz4bZWeoOY8X6YaL9GnapF-AI5htzUil$ > >> Do I need to resend v5 again after this is fixed, having applied all the >> additional Reviewed-by? What would be my next step here? > Yes, please resend a v5 with tags applied and fixed problem with From/SoB. > > > Best regards, > Krzysztof Thank you for helping me out. Best regards, Nikolaos Pasaloukos
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index b320a39de7fe40ce4d97ed3ea264a5971a3428dd..809086061a1992567ca6c5d404fbcee8a33ee300 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -216,6 +216,8 @@ patternProperties: description: Shenzhen BigTree Tech Co., LTD "^bitmain,.*": description: Bitmain Technologies + "^blaize,.*": + description: Blaize, Inc. "^blutek,.*": description: BluTek Power "^boe,.*":