| Message ID | 20241119160932.1327864-5-hch@lst.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/6] block: return unsigned int from bdev_io_opt | expand |
On 19/11/2024 16:09, Christoph Hellwig wrote: > blk_rq_aligned returns a boolean condition, don't mascquerade it as int. I think that the spelling is masquerade. Well according to spellcheck... > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: John Garry <john.g.garry@oracle.com> > --- > include/linux/blkdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 74e3c611a4f7..e4fc967e8cb9 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -1464,7 +1464,7 @@ blk_lim_dma_alignment_and_pad(struct queue_limits *lim) > return lim->dma_alignment | lim->dma_pad_mask; > } > > -static inline int blk_rq_aligned(struct request_queue *q, unsigned long addr, > +static inline bool blk_rq_aligned(struct request_queue *q, unsigned long addr, > unsigned int len) > { > unsigned int alignment = blk_lim_dma_alignment_and_pad(&q->limits);
On Tue, Nov 19, 2024 at 04:34:34PM +0000, John Garry wrote: > On 19/11/2024 16:09, Christoph Hellwig wrote: >> blk_rq_aligned returns a boolean condition, don't mascquerade it as int. > > I think that the spelling is masquerade. Well according to spellcheck... Hmm, I thought I had fixed that up because the spellchecker noticed it, but I guess I fumbled that up.
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 74e3c611a4f7..e4fc967e8cb9 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1464,7 +1464,7 @@ blk_lim_dma_alignment_and_pad(struct queue_limits *lim) return lim->dma_alignment | lim->dma_pad_mask; } -static inline int blk_rq_aligned(struct request_queue *q, unsigned long addr, +static inline bool blk_rq_aligned(struct request_queue *q, unsigned long addr, unsigned int len) { unsigned int alignment = blk_lim_dma_alignment_and_pad(&q->limits);
blk_rq_aligned returns a boolean condition, don't mascquerade it as int. Signed-off-by: Christoph Hellwig <hch@lst.de> --- include/linux/blkdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)